block/blkio: Tolerate device size changes
PATCH 1/1 block/blkio: Tolerate device size changes
Some libblkio drivers may be able to work with regular files (e.g., io_uring) or otherwise resizable devices. Conservatively set BlockDriver::has_variable_length to true to ensure bdrv_nb_sectors() always gives up-to-date results.
Also implement BlockDriver::bdrv_co_truncate for the case where no preallocation is needed and the device already has a size compatible with what was requested.
---
This is based on Stefan's block tree:
https://gitlab.com/stefanha/qemu/-/commits/block
block/blkio.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)
block/blkio.c +27 -0
@@ -845,6 +845,31 @@ static int64_t blkio_getlength(BlockDriverState *bs)return capacity; } +static int coroutine_fn blkio_truncate(BlockDriverState *bs, int64_t offset, +bool exact,PreallocMode prealloc, +BdrvRequestFlags flags,Error **errp) +{ +int64_t current_length; + +if (prealloc !=PREALLOC_MODE_OFF ) { +error_setg (errp,"Unsupported preallocation mode '%s'" , +PreallocMode_str (prealloc)); +return -ENOTSUP ; + } + + current_length =blkio_getlength (bs); + +if (offset > current_length) { +error_setg (errp,"Cannot grow device" ); +return -EINVAL ; + }else if (exact && offset != current_length) { +error_setg (errp,"Cannot resize device" ); +return -ENOTSUP ; + } + +return 0 ; +} +static int blkio_get_info (BlockDriverState *bs,BlockDriverInfo *bdi) {return 0 ;
@@ -960,10 +985,12 @@ static void blkio_refresh_limits(BlockDriverState *bs, Error **errp) { \ .format_name = name, \ .protocol_name = name, \ + .has_variable_length = true, \ .instance_size = sizeof(BDRVBlkioState), \ .bdrv_file_open = blkio_file_open, \ .bdrv_close = blkio_close, \ .bdrv_getlength = blkio_getlength, \ + .bdrv_co_truncate = blkio_truncate, \ .bdrv_get_info = blkio_get_info, \ .bdrv_attach_aio_context = blkio_attach_aio_context, \ .bdrv_detach_aio_context = blkio_detach_aio_context, \
Signature · 1 line
2.38.1
Stefan Hajnoczi
AppliedQuoted 9 lines · Alberto Faria
Some libblkio drivers may be able to work with regular files (e.g.,
io_uring) or otherwise resizable devices. Conservatively setBlockDriver::has_variable_lengthto true to ensurebdrv_nb_sectors()always gives up-to-date results.Also implement
BlockDriver::bdrv_co_truncatefor the case where no preallocation is needed and the device already has a size compatible with what was requested.
Quoted 8 lines
Signed-off-by Alberto Faria <[email protected]>---
This is based on Stefan's block tree:
https://gitlab.com/stefanha/qemu/-/commits/blockblock/blkio.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)
Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block
Stefan
Am 29.10.2022 um 14:20 hat Alberto Faria geschrieben:
Quoted 55 lines
Some libblkio drivers may be able to work with regular files (e.g.,
io_uring) or otherwise resizable devices. Conservatively setBlockDriver::has_variable_lengthto true to ensurebdrv_nb_sectors()always gives up-to-date results.Also implement
BlockDriver::bdrv_co_truncatefor the case where no preallocation is needed and the device already has a size compatible with what was requested.Signed-off-by Alberto Faria <[email protected]>---
This is based on Stefan's block tree:
https://gitlab.com/stefanha/qemu/-/commits/blockblock/blkio.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)block/blkio.c +25
-0@@ -845,6 +845,31 @@ static int64_t blkio_getlength(BlockDriverState *bs)return capacity; } +static int coroutine_fn blkio_truncate(BlockDriverState *bs, int64_t offset, +bool exact,PreallocMode prealloc, +BdrvRequestFlags flags,Error **errp) +{ +int64_t current_length; + +if (prealloc !=PREALLOC_MODE_OFF ) { +error_setg (errp,"Unsupported preallocation mode '%s'" , +PreallocMode_str (prealloc)); +return -ENOTSUP ; + } + + current_length =blkio_getlength (bs); + +if (offset > current_length) { +error_setg (errp,"Cannot grow device" ); +return -EINVAL ; + }else if (exact && offset != current_length) { +error_setg (errp,"Cannot resize device" ); +return -ENOTSUP ; + } + +return 0 ; +} +static int blkio_get_info (BlockDriverState *bs,BlockDriverInfo *bdi) {return 0 ;
block/blkio.c static void blkio_refresh_limits(BlockDriverState *bs, Error **errp) · line 988
Quoted 4 lines
block/blkio.c +1
-0@@ -960,10 +985,12 @@ static void blkio_refresh_limits(BlockDriverState *bs, Error **errp) { \ .format_name = name, \ .protocol_name = name, \ + .has_variable_length = true, \
I don't think this is a good idea, it will read the capacity from libblkio before every single request, which can't result in good performance.
We're generally only using .has_variable_length for removable media on the backend (i.e. for host_cdrom and filters that can potentially sit on top of it, but will used the cached value on the protocol level again for other protocol drivers).
If you resize a host_device, you need to use QMP 'block_resize' explicitly. I think it should be the same for libblkio.
Kevin