Skip to contentSkip to conversation

package/iwd: set dbus busdir

PATCH In review James Hilliard 2 participants 3 messages Oct 31, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/iwd: set dbus busdir

In 5b3b2d80f4cf586d360ff696c3dacbd4cb48fdc4 we dropped dbus as a build dependency, as such we also need to set --with-dbus-busdir which would otherwise be pulled via pkg-config.

Fixes:
checking D-Bus bus services directory... configure: error: D-Bus bus services directory is required

---
 package/iwd/iwd.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/iwd/iwd.mk +2 -1
index 002988cf33..e53ae595d7 100644
@@ -17,7 +17,8 @@ IWD_CONF_OPTS = \
 	--disable-manual-pages \
 	--enable-external-ell \
 	--enable-dbus-policy \
-	--with-dbus-datadir=/usr/share
+	--with-dbus-datadir=/usr/share \
+	--with-dbus-busdir=/usr/share/dbus-1/system-services
 IWD_DEPENDENCIES = ell
 
 ifeq ($(BR2_PACKAGE_READLINE),y)
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

James, All,

+Daniel

On 2022-10-30 19:09 -0600, James Hilliard spake thusly:

Quoted 6 lines

In 5b3b2d80f4cf586d360ff696c3dacbd4cb48fdc4 we dropped dbus as a build dependency, as such we also need to set --with-dbus-busdir which would otherwise be pulled via pkg-config.

Fixes:
checking D-Bus bus services directory... configure: error: D-Bus bus services directory is required

I was surprised that I did not have this error locally, but it only happens when systemd is enabled.

So, rather than hard-code the path, I think I would prefer we add back a buid dependency on dbus when systemd is enabled:

    diff --git a/package/iwd/iwd.mk b/package/iwd/iwd.mk
    index 002988cf33..6e366e094d 100644
    --- a/package/iwd/iwd.mk
    +++ b/package/iwd/iwd.mk
    @@ -31,7 +31,8 @@ endif
    
     ifeq ($(BR2_PACKAGE_SYSTEMD),y)
     IWD_CONF_OPTS += --enable-systemd-service
    -IWD_DEPENDENCIES += systemd
    +# Need dbus for system_bus_services_dir variable provided by dbus' .pc
    +IWD_DEPENDENCIES += dbus systemd
     else
     IWD_CONF_OPTS += --disable-systemd-service
     endif

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 package/iwd/iwd.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/iwd/iwd.mk +2 -1
index 002988cf33..e53ae595d7 100644
@@ -17,7 +17,8 @@ IWD_CONF_OPTS = \
 	--disable-manual-pages \
 	--enable-external-ell \
 	--enable-dbus-policy \
-	--with-dbus-datadir=/usr/share
+	--with-dbus-datadir=/usr/share \
+	--with-dbus-busdir=/usr/share/dbus-1/system-services
 IWD_DEPENDENCIES = ell
 
 ifeq ($(BR2_PACKAGE_READLINE),y)
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
Quoted 19 lines · Yann E. MORIN

James, All,

+Daniel

On 2022-10-30 19:09 -0600, James Hilliard spake thusly:

Quoted 6 lines

In 5b3b2d80f4cf586d360ff696c3dacbd4cb48fdc4 we dropped dbus as a build dependency, as such we also need to set --with-dbus-busdir which would otherwise be pulled via pkg-config.

Fixes:
checking D-Bus bus services directory... configure: error: D-Bus bus services directory is required

I was surprised that I did not have this error locally, but it only happens when systemd is enabled.

So, rather than hard-code the path, I think I would prefer we add back a buid dependency on dbus when systemd is enabled:

Quoted 14 lines
    diff --git a/package/iwd/iwd.mk b/package/iwd/iwd.mk
    index 002988cf33..6e366e094d 100644
    --- a/package/iwd/iwd.mk
    +++ b/package/iwd/iwd.mk
    @@ -31,7 +31,8 @@ endif

     ifeq ($(BR2_PACKAGE_SYSTEMD),y)
     IWD_CONF_OPTS += --enable-systemd-service
    -IWD_DEPENDENCIES += systemd
    +# Need dbus for system_bus_services_dir variable provided by dbus' .pc
    +IWD_DEPENDENCIES += dbus systemd
     else
     IWD_CONF_OPTS += --disable-systemd-service
     endif

Sent as suggested in v2 patch:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Quoted 33 lines

Regards,
Yann E. MORIN.

Quoted 22 lines
---
 package/iwd/iwd.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/iwd/iwd.mk +2 -2
index 002988cf33..e53ae595d7 100644
@@ -17,7 +17,8 @@ IWD_CONF_OPTS = \
      --disable-manual-pages \
      --enable-external-ell \
      --enable-dbus-policy \
-     --with-dbus-datadir=/usr/share
+     --with-dbus-datadir=/usr/share \
+     --with-dbus-busdir=/usr/share/dbus-1/system-services
 IWD_DEPENDENCIES = ell
 
 ifeq ($(BR2_PACKAGE_READLINE),y)
--

2.34.1

Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

--
.-----------------.--------------------.------------------.--------------------.

Quoted 5 lines
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot