Skip to contentSkip to conversation

Drop dma-coherent property from SA2UL

PATCH Applied Jayesh Choudhary 2 participants 5 messages Oct 31, 2022 – Nov 15, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Drop dma-coherent property from SA2UL

crypto driver itself is not dma-coherent. It is the system-dma that moves data and so 'dma-coherent' property should be dropped.

This series drop it from the crypto nodes for the J7 family of TI SoCs.

DT binding fixes have already been merged[0].

[0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a536208da6f7d877f1adbad4ff13f63f31f59d91

Jayesh Choudhary (3):
arm64: dts: ti: k3-am65-main: drop dma-coherent in crypto node
arm64: dts: ti: k3-j721e-main: drop dma-coherent in crypto node
arm64: dts: ti: k3-j7200-mcu-wakeup: drop dma-coherent in crypto node

 arch/arm64/boot/dts/ti/k3-am65-main.dtsi        | 1 -
 arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 1 -
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi       | 1 -
 3 files changed, 3 deletions(-)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/3 arm64: dts: ti: k3-am65-main: drop dma-coherent in crypto node

crypto driver itself is not dma-coherent. So drop it.

Fixes b366b2409c97 ("arm64: dts: ti: k3-am6: Add crypto accelarator node")
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +0 -1
index 4005a73cfea9..ebb1c5ce7aec 100644
@@ -120,7 +120,6 @@ crypto: crypto@4e00000 {
 		dmas = <&main_udmap 0xc001>, <&main_udmap 0x4002>,
 				<&main_udmap 0x4003>;
 		dma-names = "tx", "rx1", "rx2";
-		dma-coherent;
 
 		rng: rng@4e10000 {
 			compatible = "inside-secure,safexcel-eip76";
Signature · 1 line
2.25.1
#2 lore raw

PATCH 2/3 arm64: dts: ti: k3-j721e-main: drop dma-coherent in crypto node

In reply to Jayesh Choudhary

crypto driver itself is not dma-coherent. So drop it.

Fixes 8ebcaaae8017 ("arm64: dts: ti: k3-j721e-main: Add crypto accelerator node")
---
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +0 -1
index 5c4a0e28cde5..9ec38190da8d 100644
@@ -349,7 +349,6 @@ main_crypto: crypto@4e00000 {
 		dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
 				<&main_udmap 0x4001>;
 		dma-names = "tx", "rx1", "rx2";
-		dma-coherent;
 
 		rng: rng@4e10000 {
 			compatible = "inside-secure,safexcel-eip76";
Signature · 1 line
2.25.1
#3 lore raw

PATCH 3/3 arm64: dts: ti: k3-j7200-mcu-wakeup: drop dma-coherent in crypto node

In reply to Jayesh Choudhary

crypto driver itself is not dma-coherent. So drop it.

Fixes d683a73980a6 ("arm64: dts: ti: k3-j7200-mcu-wakeup: Add SA2UL node")
---
 arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +0 -1
index 2006933f9b49..e85106f55bee 100644
@@ -391,7 +391,6 @@ mcu_crypto: crypto@40900000 {
 		dmas = <&mcu_udmap 0xf501>, <&mcu_udmap 0x7502>,
 		       <&mcu_udmap 0x7503>;
 		dma-names = "tx", "rx1", "rx2";
-		dma-coherent;
 
 		rng: rng@40910000 {
 			compatible = "inside-secure,safexcel-eip76";
Signature · 1 line
2.25.1
maintainer Applied
#4 lore raw
In reply to Jayesh Choudhary

Hi Jayesh Choudhary,

Quoted 9 lines · Jayesh Choudhary

crypto driver itself is not dma-coherent. It is the system-dma that moves data and so 'dma-coherent' property should be dropped.

This series drop it from the crypto nodes for the J7 family of TI SoCs.

DT binding fixes have already been merged[0].

[...]

(note: I picked up Manorit's reviewed-by as well)

I have applied the following to branch ti-k3-dts-next on [1]. Thank you!

[1/3] arm64: dts: ti: k3-am65-main: drop dma-coherent in crypto node

      commit: b86833ab3653dbb0dc453eec4eef8615e63de4e2
[2/3] arm64: dts: ti: k3-j721e-main: drop dma-coherent in crypto node
      commit: 26c5012403f3f1fd3bf8f7d3389ee539ae5cc162
[3/3] arm64: dts: ti: k3-j7200-mcu-wakeup: drop dma-coherent in crypto node
      commit: f00f26711d7183f8675c5591ba8daaabe94be452

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D