Skip to contentSkip to conversation

staging: r8188eu: use ether_addr_equal in OnAction

PATCH In review Martin Kaiser 2 participants 2 messages Oct 31, 2022 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: r8188eu: use ether_addr_equal in OnAction

Use ether_addr_equal to compare two mac addresses in OnAction.

Both struct ieee80211_mgmt and struct eeprom_priv's mac_addr component are 2-byte aligned.

---
 drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/r8188eu/core/rtw_mlme_ext.c +1 -1
index e985fc5fc575..6679d4037d6b 100644
@@ -3823,7 +3823,7 @@ static void OnAction(struct adapter *padapter, struct recv_frame *precv_frame)
 {
 	struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)precv_frame->rx_data;
 
-	if (memcmp(myid(&padapter->eeprompriv), mgmt->da, ETH_ALEN))
+	if (!ether_addr_equal(myid(&padapter->eeprompriv), mgmt->da))
 		return;
 
 	switch (mgmt->u.action.category) {
Signature · 1 line
2.30.2
Tested-by on v1 1/1
#1 lore raw
Quoted 16 lines · Martin Kaiser

Use ether_addr_equal to compare two mac addresses in OnAction.

Both struct ieee80211_mgmt and struct eeprom_priv's mac_addr component are 2-byte aligned.

---
  drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/r8188eu/core/rtw_mlme_ext.c +0 -0
index e985fc5fc575..6679d4037d6b 100644

drivers/staging/r8188eu/core/rtw_mlme_ext.c static void OnAction(struct adapter *padapter, struct recv_frame *precv_frame) · line 3829

Quoted 8 lines
drivers/staging/r8188eu/core/rtw_mlme_ext.c +1 -1
@@ -3823,7 +3823,7 @@ static void OnAction(struct adapter *padapter, struct recv_frame *precv_frame)
  {
  	struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)precv_frame->rx_data;
 
-	if (memcmp(myid(&padapter->eeprompriv), mgmt->da, ETH_ALEN))
+	if (!ether_addr_equal(myid(&padapter->eeprompriv), mgmt->da))
  		return;
 
  	switch (mgmt->u.action.category) {