Skip to contentSkip to conversation

baseband/acc100: changes for 22.11

PATCH Superseded Hernan Vargas 4 participants 8 messages Oct 31, 2022 – Nov 3, 2022

v7 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

v7 cover baseband/acc100: changes for 22.11

v7: Not including dependency on SDK introduced in previous v3 for now due to lack of consensus yet.
Still detecting the known corner case and flagging it.
v6: Fix commit message typo.
v5: Fix compilation error and squash documentation changes.
v4: Rebased code to use the latest ACC common API and implemented review comment changes.
v3: Code refactor based on comments and grouping fixes at beginning of series.
v2: Rebased code to use ACC common API.
v1: Upstreaming ACC100 changes for 22.11.
This patch series is dependant on series:
https://patches.dpdk.org/project/dpdk/list/?series=25191

Hernan Vargas (1):
baseband/acc100: add detection for deRM corner cases

 drivers/baseband/acc/acc_common.h     |  8 ++++
 drivers/baseband/acc/rte_acc100_pmd.c | 55 +++++++++++++++++++++++++--
 2 files changed, 60 insertions(+), 3 deletions(-)
Signature · 1 line
2.37.1
#1 lore raw

PATCH v7 1/1 baseband/acc100: add detection for deRM corner cases

Add function to detect if de-ratematch pre-processing is recommended for SW corner cases.
Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to the user.

---
 drivers/baseband/acc/acc_common.h     |  8 ++++
 drivers/baseband/acc/rte_acc100_pmd.c | 55 +++++++++++++++++++++++++--
 2 files changed, 60 insertions(+), 3 deletions(-)
drivers/baseband/acc/acc_common.h +8 -0
index eae7eab4e9..6213b0b61e 100644
@@ -123,6 +123,14 @@
 #define ACC_HARQ_ALIGN_64B          64
 #define ACC_MAX_ZC                  384
 
+/* De-ratematch code rate limitation for recommended operation */
+#define ACC_LIM_03 2  /* 0.03 */
+#define ACC_LIM_09 6  /* 0.09 */
+#define ACC_LIM_14 9  /* 0.14 */
+#define ACC_LIM_21 14 /* 0.21 */
+#define ACC_LIM_31 20 /* 0.31 */
+#define ACC_MAX_E (128 * 1024 - 2)
+
 /* Helper macro for logging */
 #define rte_acc_log(level, fmt, ...) \
 	rte_log(RTE_LOG_ ## level, RTE_LOG_NOTICE, fmt "\n", \
drivers/baseband/acc/rte_acc100_pmd.c +52 -3

100 lines not on this page · raw message

Signature · 1 line
2.37.1
#2 lore raw

RE: [EXT] [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

Quoted 8 lines

Add function to detect if de-ratematch pre-processing is recommended for SW corner cases.
Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to the user.

Hi Tom/Maxime,

Any further comments?

#3 lore raw

Re: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

In reply to Hernan Vargas
Quoted 122 lines · Hernan Vargas

Add function to detect if de-ratematch pre-processing is recommended for SW corner cases.
Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to the user.

---
  drivers/baseband/acc/acc_common.h     |  8 ++++
  drivers/baseband/acc/rte_acc100_pmd.c | 55 +++++++++++++++++++++++++--
  2 files changed, 60 insertions(+), 3 deletions(-)
drivers/baseband/acc/acc_common.h +8 -0
index eae7eab4e9..6213b0b61e 100644
@@ -123,6 +123,14 @@
  #define ACC_HARQ_ALIGN_64B          64
  #define ACC_MAX_ZC                  384
 
+/* De-ratematch code rate limitation for recommended operation */
+#define ACC_LIM_03 2  /* 0.03 */
+#define ACC_LIM_09 6  /* 0.09 */
+#define ACC_LIM_14 9  /* 0.14 */
+#define ACC_LIM_21 14 /* 0.21 */
+#define ACC_LIM_31 20 /* 0.31 */
+#define ACC_MAX_E (128 * 1024 - 2)
+
  /* Helper macro for logging */
  #define rte_acc_log(level, fmt, ...) \
  	rte_log(RTE_LOG_ ## level, RTE_LOG_NOTICE, fmt "\n", \
drivers/baseband/acc/rte_acc100_pmd.c +45 -2
index 23bc5d25bb..47609f95b7 100644
@@ -756,6 +756,14 @@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,
  		ret = -ENOMEM;
  		goto free_lb_out;
  	}
+	q->derm_buffer = rte_zmalloc_socket(dev->device->driver->name,
+			RTE_BBDEV_TURBO_MAX_CB_SIZE * 10,
+			RTE_CACHE_LINE_SIZE, conf->socket);
+	if (q->derm_buffer == NULL) {
+		rte_bbdev_log(ERR, "Failed to allocate derm_buffer memory");
+		ret = -ENOMEM;
+		goto free_companion_ring_addr;
+	}
 
  	/*
  	 * Software queue ring wraps synchronously with the HW when it reaches
@@ -776,7 +784,7 @@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,
  	q_idx = acc100_find_free_queue_idx(dev, conf);
  	if (q_idx == -1) {
  		ret = -EINVAL;
-		goto free_companion_ring_addr;
+		goto free_derm_buffer;
  	}
 
  	q->qgrp_id = (q_idx >> ACC100_GRP_ID_SHIFT) & 0xF;
@@ -804,6 +812,9 @@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,
  	dev->data->queues[queue_id].queue_private = q;
  	return 0;
 
+free_derm_buffer:
+	rte_free(q->derm_buffer);
+	q->derm_buffer = NULL;
  free_companion_ring_addr:
  	rte_free(q->companion_ring_addr);
  	q->companion_ring_addr = NULL;
@@ -890,6 +901,7 @@ acc100_queue_release(struct rte_bbdev *dev, uint16_t q_id)
  		/* Mark the Queue as un-assigned */
  		d->q_assigned_bit_map[q->qgrp_id] &= (0xFFFFFFFFFFFFFFFF -
  				(uint64_t) (1 << q->aq_id));
+		rte_free(q->derm_buffer);
  		rte_free(q->companion_ring_addr);
  		rte_free(q->lb_in);
  		rte_free(q->lb_out);
@@ -3111,10 +3123,41 @@ harq_loopback(struct acc_queue *q, struct rte_bbdev_dec_op *op,
  	return 1;
  }
 
+/* Assess whether a work around is recommended for the deRM corner cases */
+static inline bool
+derm_workaround_recommended(struct rte_bbdev_op_ldpc_dec *ldpc_dec, struct acc_queue *q)
+{
+	if (!is_acc100(q))
+		return false;
+	int32_t e = ldpc_dec->cb_params.e;
+	int q_m = ldpc_dec->q_m;
+	int z_c = ldpc_dec->z_c;
+	int K = (ldpc_dec->basegraph == 1 ? ACC_K_ZC_1 : ACC_K_ZC_2) * z_c;
+	bool recommended = false;
+
+	if (ldpc_dec->basegraph == 1) {
+		if ((q_m == 4) && (z_c >= 320) && (e * ACC_LIM_31 > K * 64))
+			recommended = true;
+		else if ((e * ACC_LIM_21 > K * 64))
+			recommended = true;
+	} else {
+		if (q_m <= 2) {
+			if ((z_c >= 208) && (e * ACC_LIM_09 > K * 64))
+				recommended = true;
+			else if ((z_c < 208) && (e * ACC_LIM_03 > K * 64))
+				recommended = true;
+		} else if (e * ACC_LIM_14 > K * 64)
+			recommended = true;
+	}
+
+	return recommended;
+}
+
  /** Enqueue one decode operations for ACC100 device in CB mode */
  static inline int
  enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
-		uint16_t total_enqueued_cbs, bool same_op)
+		uint16_t total_enqueued_cbs, bool same_op,
+		struct rte_bbdev_queue_data *q_data)
  {
  	int ret;
  	if (unlikely(check_bit(op->ldpc_dec.op_flags,

drivers/baseband/acc/rte_acc100_pmd.c enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op, · line 3216

Quoted 6 lines
drivers/baseband/acc/rte_acc100_pmd.c +3 -0
@@ -3168,6 +3211,12 @@ enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op,
  	} else {
  		struct acc_fcw_ld *fcw;
  		uint32_t seg_total_left;
+
+		if (derm_workaround_recommended(&op->ldpc_dec, q)) {
+			RTE_SET_USED(q_data);

Why do we need q_data if it is not being used?

Quoted 15 lines
drivers/baseband/acc/rte_acc100_pmd.c +4 -1
+			rte_bbdev_log(INFO, "Corner case may require deRM pre-processing");
+		}
+
  		fcw = &desc->req.fcw_ld;
  		q->d->fcw_ld_fill(op, fcw, harq_layout);
 
@@ -3721,7 +3770,7 @@ acc100_enqueue_ldpc_dec_cb(struct rte_bbdev_queue_data *q_data,
  			ops[i]->ldpc_dec.n_cb, ops[i]->ldpc_dec.q_m,
  			ops[i]->ldpc_dec.n_filler, ops[i]->ldpc_dec.cb_params.e,
  			same_op);
-		ret = enqueue_ldpc_dec_one_op_cb(q, ops[i], i, same_op);
+		ret = enqueue_ldpc_dec_one_op_cb(q, ops[i], i, same_op, q_data);
  		if (ret < 0) {
  			acc_enqueue_invalid(q_data);
  			break;
#4 lore raw

RE: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

Hi Maxime,

Quoted 141 lines

-----Original Message-----
From: Maxime Coquelin <[email protected]>
Sent: Thursday, November 3, 2022 7:10 AM
To: Vargas, Hernan <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: Chautru, Nicolas <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: Re: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

Quoted 11 lines · Hernan Vargas

Add function to detect if de-ratematch pre-processing is recommended for SW corner cases.
Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to the user.

---
  drivers/baseband/acc/acc_common.h     |  8 ++++
  drivers/baseband/acc/rte_acc100_pmd.c | 55

+++++++++++++++++++++++++--

drivers/baseband/acc/rte_acc100_pmd.c acc100_queue_setup(struct rte_bbdev *dev,

Quoted 25 lines
  2 files changed, 60 insertions(+), 3 deletions(-)
drivers/baseband/acc/acc_common.h +5 -0
index eae7eab4e9..6213b0b61e 100644
@@ -123,6 +123,14 @@
  #define ACC_HARQ_ALIGN_64B          64
  #define ACC_MAX_ZC                  384
 
+/* De-ratematch code rate limitation for recommended operation */
+#define ACC_LIM_03 2  /* 0.03 */ #define ACC_LIM_09 6  /* 0.09 */
+#define ACC_LIM_14 9  /* 0.14 */ #define ACC_LIM_21 14 /* 0.21 */
+#define ACC_LIM_31 20 /* 0.31 */ #define ACC_MAX_E (128 * 1024 - 2)
+
  /* Helper macro for logging */
  #define rte_acc_log(level, fmt, ...) \
  	rte_log(RTE_LOG_ ## level, RTE_LOG_NOTICE, fmt "\n", \ diff --git

a/drivers/baseband/acc/rte_acc100_pmd.c
b/drivers/baseband/acc/rte_acc100_pmd.c
index 23bc5d25bb..47609f95b7 100644

drivers/baseband/acc/rte_acc100_pmd.c +0 -0
@@ -756,6 +756,14 @@ acc100_queue_setup(struct rte_bbdev *dev,

uint16_t queue_id,

Quoted 14 lines
drivers/baseband/acc/rte_acc100_pmd.c +8 -0
  		ret = -ENOMEM;
  		goto free_lb_out;
  	}
+	q->derm_buffer = rte_zmalloc_socket(dev->device->driver->name,
+			RTE_BBDEV_TURBO_MAX_CB_SIZE * 10,
+			RTE_CACHE_LINE_SIZE, conf->socket);
+	if (q->derm_buffer == NULL) {
+		rte_bbdev_log(ERR, "Failed to allocate derm_buffer memory");
+		ret = -ENOMEM;
+		goto free_companion_ring_addr;
+	}
 
  	/*
  	 * Software queue ring wraps synchronously with the HW when it
Quoted 1 line

reaches @@ -776,7 +784,7 @@ acc100_queue_setup(struct rte_bbdev *dev,

uint16_t queue_id,

drivers/baseband/acc/rte_acc100_pmd.c acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,

Quoted 8 lines
  	q_idx = acc100_find_free_queue_idx(dev, conf);
  	if (q_idx == -1) {
  		ret = -EINVAL;
drivers/baseband/acc/rte_acc100_pmd.c +1 -1
-		goto free_companion_ring_addr;
+		goto free_derm_buffer;
  	}
 
  	q->qgrp_id = (q_idx >> ACC100_GRP_ID_SHIFT) & 0xF; @@ -804,6

+812,9

drivers/baseband/acc/rte_acc100_pmd.c acc100_queue_release(struct rte_bbdev *dev,

Quoted 11 lines

@@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,
dev->data->queues[queue_id].queue_private = q; return 0;

drivers/baseband/acc/rte_acc100_pmd.c +3 -0
+free_derm_buffer:
+	rte_free(q->derm_buffer);
+	q->derm_buffer = NULL;
  free_companion_ring_addr:
  	rte_free(q->companion_ring_addr);
  	q->companion_ring_addr = NULL;
@@ -890,6 +901,7 @@ acc100_queue_release(struct rte_bbdev *dev,

uint16_t q_id)

drivers/baseband/acc/rte_acc100_pmd.c harq_loopback(struct acc_queue *q, struct

Quoted 8 lines
drivers/baseband/acc/rte_acc100_pmd.c +1 -0
  		/* Mark the Queue as un-assigned */
  		d->q_assigned_bit_map[q->qgrp_id] &= (0xFFFFFFFFFFFFFFFF -
  				(uint64_t) (1 << q->aq_id));
+		rte_free(q->derm_buffer);
  		rte_free(q->companion_ring_addr);
  		rte_free(q->lb_in);
  		rte_free(q->lb_out);
@@ -3111,10 +3123,41 @@ harq_loopback(struct acc_queue *q, struct

rte_bbdev_dec_op *op,

Quoted 25 lines
drivers/baseband/acc/rte_acc100_pmd.c +22 -0
  	return 1;
  }
 
+/* Assess whether a work around is recommended for the deRM corner
+cases */ static inline bool derm_workaround_recommended(struct
+rte_bbdev_op_ldpc_dec *ldpc_dec, struct acc_queue *q) {
+	if (!is_acc100(q))
+		return false;
+	int32_t e = ldpc_dec->cb_params.e;
+	int q_m = ldpc_dec->q_m;
+	int z_c = ldpc_dec->z_c;
+	int K = (ldpc_dec->basegraph == 1 ? ACC_K_ZC_1 : ACC_K_ZC_2) * z_c;
+	bool recommended = false;
+
+	if (ldpc_dec->basegraph == 1) {
+		if ((q_m == 4) && (z_c >= 320) && (e * ACC_LIM_31 > K * 64))
+			recommended = true;
+		else if ((e * ACC_LIM_21 > K * 64))
+			recommended = true;
+	} else {
+		if (q_m <= 2) {
+			if ((z_c >= 208) && (e * ACC_LIM_09 > K * 64))
+				recommended = true;
+			else if ((z_c < 208) && (e * ACC_LIM_03 > K * 64))
+				recommended = true;

drivers/baseband/acc/rte_acc100_pmd.c harq_loopback(struct acc_queue *q, struct rte_bbdev_dec_op *op,

Quoted 10 lines
drivers/baseband/acc/rte_acc100_pmd.c +7 -0
+		} else if (e * ACC_LIM_14 > K * 64)
+			recommended = true;
+	}
+
+	return recommended;
+}
+
  /** Enqueue one decode operations for ACC100 device in CB mode */
  static inline int
  enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct

rte_bbdev_dec_op *op,

drivers/baseband/acc/rte_acc100_pmd.c enqueue_ldpc_dec_one_op_cb(struct acc_queue

Quoted 7 lines
drivers/baseband/acc/rte_acc100_pmd.c +2 -1
-		uint16_t total_enqueued_cbs, bool same_op)
+		uint16_t total_enqueued_cbs, bool same_op,
+		struct rte_bbdev_queue_data *q_data)
  {
  	int ret;
  	if (unlikely(check_bit(op->ldpc_dec.op_flags,
@@ -3168,6 +3211,12 @@ enqueue_ldpc_dec_one_op_cb(struct acc_queue

*q, struct rte_bbdev_dec_op *op,

Quoted 7 lines

drivers/baseband/acc/rte_acc100_pmd.c enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op, · line 3216

Quoted 6 lines
drivers/baseband/acc/rte_acc100_pmd.c +3 -0
  	} else {
  		struct acc_fcw_ld *fcw;
  		uint32_t seg_total_left;
+
+		if (derm_workaround_recommended(&op->ldpc_dec, q)) {
+			RTE_SET_USED(q_data);

Why do we need q_data if it is not being used?

As you can guess this notably allows customer do consider running deRM from here as a local patch hence keeping the q_data accessible. Basically we keep the prototype of the function enqueue_ldpc_dec_one_op_cb() compatible with such usage.
I believe this is a good practice here. Let us know if you are not convinced.
Thanks
Nic

Quoted 20 lines

drivers/baseband/acc/rte_acc100_pmd.c enqueue_ldpc_dec_one_op_cb(struct acc_queue · line 3217

Quoted 2 lines
drivers/baseband/acc/rte_acc100_pmd.c +1 -0
+			rte_bbdev_log(INFO, "Corner case may require deRM

pre-processing");

drivers/baseband/acc/rte_acc100_pmd.c acc100_enqueue_ldpc_dec_cb(struct

Quoted 6 lines
drivers/baseband/acc/rte_acc100_pmd.c +2 -0
+		}
+
  		fcw = &desc->req.fcw_ld;
  		q->d->fcw_ld_fill(op, fcw, harq_layout);
 
@@ -3721,7 +3770,7 @@ acc100_enqueue_ldpc_dec_cb(struct

rte_bbdev_queue_data *q_data,

drivers/baseband/acc/rte_acc100_pmd.c acc100_enqueue_ldpc_dec_cb(struct rte_bbdev_queue_data *q_data,

Quoted 6 lines
drivers/baseband/acc/rte_acc100_pmd.c +1 -1
  			ops[i]->ldpc_dec.n_cb, ops[i]->ldpc_dec.q_m,
  			ops[i]->ldpc_dec.n_filler, ops[i]-
 ldpc_dec.cb_params.e,
  			same_op);
-		ret = enqueue_ldpc_dec_one_op_cb(q, ops[i], i, same_op);
+		ret = enqueue_ldpc_dec_one_op_cb(q, ops[i], i, same_op,

q_data);

Quoted 3 lines
drivers/baseband/acc/rte_acc100_pmd.c +0 -0
  		if (ret < 0) {
  			acc_enqueue_invalid(q_data);

break;

#5 lore raw

Re: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

Hi Nicolas,

Quoted 151 lines · Nicolas

Hi Maxime,

Quoted 141 lines

-----Original Message-----
From: Maxime Coquelin <[email protected]>
Sent: Thursday, November 3, 2022 7:10 AM
To: Vargas, Hernan <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: Chautru, Nicolas <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: Re: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

Quoted 11 lines · Hernan Vargas

Add function to detect if de-ratematch pre-processing is recommended for SW corner cases.
Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to the user.

---
   drivers/baseband/acc/acc_common.h     |  8 ++++
   drivers/baseband/acc/rte_acc100_pmd.c | 55

+++++++++++++++++++++++++--

drivers/baseband/acc/rte_acc100_pmd.c acc100_queue_setup(struct rte_bbdev *dev,

Quoted 25 lines
   2 files changed, 60 insertions(+), 3 deletions(-)
drivers/baseband/acc/acc_common.h +5 -0
index eae7eab4e9..6213b0b61e 100644
@@ -123,6 +123,14 @@
   #define ACC_HARQ_ALIGN_64B          64
   #define ACC_MAX_ZC                  384
 
+/* De-ratematch code rate limitation for recommended operation */
+#define ACC_LIM_03 2  /* 0.03 */ #define ACC_LIM_09 6  /* 0.09 */
+#define ACC_LIM_14 9  /* 0.14 */ #define ACC_LIM_21 14 /* 0.21 */
+#define ACC_LIM_31 20 /* 0.31 */ #define ACC_MAX_E (128 * 1024 - 2)
+
   /* Helper macro for logging */
   #define rte_acc_log(level, fmt, ...) \
   	rte_log(RTE_LOG_ ## level, RTE_LOG_NOTICE, fmt "\n", \ diff --git

a/drivers/baseband/acc/rte_acc100_pmd.c
b/drivers/baseband/acc/rte_acc100_pmd.c
index 23bc5d25bb..47609f95b7 100644

drivers/baseband/acc/rte_acc100_pmd.c +0 -0
@@ -756,6 +756,14 @@ acc100_queue_setup(struct rte_bbdev *dev,

uint16_t queue_id,

Quoted 14 lines
drivers/baseband/acc/rte_acc100_pmd.c +8 -0
   		ret = -ENOMEM;
   		goto free_lb_out;
   	}
+	q->derm_buffer = rte_zmalloc_socket(dev->device->driver->name,
+			RTE_BBDEV_TURBO_MAX_CB_SIZE * 10,
+			RTE_CACHE_LINE_SIZE, conf->socket);
+	if (q->derm_buffer == NULL) {
+		rte_bbdev_log(ERR, "Failed to allocate derm_buffer memory");
+		ret = -ENOMEM;
+		goto free_companion_ring_addr;
+	}
 
   	/*
   	 * Software queue ring wraps synchronously with the HW when it
Quoted 1 line

reaches @@ -776,7 +784,7 @@ acc100_queue_setup(struct rte_bbdev *dev,

uint16_t queue_id,

drivers/baseband/acc/rte_acc100_pmd.c acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,

Quoted 8 lines
   	q_idx = acc100_find_free_queue_idx(dev, conf);
   	if (q_idx == -1) {
   		ret = -EINVAL;
drivers/baseband/acc/rte_acc100_pmd.c +1 -1
-		goto free_companion_ring_addr;
+		goto free_derm_buffer;
   	}
 
   	q->qgrp_id = (q_idx >> ACC100_GRP_ID_SHIFT) & 0xF; @@ -804,6

+812,9

drivers/baseband/acc/rte_acc100_pmd.c acc100_queue_release(struct rte_bbdev *dev,

Quoted 11 lines

@@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,

   	dev->data->queues[queue_id].queue_private = q;
   	return 0;
drivers/baseband/acc/rte_acc100_pmd.c +3 -0
+free_derm_buffer:
+	rte_free(q->derm_buffer);
+	q->derm_buffer = NULL;
   free_companion_ring_addr:
   	rte_free(q->companion_ring_addr);
   	q->companion_ring_addr = NULL;
@@ -890,6 +901,7 @@ acc100_queue_release(struct rte_bbdev *dev,

uint16_t q_id)

drivers/baseband/acc/rte_acc100_pmd.c harq_loopback(struct acc_queue *q, struct

Quoted 8 lines
drivers/baseband/acc/rte_acc100_pmd.c +1 -0
   		/* Mark the Queue as un-assigned */
   		d->q_assigned_bit_map[q->qgrp_id] &= (0xFFFFFFFFFFFFFFFF -
   				(uint64_t) (1 << q->aq_id));
+		rte_free(q->derm_buffer);
   		rte_free(q->companion_ring_addr);
   		rte_free(q->lb_in);
   		rte_free(q->lb_out);
@@ -3111,10 +3123,41 @@ harq_loopback(struct acc_queue *q, struct

rte_bbdev_dec_op *op,

Quoted 25 lines
drivers/baseband/acc/rte_acc100_pmd.c +22 -0
   	return 1;
   }
 
+/* Assess whether a work around is recommended for the deRM corner
+cases */ static inline bool derm_workaround_recommended(struct
+rte_bbdev_op_ldpc_dec *ldpc_dec, struct acc_queue *q) {
+	if (!is_acc100(q))
+		return false;
+	int32_t e = ldpc_dec->cb_params.e;
+	int q_m = ldpc_dec->q_m;
+	int z_c = ldpc_dec->z_c;
+	int K = (ldpc_dec->basegraph == 1 ? ACC_K_ZC_1 : ACC_K_ZC_2) * z_c;
+	bool recommended = false;
+
+	if (ldpc_dec->basegraph == 1) {
+		if ((q_m == 4) && (z_c >= 320) && (e * ACC_LIM_31 > K * 64))
+			recommended = true;
+		else if ((e * ACC_LIM_21 > K * 64))
+			recommended = true;
+	} else {
+		if (q_m <= 2) {
+			if ((z_c >= 208) && (e * ACC_LIM_09 > K * 64))
+				recommended = true;
+			else if ((z_c < 208) && (e * ACC_LIM_03 > K * 64))
+				recommended = true;

drivers/baseband/acc/rte_acc100_pmd.c harq_loopback(struct acc_queue *q, struct rte_bbdev_dec_op *op,

Quoted 10 lines
drivers/baseband/acc/rte_acc100_pmd.c +7 -0
+		} else if (e * ACC_LIM_14 > K * 64)
+			recommended = true;
+	}
+
+	return recommended;
+}
+
   /** Enqueue one decode operations for ACC100 device in CB mode */
   static inline int
   enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct

rte_bbdev_dec_op *op,

drivers/baseband/acc/rte_acc100_pmd.c enqueue_ldpc_dec_one_op_cb(struct acc_queue

Quoted 7 lines
drivers/baseband/acc/rte_acc100_pmd.c +2 -1
-		uint16_t total_enqueued_cbs, bool same_op)
+		uint16_t total_enqueued_cbs, bool same_op,
+		struct rte_bbdev_queue_data *q_data)
   {
   	int ret;
   	if (unlikely(check_bit(op->ldpc_dec.op_flags,
@@ -3168,6 +3211,12 @@ enqueue_ldpc_dec_one_op_cb(struct acc_queue

*q, struct rte_bbdev_dec_op *op,

Quoted 7 lines

drivers/baseband/acc/rte_acc100_pmd.c enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op, · line 3216

Quoted 6 lines
drivers/baseband/acc/rte_acc100_pmd.c +3 -0
   	} else {
   		struct acc_fcw_ld *fcw;
   		uint32_t seg_total_left;
+
+		if (derm_workaround_recommended(&op->ldpc_dec, q)) {
+			RTE_SET_USED(q_data);

Why do we need q_data if it is not being used?

Quoted 3 lines

As you can guess this notably allows customer do consider running deRM from here as a local patch hence keeping the q_data accessible. Basically we keep the prototype of the function enqueue_ldpc_dec_one_op_cb() compatible with such usage.
I believe this is a good practice here. Let us know if you are not convinced.

I think it is better to just warn the user, without adding unused parameters.

Thanks,
Maxime

Quoted 24 lines

Thanks
Nic

Quoted 20 lines

drivers/baseband/acc/rte_acc100_pmd.c enqueue_ldpc_dec_one_op_cb(struct acc_queue · line 3217

Quoted 2 lines
drivers/baseband/acc/rte_acc100_pmd.c +1 -0
+			rte_bbdev_log(INFO, "Corner case may require deRM

pre-processing");

drivers/baseband/acc/rte_acc100_pmd.c acc100_enqueue_ldpc_dec_cb(struct

Quoted 6 lines
drivers/baseband/acc/rte_acc100_pmd.c +2 -0
+		}
+
   		fcw = &desc->req.fcw_ld;
   		q->d->fcw_ld_fill(op, fcw, harq_layout);
 
@@ -3721,7 +3770,7 @@ acc100_enqueue_ldpc_dec_cb(struct

rte_bbdev_queue_data *q_data,

drivers/baseband/acc/rte_acc100_pmd.c acc100_enqueue_ldpc_dec_cb(struct rte_bbdev_queue_data *q_data,

Quoted 6 lines
drivers/baseband/acc/rte_acc100_pmd.c +1 -1
   			ops[i]->ldpc_dec.n_cb, ops[i]->ldpc_dec.q_m,
   			ops[i]->ldpc_dec.n_filler, ops[i]-
 ldpc_dec.cb_params.e,
   			same_op);
-		ret = enqueue_ldpc_dec_one_op_cb(q, ops[i], i, same_op);
+		ret = enqueue_ldpc_dec_one_op_cb(q, ops[i], i, same_op,

q_data);

Quoted 3 lines
drivers/baseband/acc/rte_acc100_pmd.c +0 -0
   		if (ret < 0) {
   			acc_enqueue_invalid(q_data);
   			break;
#6 lore raw

RE: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

Hi Maxime, Akhil,

Quoted 166 lines

-----Original Message-----
From: Maxime Coquelin <[email protected]>
Sent: Thursday, November 3, 2022 8:08 AM
To: Chautru, Nicolas <[email protected]>; Vargas, Hernan <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: Zhang, Qi Z <[email protected]>
Subject: Re: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

Hi Nicolas,

Quoted 136 lines · Nicolas

Hi Maxime,

Quoted 134 lines

-----Original Message-----
From: Maxime Coquelin <[email protected]>
Sent: Thursday, November 3, 2022 7:10 AM
To: Vargas, Hernan <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: Chautru, Nicolas <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: Re: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

Quoted 11 lines · Hernan Vargas

Add function to detect if de-ratematch pre-processing is recommended for SW corner cases.
Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to the user.

---
   drivers/baseband/acc/acc_common.h     |  8 ++++
   drivers/baseband/acc/rte_acc100_pmd.c | 55

+++++++++++++++++++++++++--

drivers/baseband/acc/rte_acc100_pmd.c acc100_queue_setup(struct rte_bbdev *dev,

Quoted 25 lines
   2 files changed, 60 insertions(+), 3 deletions(-)
drivers/baseband/acc/acc_common.h +5 -1
index eae7eab4e9..6213b0b61e 100644
@@ -123,6 +123,14 @@
   #define ACC_HARQ_ALIGN_64B          64
   #define ACC_MAX_ZC                  384
 
+/* De-ratematch code rate limitation for recommended operation */
+#define ACC_LIM_03 2  /* 0.03 */ #define ACC_LIM_09 6  /* 0.09 */
+#define ACC_LIM_14 9  /* 0.14 */ #define ACC_LIM_21 14 /* 0.21 */
+#define ACC_LIM_31 20 /* 0.31 */ #define ACC_MAX_E (128 * 1024 - 2)
+
   /* Helper macro for logging */
   #define rte_acc_log(level, fmt, ...) \
   	rte_log(RTE_LOG_ ## level, RTE_LOG_NOTICE, fmt "\n", \ diff
--git a/drivers/baseband/acc/rte_acc100_pmd.c

b/drivers/baseband/acc/rte_acc100_pmd.c
index 23bc5d25bb..47609f95b7 100644

drivers/baseband/acc/rte_acc100_pmd.c +0 -0
@@ -756,6 +756,14 @@ acc100_queue_setup(struct rte_bbdev *dev,

uint16_t queue_id,

Quoted 14 lines
drivers/baseband/acc/rte_acc100_pmd.c +8 -0
   		ret = -ENOMEM;
   		goto free_lb_out;
   	}
+	q->derm_buffer = rte_zmalloc_socket(dev->device->driver->name,
+			RTE_BBDEV_TURBO_MAX_CB_SIZE * 10,
+			RTE_CACHE_LINE_SIZE, conf->socket);
+	if (q->derm_buffer == NULL) {
+		rte_bbdev_log(ERR, "Failed to allocate derm_buffer memory");
+		ret = -ENOMEM;
+		goto free_companion_ring_addr;
+	}
 
   	/*
   	 * Software queue ring wraps synchronously with the HW when it
Quoted 2 lines

reaches @@ -776,7 +784,7 @@ acc100_queue_setup(struct rte_bbdev *dev,

uint16_t queue_id,

drivers/baseband/acc/rte_acc100_pmd.c acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,

Quoted 8 lines
   	q_idx = acc100_find_free_queue_idx(dev, conf);
   	if (q_idx == -1) {
   		ret = -EINVAL;
drivers/baseband/acc/rte_acc100_pmd.c +1 -1
-		goto free_companion_ring_addr;
+		goto free_derm_buffer;
   	}
 
   	q->qgrp_id = (q_idx >> ACC100_GRP_ID_SHIFT) & 0xF; @@ -804,6

+812,9

drivers/baseband/acc/rte_acc100_pmd.c acc100_queue_release(struct rte_bbdev *dev,

Quoted 11 lines

@@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,

   	dev->data->queues[queue_id].queue_private = q;
   	return 0;
drivers/baseband/acc/rte_acc100_pmd.c +3 -0
+free_derm_buffer:
+	rte_free(q->derm_buffer);
+	q->derm_buffer = NULL;
   free_companion_ring_addr:
   	rte_free(q->companion_ring_addr);
   	q->companion_ring_addr = NULL;
@@ -890,6 +901,7 @@ acc100_queue_release(struct rte_bbdev *dev,

uint16_t q_id)

drivers/baseband/acc/rte_acc100_pmd.c harq_loopback(struct acc_queue *q, struct

Quoted 8 lines
drivers/baseband/acc/rte_acc100_pmd.c +1 -0
   		/* Mark the Queue as un-assigned */
   		d->q_assigned_bit_map[q->qgrp_id] &= (0xFFFFFFFFFFFFFFFF -
   				(uint64_t) (1 << q->aq_id));
+		rte_free(q->derm_buffer);
   		rte_free(q->companion_ring_addr);
   		rte_free(q->lb_in);
   		rte_free(q->lb_out);
@@ -3111,10 +3123,41 @@ harq_loopback(struct acc_queue *q, struct

rte_bbdev_dec_op *op,

Quoted 25 lines
drivers/baseband/acc/rte_acc100_pmd.c +22 -0
   	return 1;
   }
 
+/* Assess whether a work around is recommended for the deRM corner
+cases */ static inline bool derm_workaround_recommended(struct
+rte_bbdev_op_ldpc_dec *ldpc_dec, struct acc_queue *q) {
+	if (!is_acc100(q))
+		return false;
+	int32_t e = ldpc_dec->cb_params.e;
+	int q_m = ldpc_dec->q_m;
+	int z_c = ldpc_dec->z_c;
+	int K = (ldpc_dec->basegraph == 1 ? ACC_K_ZC_1 : ACC_K_ZC_2) * z_c;
+	bool recommended = false;
+
+	if (ldpc_dec->basegraph == 1) {
+		if ((q_m == 4) && (z_c >= 320) && (e * ACC_LIM_31 > K * 64))
+			recommended = true;
+		else if ((e * ACC_LIM_21 > K * 64))
+			recommended = true;
+	} else {
+		if (q_m <= 2) {
+			if ((z_c >= 208) && (e * ACC_LIM_09 > K * 64))
+				recommended = true;
+			else if ((z_c < 208) && (e * ACC_LIM_03 > K * 64))
+				recommended = true;

drivers/baseband/acc/rte_acc100_pmd.c harq_loopback(struct acc_queue *q, struct rte_bbdev_dec_op *op,

Quoted 10 lines
drivers/baseband/acc/rte_acc100_pmd.c +7 -0
+		} else if (e * ACC_LIM_14 > K * 64)
+			recommended = true;
+	}
+
+	return recommended;
+}
+
   /** Enqueue one decode operations for ACC100 device in CB mode */
   static inline int
   enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct

rte_bbdev_dec_op *op,

Quoted 7 lines
Quoted 7 lines

drivers/baseband/acc/rte_acc100_pmd.c enqueue_ldpc_dec_one_op_cb(struct

Quoted 7 lines
drivers/baseband/acc/rte_acc100_pmd.c +2 -1
-		uint16_t total_enqueued_cbs, bool same_op)
+		uint16_t total_enqueued_cbs, bool same_op,
+		struct rte_bbdev_queue_data *q_data)
   {
   	int ret;
   	if (unlikely(check_bit(op->ldpc_dec.op_flags,
@@ -3168,6 +3211,12 @@ enqueue_ldpc_dec_one_op_cb(struct

acc_queue

Quoted 9 lines
Quoted 8 lines

*q, struct rte_bbdev_dec_op *op,

drivers/baseband/acc/rte_acc100_pmd.c enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op, · line 3216

Quoted 6 lines
drivers/baseband/acc/rte_acc100_pmd.c +3 -0
   	} else {
   		struct acc_fcw_ld *fcw;
   		uint32_t seg_total_left;
+
+		if (derm_workaround_recommended(&op->ldpc_dec, q)) {
+			RTE_SET_USED(q_data);

Why do we need q_data if it is not being used?

Quoted 7 lines
Quoted 1 line

As you can guess this notably allows customer do consider running deRM

from here as a local patch hence keeping the q_data accessible.

Quoted 1 line

Basically we keep the prototype of the function

enqueue_ldpc_dec_one_op_cb() compatible with such usage.

Quoted 1 line

I believe this is a good practice here. Let us know if you are not convinced.

I think it is better to just warn the user, without adding unused parameters.

Thanks Maxime.
Akhil, any additional view on this? For the PMD usage and support this makes more sense to keep to prototype with q_data even with RTE_SET_USED(). I don't see any meaningful drawback justifying to push back. Still let us know.

Thanks
Nic

#7 lore raw

RE: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

Given how close we are to 22.11, let's not argue over this. Hernan sending a new patch based on Maxime recommendation.

Quoted 199 lines

-----Original Message-----
From: Chautru, Nicolas
Sent: Thursday, November 3, 2022 9:21 AM
To: Maxime Coquelin <[email protected]>; Vargas, Hernan <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: Zhang, Qi Z <[email protected]>
Subject: RE: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

Hi Maxime, Akhil,

Quoted 67 lines

-----Original Message-----
From: Maxime Coquelin <[email protected]>
Sent: Thursday, November 3, 2022 8:08 AM
To: Chautru, Nicolas <[email protected]>; Vargas, Hernan <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: Zhang, Qi Z <[email protected]>
Subject: Re: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

Hi Nicolas,

Quoted 54 lines · Nicolas

Hi Maxime,

Quoted 52 lines

-----Original Message-----
From: Maxime Coquelin <[email protected]>
Sent: Thursday, November 3, 2022 7:10 AM
To: Vargas, Hernan <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: Chautru, Nicolas <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: Re: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

Quoted 11 lines · Hernan Vargas

Add function to detect if de-ratematch pre-processing is recommended for SW corner cases.
Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to the user.

---
   drivers/baseband/acc/acc_common.h     |  8 ++++
   drivers/baseband/acc/rte_acc100_pmd.c | 55

+++++++++++++++++++++++++--

drivers/baseband/acc/rte_acc100_pmd.c acc100_queue_setup(struct rte_bbdev *dev,

Quoted 26 lines
   2 files changed, 60 insertions(+), 3 deletions(-)
drivers/baseband/acc/acc_common.h +6 -1
index eae7eab4e9..6213b0b61e 100644
@@ -123,6 +123,14 @@
   #define ACC_HARQ_ALIGN_64B          64
   #define ACC_MAX_ZC                  384
 
+/* De-ratematch code rate limitation for recommended operation */
+#define ACC_LIM_03 2  /* 0.03 */ #define ACC_LIM_09 6  /* 0.09 */
+#define ACC_LIM_14 9  /* 0.14 */ #define ACC_LIM_21 14 /* 0.21 */
+#define ACC_LIM_31 20 /* 0.31 */ #define ACC_MAX_E (128 * 1024 -
+2)
+
   /* Helper macro for logging */
   #define rte_acc_log(level, fmt, ...) \
   	rte_log(RTE_LOG_ ## level, RTE_LOG_NOTICE, fmt "\n", \ diff
--git a/drivers/baseband/acc/rte_acc100_pmd.c

b/drivers/baseband/acc/rte_acc100_pmd.c
index 23bc5d25bb..47609f95b7 100644

drivers/baseband/acc/rte_acc100_pmd.c +0 -0
@@ -756,6 +756,14 @@ acc100_queue_setup(struct rte_bbdev *dev,

uint16_t queue_id,

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

drivers/baseband/acc/rte_acc100_pmd.c acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,

Quoted 8 lines
drivers/baseband/acc/rte_acc100_pmd.c +5 -0
   		ret = -ENOMEM;
   		goto free_lb_out;
   	}
+	q->derm_buffer = rte_zmalloc_socket(dev->device->driver->name,
+			RTE_BBDEV_TURBO_MAX_CB_SIZE * 10,
+			RTE_CACHE_LINE_SIZE, conf->socket);
+	if (q->derm_buffer == NULL) {
+		rte_bbdev_log(ERR, "Failed to allocate derm_buffer

memory");

Quoted 93 lines
Quoted 76 lines
Quoted 76 lines
Quoted 8 lines
drivers/baseband/acc/rte_acc100_pmd.c +3 -0
+		ret = -ENOMEM;
+		goto free_companion_ring_addr;
+	}
 
   	/*
   	 * Software queue ring wraps synchronously with the HW when it

reaches @@ -776,7 +784,7 @@ acc100_queue_setup(struct rte_bbdev *dev,

uint16_t queue_id,

drivers/baseband/acc/rte_acc100_pmd.c acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,

Quoted 8 lines
   	q_idx = acc100_find_free_queue_idx(dev, conf);
   	if (q_idx == -1) {
   		ret = -EINVAL;
drivers/baseband/acc/rte_acc100_pmd.c +1 -1
-		goto free_companion_ring_addr;
+		goto free_derm_buffer;
   	}
 
   	q->qgrp_id = (q_idx >> ACC100_GRP_ID_SHIFT) & 0xF; @@ -804,6

+812,9

Quoted 11 lines

@@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,

   	dev->data->queues[queue_id].queue_private = q;
   	return 0;
drivers/baseband/acc/rte_acc100_pmd.c +3 -0
+free_derm_buffer:
+	rte_free(q->derm_buffer);
+	q->derm_buffer = NULL;
   free_companion_ring_addr:
   	rte_free(q->companion_ring_addr);
   	q->companion_ring_addr = NULL; @@ -890,6 +901,7 @@

acc100_queue_release(struct rte_bbdev *dev,

uint16_t q_id)

drivers/baseband/acc/rte_acc100_pmd.c harq_loopback(struct acc_queue *q, struct

Quoted 8 lines
   		/* Mark the Queue as un-assigned */
   		d->q_assigned_bit_map[q->qgrp_id] &= (0xFFFFFFFFFFFFFFFF -
   				(uint64_t) (1 << q->aq_id));
drivers/baseband/acc/rte_acc100_pmd.c +1 -0
+		rte_free(q->derm_buffer);
   		rte_free(q->companion_ring_addr);
   		rte_free(q->lb_in);
   		rte_free(q->lb_out);
@@ -3111,10 +3123,41 @@ harq_loopback(struct acc_queue *q, struct

rte_bbdev_dec_op *op,

Quoted 26 lines
drivers/baseband/acc/rte_acc100_pmd.c +23 -0
   	return 1;
   }
 
+/* Assess whether a work around is recommended for the deRM
+corner cases */ static inline bool
+derm_workaround_recommended(struct
+rte_bbdev_op_ldpc_dec *ldpc_dec, struct acc_queue *q) {
+	if (!is_acc100(q))
+		return false;
+	int32_t e = ldpc_dec->cb_params.e;
+	int q_m = ldpc_dec->q_m;
+	int z_c = ldpc_dec->z_c;
+	int K = (ldpc_dec->basegraph == 1 ? ACC_K_ZC_1 : ACC_K_ZC_2) * z_c;
+	bool recommended = false;
+
+	if (ldpc_dec->basegraph == 1) {
+		if ((q_m == 4) && (z_c >= 320) && (e * ACC_LIM_31 > K * 64))
+			recommended = true;
+		else if ((e * ACC_LIM_21 > K * 64))
+			recommended = true;
+	} else {
+		if (q_m <= 2) {
+			if ((z_c >= 208) && (e * ACC_LIM_09 > K * 64))
+				recommended = true;
+			else if ((z_c < 208) && (e * ACC_LIM_03 > K * 64))
+				recommended = true;

drivers/baseband/acc/rte_acc100_pmd.c harq_loopback(struct acc_queue *q, struct rte_bbdev_dec_op *op,

Quoted 10 lines
drivers/baseband/acc/rte_acc100_pmd.c +7 -0
+		} else if (e * ACC_LIM_14 > K * 64)
+			recommended = true;
+	}
+
+	return recommended;
+}
+
   /** Enqueue one decode operations for ACC100 device in CB mode */
   static inline int
   enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct

rte_bbdev_dec_op *op,

Quoted 7 lines
Quoted 7 lines

drivers/baseband/acc/rte_acc100_pmd.c enqueue_ldpc_dec_one_op_cb(struct

Quoted 7 lines
drivers/baseband/acc/rte_acc100_pmd.c +2 -1
-		uint16_t total_enqueued_cbs, bool same_op)
+		uint16_t total_enqueued_cbs, bool same_op,
+		struct rte_bbdev_queue_data *q_data)
   {
   	int ret;
   	if (unlikely(check_bit(op->ldpc_dec.op_flags,
@@ -3168,6 +3211,12 @@ enqueue_ldpc_dec_one_op_cb(struct

acc_queue

Quoted 9 lines
Quoted 8 lines

*q, struct rte_bbdev_dec_op *op,

drivers/baseband/acc/rte_acc100_pmd.c enqueue_ldpc_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op, · line 3216

Quoted 6 lines
drivers/baseband/acc/rte_acc100_pmd.c +3 -0
   	} else {
   		struct acc_fcw_ld *fcw;
   		uint32_t seg_total_left;
+
+		if (derm_workaround_recommended(&op->ldpc_dec, q)) {
+			RTE_SET_USED(q_data);

Why do we need q_data if it is not being used?

Quoted 8 lines
Quoted 2 lines

As you can guess this notably allows customer do consider running deRM

from here as a local patch hence keeping the q_data accessible.

Quoted 1 line

Basically we keep the prototype of the function

enqueue_ldpc_dec_one_op_cb() compatible with such usage.

Quoted 1 line

I believe this is a good practice here. Let us know if you are not convinced.

I think it is better to just warn the user, without adding unused parameters.

Thanks Maxime.
Akhil, any additional view on this? For the PMD usage and support this makes more sense to keep to prototype with q_data even with RTE_SET_USED(). I don't see any meaningful drawback justifying to push back. Still let us know.

Thanks
Nic