usb: cdnsp: Fix wrong transmission direction of EP0
Subsystems (2)
PATCH 1/1 usb: cdnsp: Fix wrong transmission direction of EP0
From: Jing Leng <[email protected]>
EP0 transfer is bi-directional, but in the cdnsp gadget, the transmission direction of EP0 is not changed after it is initialized to IN, so the OUT data from EP0 received by the host is invalid.
The value of ep0_expect_in will change according to the value of bRequestType in the SETUP transaction of control transfer, so we can use it as the transmission direction of EP0.
--- drivers/usb/cdns3/cdnsp-gadget.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/usb/cdns3/cdnsp-gadget.c +7 -4
@@ -345,6 +345,7 @@ int cdnsp_ep_enqueue(struct cdnsp_ep *pep, struct cdnsp_request *preq) {struct cdnsp_device *pdev = pep->pdev;struct usb_request *request; +u8 direction;int ret;if (preq->epnum ==0 && !list_empty (&pep->pending_list)) {
@@ -355,11 +356,14 @@ int cdnsp_ep_enqueue(struct cdnsp_ep *pep, struct cdnsp_request *preq) request = &preq->request; request->actual =0 ; request->status = -EINPROGRESS ; - preq->direction = pep->direction; + + direction =usb_endpoint_xfer_control (pep->endpoint.desc) ? + pdev->ep0_expect_in : pep->direction; + preq->direction = direction; preq->epnum = pep->number; preq->td.drbl =0 ; - ret =usb_gadget_map_request_by_dev (pdev->dev, request, pep->direction); + ret =usb_gadget_map_request_by_dev (pdev->dev, request, direction);if (ret) {trace_cdnsp_request_enqueue_error (preq);return ret;
@@ -387,8 +391,7 @@ int cdnsp_ep_enqueue(struct cdnsp_ep *pep, struct cdnsp_request *preq)return 0 ; unmap: -usb_gadget_unmap_request_by_dev (pdev->dev, &preq->request, - pep->direction); +usb_gadget_unmap_request_by_dev (pdev->dev, &preq->request, direction);list_del (&preq->list);trace_cdnsp_request_enqueue_error (preq);
Signature · 1 line
2.34.1
Greg KH
maintainerQuoted 7 lines · On Mon, Sep 26, 2022 at 03:59:02PM +0800, [email protected] wrote:
From: Jing Leng <[email protected]>
EP0 transfer is bi-directional, but in the cdnsp gadget, the transmission direction of EP0 is not changed after it is initialized to IN, so the OUT data from EP0 received by the host is invalid.
Quoted 5 lines
The value of
ep0_expect_inwill change according to the value of bRequestType in the SETUP transaction of control transfer, so we can use it as the transmission direction of EP0.Signed-off-by Jing Leng <[email protected]>
Your email does not match your From: line and the signature of it shows that it is invalid and does not pass authentication :(
Please work with your university to get an email address that works properly.
thanks,
greg k-h
PATCH v2 1/1 usb: cdnsp: Fix wrong transmission direction of EP0
In reply to [email protected]EP0 transfer is bi-directional, but in the cdnsp gadget, the transmission direction of EP0 is not changed after it is initialized to IN, so the OUT data from EP0 received by the host is invalid.
The value of ep0_expect_in will change according to the value of bRequestType in the SETUP transaction of control transfer, so we can use it as the transmission direction of EP0.
---
ChangeLog v1->v2:
- Rebase the patch.
- Make email addresses ('From' and 'Signed-off-by') consistent.
--- drivers/usb/cdns3/cdnsp-gadget.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/usb/cdns3/cdnsp-gadget.c +7 -4
@@ -345,6 +345,7 @@ int cdnsp_ep_enqueue(struct cdnsp_ep *pep, struct cdnsp_request *preq) {struct cdnsp_device *pdev = pep->pdev;struct usb_request *request; +u8 direction;int ret;if (preq->epnum ==0 && !list_empty (&pep->pending_list)) {
@@ -355,11 +356,14 @@ int cdnsp_ep_enqueue(struct cdnsp_ep *pep, struct cdnsp_request *preq) request = &preq->request; request->actual =0 ; request->status = -EINPROGRESS ; - preq->direction = pep->direction; + + direction =usb_endpoint_xfer_control (pep->endpoint.desc) ? + pdev->ep0_expect_in : pep->direction; + preq->direction = direction; preq->epnum = pep->number; preq->td.drbl =0 ; - ret =usb_gadget_map_request_by_dev (pdev->dev, request, pep->direction); + ret =usb_gadget_map_request_by_dev (pdev->dev, request, direction);if (ret) {trace_cdnsp_request_enqueue_error (preq);return ret;
@@ -387,8 +391,7 @@ int cdnsp_ep_enqueue(struct cdnsp_ep *pep, struct cdnsp_request *preq)return 0 ; unmap: -usb_gadget_unmap_request_by_dev (pdev->dev, &preq->request, - pep->direction); +usb_gadget_unmap_request_by_dev (pdev->dev, &preq->request, direction);list_del (&preq->list);trace_cdnsp_request_enqueue_error (preq);
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 9 lines · Jing Leng
EP0 transfer is bi-directional, but in the cdnsp gadget, the transmission direction of EP0 is not changed after it is initialized to IN, so the OUT data from EP0 received by the host is invalid.
The value of
ep0_expect_inwill change according to the value of bRequestType in the SETUP transaction of control transfer, so we can use it as the transmission direction of EP0.
Quoted 6 lines
Signed-off-by Jing Leng <[email protected]>Signed-off-by Jing Leng <[email protected]>---
ChangeLogv1->v2:
- Rebase the patch.
- Make email addresses ('From' and 'Signed-off-by') consistent.
That didn't happen. You list yourself twice, and the last one does not match the From: line on the patch.
Also the verification did not even work showing that this is an invalid email from [email protected], so I can't trust it at all.
Please fix up your email system to properly send email from ambarella.com with the correct verification.
thanks,
greg k-h
PATCH v3 1/1 usb: cdnsp: Fix wrong transmission direction of EP0
In reply to Jing LengEP0 transfer is bi-directional, but in the cdnsp gadget, the transmission direction of EP0 is not changed after it is initialized to IN, so the OUT data from EP0 received by the host is invalid.
The value of ep0_expect_in will change according to the value of bRequestType in the SETUP transaction of control transfer, so we can use it as the transmission direction of EP0.
---
ChangeLog v2->v3:
- Repair my email address.
ChangeLog v1->v2:
- Rebase the patch.
- Make email addresses ('From' and 'Signed-off-by') consistent.
--- drivers/usb/cdns3/cdnsp-gadget.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/usb/cdns3/cdnsp-gadget.c +7 -4
@@ -345,6 +345,7 @@ int cdnsp_ep_enqueue(struct cdnsp_ep *pep, struct cdnsp_request *preq) {struct cdnsp_device *pdev = pep->pdev;struct usb_request *request; +u8 direction;int ret;if (preq->epnum ==0 && !list_empty (&pep->pending_list)) {
@@ -355,11 +356,14 @@ int cdnsp_ep_enqueue(struct cdnsp_ep *pep, struct cdnsp_request *preq) request = &preq->request; request->actual =0 ; request->status = -EINPROGRESS ; - preq->direction = pep->direction; + + direction =usb_endpoint_xfer_control (pep->endpoint.desc) ? + pdev->ep0_expect_in : pep->direction; + preq->direction = direction; preq->epnum = pep->number; preq->td.drbl =0 ; - ret =usb_gadget_map_request_by_dev (pdev->dev, request, pep->direction); + ret =usb_gadget_map_request_by_dev (pdev->dev, request, direction);if (ret) {trace_cdnsp_request_enqueue_error (preq);return ret;
@@ -387,8 +391,7 @@ int cdnsp_ep_enqueue(struct cdnsp_ep *pep, struct cdnsp_request *preq)return 0 ; unmap: -usb_gadget_unmap_request_by_dev (pdev->dev, &preq->request, - pep->direction); +usb_gadget_unmap_request_by_dev (pdev->dev, &preq->request, direction);list_del (&preq->list);trace_cdnsp_request_enqueue_error (preq);
Signature · 5 lines
2.17.1 ********************************************************************** This email and attachments contain Ambarella Proprietary and/or Confidential Information and is intended solely for the use of the individual(s) to whom it is addressed. Any unauthorized review, use, disclosure, distribute, copy, or print is prohibited. If you are not an intended recipient, please contact the sender by reply email and destroy all copies of the original message. Thank you.
Greg KH
maintainerQuoted 5 lines · Jing Leng
EP0 transfer is bi-directional, but in the cdnsp gadget, the transmission direction of EP0 is not changed after it is initialized to IN, so the OUT data from EP0 received by the host is invalid.
Quoted 8 lines
The value of
ep0_expect_inwill change according to the value of bRequestType in the SETUP transaction of control transfer, so we can use it as the transmission direction of EP0.Signed-off-by Jing Leng <[email protected]>---
ChangeLogv2->v3:
- Repair my email address.
Yes, it works, and it's validated!
Nice job, thanks. I'll let the cdns3 maintainer review it first, but just wanted to say thanks for fixing this up, it makes my life a lot easier when accepting patches.
greg k-h
Quoted 7 lines · Jing Leng
Quoted 4 lines
EP0 transfer is bi-directional, but in the cdnsp gadget, the transmission direction of EP0 is not changed after it is initialized to IN, so the OUT data from EP0 received by the host is invalid.
Quoted 5 lines
Quoted 5 lines
The value of
ep0_expect_inwill change according to the value of bRequestType in the SETUP transaction of control transfer, so we can use it as the transmission direction of EP0.Signed-off-by Jing Leng <[email protected]>
Thanks,
Pawel Laaszczak
Quoted 11 lines
Quoted 3 lines
---
ChangeLogv2->v3:
- Repair my email address.Yes, it works, and it's validated!
Nice job, thanks. I'll let the cdns3 maintainer review it first, but just wanted to say thanks for fixing this up, it makes my life a lot easier when accepting patches.
greg k-h
Greg KH
maintainerQuoted 15 lines · Greg KH
Quoted 5 lines · Jing Leng
EP0 transfer is bi-directional, but in the cdnsp gadget, the transmission direction of EP0 is not changed after it is initialized to IN, so the OUT data from EP0 received by the host is invalid.
Quoted 8 lines
The value of
ep0_expect_inwill change according to the value of bRequestType in the SETUP transaction of control transfer, so we can use it as the transmission direction of EP0.Signed-off-by Jing Leng <[email protected]>---
ChangeLogv2->v3:
- Repair my email address.
Quoted 5 lines
Yes, it works, and it's validated!
Nice job, thanks. I'll let the cdns3 maintainer review it first, but just wanted to say thanks for fixing this up, it makes my life a lot easier when accepting patches.
Oops, I missed that email footer, sorry. That is NOT compatible with Linux kernel development, and as per the recommendation from my legal people, I have to go revert that change as we can't take it as-is because it might have been sent out incorrectly as it was stated to be "Proprietary and/or Confidential Information" which is not allowed in the Linux kernel.
thanks,
greg k-h