staging: most: dim2: hal: aligning function parameters
Subsystems (2)
PATCH RESEND v2 1/1 staging: most: dim2: hal: aligning function parameters
According to Linux Kernel Coding Style, lines should not end with a '(' Fix-issue reported by checkpatch.pl script.
---
Changes in v2:
1.Resending this patch because it was sent multiple times earlier.No
functional changes.
drivers/staging/most/dim2/hal.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/most/dim2/hal.c +2 -3
@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)dim2_clear_ctr (ctr_addr); } -static void dim2_configure_channel ( -u8 ch_addr,u8 type,u8 is_tx,u16 dbr_address,u16 hw_buffer_size, -u16 packet_length) +static void dim2_configure_channel (u8 ch_addr,u8 type,u8 is_tx,u16 dbr_address, +u16 hw_buffer_size,u16 packet_length) {dim2_configure_cdt (ch_addr, dbr_address, hw_buffer_size, packet_length);dim2_configure_cat (MLB_CAT , ch_addr, type, is_tx ?1 :0 );
Signature · 1 line
2.25.1
Quoted 2 lines · UMWARI JOVIAL
According to Linux Kernel Coding Style, lines should not end with a '(' Fix-issue reported by checkpatch.pl script.
How about something like "To improve readability, start the list of function parameters on the same line as the function name. Issue reported by checkpatch."
That would more clearly explain the intent behind the change.
julia
Quoted 32 lines
Signed-off-by UMWARI JOVIAL <[email protected]>---
Changes in v2:
1.Resending this patch because it was sent multiple times earlier.No
functional changes.drivers/staging/most/dim2/hal.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/most/dim2/hal.c +2
-4@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)dim2_clear_ctr (ctr_addr); } -static void dim2_configure_channel ( -u8 ch_addr,u8 type,u8 is_tx,u16 dbr_address,u16 hw_buffer_size, -u16 packet_length) +static void dim2_configure_channel (u8 ch_addr,u8 type,u8 is_tx,u16 dbr_address, +u16 hw_buffer_size,u16 packet_length) {dim2_configure_cdt (ch_addr, dbr_address, hw_buffer_size, packet_length);dim2_configure_cat (MLB_CAT , ch_addr, type, is_tx ?1 :0 ); --2.25.1
Will do. Thanks
Quoted 49 lines · Julia Lawall
Quoted 2 lines · UMWARI JOVIAL
According to Linux Kernel Coding Style, lines should not end with a '(' Fix-issue reported by checkpatch.pl script.
How about something like "To improve readability, start the list of function parameters on the same line as the function name. Issue reported by checkpatch."
That would more clearly explain the intent behind the change.
julia
Quoted 32 lines
Signed-off-by UMWARI JOVIAL <[email protected]>---
Changes in v2:
1.Resending this patch because it was sent multiple times earlier.No
functional changes.drivers/staging/most/dim2/hal.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/most/dim2/hal.c +2
-4@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)dim2_clear_ctr (ctr_addr); } -static void dim2_configure_channel ( -u8 ch_addr,u8 type,u8 is_tx,u16 dbr_address,u16 hw_buffer_size, -u16 packet_length) +static void dim2_configure_channel (u8 ch_addr,u8 type,u8 is_tx,u16 dbr_address, +u16 hw_buffer_size,u16 packet_length) {dim2_configure_cdt (ch_addr, dbr_address, hw_buffer_size, packet_length);dim2_configure_cat (MLB_CAT , ch_addr, type, is_tx ?1 :0 ); --2.25.1