i2c: hisi: Add initial device tree support
PATCH v10 1/2 i2c: hisi: Add initial device tree support
The HiSilicon I2C controller can be used on embedded platform, which boot from devicetree.
---
Change since v9:
- Drop wrong use ACPI_PTR/of_match_ptr
drivers/i2c/busses/Kconfig | 2 +- drivers/i2c/busses/i2c-hisi.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-)
drivers/i2c/busses/Kconfig +1 -1
@@ -673,7 +673,7 @@ config I2C_HIGHLANDER config I2C_HISI tristate "HiSilicon I2C controller" - depends on (ARM64 && ACPI) || COMPILE_TEST + depends on ARM64 || COMPILE_TEST help Say Y here if you want to have Hisilicon I2C controller support available on the Kunpeng Server.
drivers/i2c/busses/i2c-hisi.c +7 -0
@@ -489,11 +489,18 @@ static const struct acpi_device_id hisi_i2c_acpi_ids[] = { };MODULE_DEVICE_TABLE (acpi, hisi_i2c_acpi_ids); +static const struct of_device_id hisi_i2c_dts_ids[] = { + { .compatible ="hisilicon,ascend910-i2c" , }, + { } +}; +MODULE_DEVICE_TABLE (of, hisi_i2c_dts_ids); +static struct platform_driver hisi_i2c_driver = { .probe = hisi_i2c_probe, .driver = { .name ="hisi-i2c" , .acpi_match_table = hisi_i2c_acpi_ids, + .of_match_table = hisi_i2c_dts_ids, }, };module_platform_driver (hisi_i2c_driver);
Signature · 1 line
2.31.GIT
PATCH v10 2/2 dt-bindings: i2c: add entry for hisilicon,ascend910-i2c
Add the new compatible for HiSilicon i2c.
---
Change since v9:
- No change
Change since v8:
- Use vendor,soc-ipblock format.
- Drop quotes.
- Drop "Device Tree bindings".
- Description goes to top level description.
- Use defines for constants.
.../bindings/i2c/hisilicon,ascend910-i2c.yaml | 73 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml
Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml new file +73 -0
@@ -0,0 +1,73 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/i2c/hisilicon,ascend910-i2c.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HiSilicon common I2C controller + +maintainers: + - Yicong Yang <[email protected]> + +description: + The HiSilicon common I2C controller can be used for many different + types of SoC such as Huawei Ascend AI series chips. + +allOf: + - $ref: /schemas/i2c/i2c-controller.yaml# + +properties: + compatible: + const: hisilicon,ascend910-i2c + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-frequency: + default: 400000 + + i2c-sda-falling-time-ns: + default: 343 + + i2c-scl-falling-time-ns: + default: 203 + + i2c-sda-hold-time-ns: + default: 830 + + i2c-scl-rising-time-ns: + default: 365 + + i2c-digital-filter-width-ns: + default: 0 + +required: + - compatible + - reg + - interrupts + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + i2c@38b0000 { + compatible = "hisilicon,ascend910-i2c"; + reg = <0x38b0000 0x10000>; + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; + i2c-sda-falling-time-ns = <56>; + i2c-scl-falling-time-ns = <56>; + i2c-sda-hold-time-ns = <56>; + i2c-scl-rising-time-ns = <56>; + i2c-digital-filter; + i2c-digital-filter-width-ns = <0x0>; + clocks = <&alg_clk>; + clock-frequency = <400000>; + };
MAINTAINERS +1 -0
@@ -9228,6 +9228,7 @@ M: Yicong Yang <[email protected]> L: [email protected] S: Maintained W: https://www.hisilicon.com +F: Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml F: drivers/i2c/busses/i2c-hisi.c HISILICON LPC BUS DRIVER
Signature · 1 line
2.31.GIT
Re: [PATCH next v10 2/2] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c
Quoted 2 lines · Weilong Chen
Add the new compatible for HiSilicon i2c.
Quoted 112 lines
Signed-off-by Weilong Chen <[email protected]>Reviewed-by Rob Herring <[email protected]>---
Change since v9:
- No changeChange since v8:
- Use vendor,soc-ipblock format.
- Drop quotes.
- Drop "Device Tree bindings".
- Description goes to top level description.
- Use defines for constants..../bindings/i2c/hisilicon,ascend910-i2c.yaml | 73 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yamlDocumentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml new file +73
-0@@ -0,0 +1,73 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/i2c/hisilicon,ascend910-i2c.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: HiSilicon common I2C controller + +maintainers: + - Yicong Yang <[email protected]> + +description: + The HiSilicon common I2C controller can be used for many different + types of SoC such as Huawei Ascend AI series chips. + +allOf: + - $ref: /schemas/i2c/i2c-controller.yaml# + +properties: + compatible: + const: hisilicon,ascend910-i2c + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-frequency: + default: 400000 + + i2c-sda-falling-time-ns: + default: 343 + + i2c-scl-falling-time-ns: + default: 203 + + i2c-sda-hold-time-ns: + default: 830 + + i2c-scl-rising-time-ns: + default: 365 + + i2c-digital-filter-width-ns: + default: 0 + +required: + - compatible + - reg + - interrupts + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + i2c@38b0000 { + compatible = "hisilicon,ascend910-i2c"; + reg = <0x38b0000 0x10000>; + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; + i2c-sda-falling-time-ns = <56>; + i2c-scl-falling-time-ns = <56>; + i2c-sda-hold-time-ns = <56>; + i2c-scl-rising-time-ns = <56>; + i2c-digital-filter; + i2c-digital-filter-width-ns = <0x0>; + clocks = <&alg_clk>; + clock-frequency = <400000>; + };MAINTAINERS +1
-0@@ -9228,6 +9228,7 @@ M: Yicong Yang <[email protected]> L: [email protected] S: Maintained W: https://www.hisilicon.com +F: Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml F: drivers/i2c/busses/i2c-hisi.c HISILICON LPC BUS DRIVER
Wolfram Sang
AppliedRe: [PATCH next v10 2/2] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c
In reply to Weilong ChenQuoted 4 lines · Weilong Chen
Add the new compatible for HiSilicon i2c.
Signed-off-by Weilong Chen <[email protected]>Reviewed-by Rob Herring <[email protected]>
Applied to for-next, thanks!
Quoted 2 lines · Weilong Chen
The HiSilicon I2C controller can be used on embedded platform, which boot from devicetree.
Thanks, This version LGTM,
Quoted 50 lines
Signed-off-by Weilong Chen <[email protected]>Acked-by Yicong Yang <[email protected]>---
Change since v9:
- Drop wrong use ACPI_PTR/of_match_ptrdrivers/i2c/busses/Kconfig | 2 +- drivers/i2c/busses/i2c-hisi.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-)drivers/i2c/busses/Kconfig +1
-1@@ -673,7 +673,7 @@ config I2C_HIGHLANDER config I2C_HISI tristate "HiSilicon I2C controller" - depends on (ARM64 && ACPI) || COMPILE_TEST + depends on ARM64 || COMPILE_TEST help Say Y here if you want to have Hisilicon I2C controller support available on the Kunpeng Server.drivers/i2c/busses/i2c-hisi.c +7
-0@@ -489,11 +489,18 @@ static const struct acpi_device_id hisi_i2c_acpi_ids[] = { };MODULE_DEVICE_TABLE (acpi, hisi_i2c_acpi_ids); +static const struct of_device_id hisi_i2c_dts_ids[] = { + { .compatible ="hisilicon,ascend910-i2c" , }, + { } +}; +MODULE_DEVICE_TABLE (of, hisi_i2c_dts_ids); +static struct platform_driver hisi_i2c_driver = { .probe = hisi_i2c_probe, .driver = { .name ="hisi-i2c" , .acpi_match_table = hisi_i2c_acpi_ids, + .of_match_table = hisi_i2c_dts_ids, }, };module_platform_driver (hisi_i2c_driver);Signature · 1 line
2.31.GIT
Signature · 2 lines
With Best Regards, Andy Shevchenko
Wolfram Sang
AppliedQuoted 5 lines · Weilong Chen
The HiSilicon I2C controller can be used on embedded platform, which boot from devicetree.
Signed-off-by Weilong Chen <[email protected]>Acked-by Yicong Yang <[email protected]>
Applied to for-next, thanks!