Skip to contentSkip to conversation

video: fbdev: omapfb: remove redundant variable checksum

PATCH Applied Colin Ian King 2 participants 2 messages Nov 1, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: fbdev: omapfb: remove redundant variable checksum

Variable checksum is being used to accumulate values however it is never read or used afterwards. It is redundant and can be removed.

---
 drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 2 --
 1 file changed, 2 deletions(-)
drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c +0 -2
index cb63bc0e92ca..b33f62c5cb22 100644
@@ -129,7 +129,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext)
 {
 	void __iomem *base = core->base;
 	u8 cur_addr;
-	char checksum = 0;
 	const int retries = 1000;
 	u8 seg_ptr = ext / 2;
 	u8 edidbase = ((ext % 2) * 0x80);
@@ -178,7 +177,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext)
 		}
 
 		pedid[cur_addr] = REG_GET(base, HDMI_CORE_I2CM_DATAI, 7, 0);
-		checksum += pedid[cur_addr];
 	}
 
 	return 0;
Signature · 1 line
2.37.3
maintainer Applied
#1 lore raw
Quoted 5 lines · Colin Ian King

Variable checksum is being used to accumulate values however it is never read or used afterwards. It is redundant and can be removed.

applied.

Thanks!
Helge

Quoted 24 lines
---
  drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 2 --
  1 file changed, 2 deletions(-)
drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c +0 -2
index cb63bc0e92ca..b33f62c5cb22 100644
@@ -129,7 +129,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext)
  {
  	void __iomem *base = core->base;
  	u8 cur_addr;
-	char checksum = 0;
  	const int retries = 1000;
  	u8 seg_ptr = ext / 2;
  	u8 edidbase = ((ext % 2) * 0x80);
@@ -178,7 +177,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext)
  		}
 
  		pedid[cur_addr] = REG_GET(base, HDMI_CORE_I2CM_DATAI, 7, 0);
-		checksum += pedid[cur_addr];
  	}
 
  	return 0;