Skip to contentSkip to conversation

drm/ofdrm: Depend on CONFIG_MMU

PATCH In review Thomas Zimmermann 2 participants 2 messages Nov 1, 2022 – Nov 2, 2022

Subsystems (2)
lore
Share & tools
lore

Thomas Zimmermann

author maintainer
#0 lore raw

PATCH 1/1 drm/ofdrm: Depend on CONFIG_MMU

Add a dependency on CONFIG_MMU to ofdrm. The driver uses GEM SHMEM helpers, which require MMU support. A reported error message [1] is shown below.

arm-linux-gnueabi-ld: drivers/gpu/drm/drm_gem_shmem_helper.o: in function `drm_gem_shmem_fault':

Quoted 1 line
Quoted 1 line

drivers/gpu/drm/drm_gem_shmem_helper.c:562: undefined reference to `vmf_insert_pfn'

Fixes c8a17756c425 ("drm/ofdrm: Add ofdrm for Open Firmware framebuffers")
Cc Thomas Zimmermann <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc "Noralf Trønnes" <[email protected]>
Cc Danilo Krummrich <[email protected]>
Cc Michal Suchanek <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 drivers/gpu/drm/tiny/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tiny/Kconfig +1 -1
index a300b03a3c7a7..f6889f649bc18 100644
@@ -53,7 +53,7 @@ config DRM_GM12U320
 
 config DRM_OFDRM
 	tristate "Open Firmware display driver"
-	depends on DRM && OF && (PPC || COMPILE_TEST)
+	depends on DRM && MMU && OF && (PPC || COMPILE_TEST)
 	select APERTURE_HELPERS
 	select DRM_GEM_SHMEM_HELPER
 	select DRM_KMS_HELPER
Signature · 1 line
2.38.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Thomas Zimmermann

Add a dependency on CONFIG_MMU to ofdrm. The driver uses GEM SHMEM helpers, which require MMU support. A reported error message [1] is shown below.

arm-linux-gnueabi-ld: drivers/gpu/drm/drm_gem_shmem_helper.o: in function `drm_gem_shmem_fault':

Quoted 1 line
Quoted 1 line

drivers/gpu/drm/drm_gem_shmem_helper.c:562: undefined reference to `vmf_insert_pfn'

Fixes c8a17756c425 ("drm/ofdrm: Add ofdrm for Open Firmware framebuffers")
Cc Thomas Zimmermann <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc "Noralf Trønnes" <[email protected]>
Cc Danilo Krummrich <[email protected]>
Cc Michal Suchanek <[email protected]>
Cc Daniel Vetter <[email protected]>
Quoted 1 line

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat