scsi: target: core: Remove unused variable unit_serial_len
Subsystems (3)
PATCH 1/1 scsi: target: core: Remove unused variable unit_serial_len
Variable unit_serial_len is just being assigned and it's never used anywhere else. The variable is redundant so remove it.
Signed-off-by Colin Ian King <[email protected]>
--- drivers/target/target_core_spc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/target/target_core_spc.c +2 -6
@@ -227,7 +227,7 @@ spc_emulate_evpd_83(struct se_cmd *cmd, unsigned char *buf)struct t10_alua_tg_pt_gp *tg_pt_gp;unsigned char *prod = &dev->t10_wwn.model[0 ];u32 prod_len; -u32 unit_serial_len, off =0 ; +u32 off =0 ;u16 len =0 , id_len; off =4 ;
@@ -272,13 +272,9 @@ spc_emulate_evpd_83(struct se_cmd *cmd, unsigned char *buf) prod_len +=strlen (prod); prod_len++;/* For : */ -if (dev->dev_flags &DF_EMULATED_VPD_UNIT_SERIAL ) { - unit_serial_len =strlen (&dev->t10_wwn.unit_serial[0 ]); - unit_serial_len++;/* For NULL Terminator */ - +if (dev->dev_flags &DF_EMULATED_VPD_UNIT_SERIAL ) id_len +=sprintf (&buf[off+12 ],"%s:%s" , prod, &dev->t10_wwn.unit_serial[0 ]); - } buf[off] =0x2 ;/* ASCII */ buf[off+1 ] =0x1 ;/* T10 Vendor ID */ buf[off+2 ] =0x0 ;
Signature · 1 line
2.37.3
Martin K. Petersen
AppliedColin,
Quoted 2 lines
Variable
unit_serial_lenis just being assigned and it's never used anywhere else. The variable is redundant so remove it.
Applied to 6.2/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 4 lines · Colin Ian King
Variable
unit_serial_lenis just being assigned and it's never used anywhere else. The variable is redundant so remove it.
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: target: core: Remove unused variable unit_serial_len
https://git.kernel.org/mkp/scsi/c/bc81131813aa
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering