kselftest/arm64: Print ASCII version of unknown signal frame magic values
PATCH 1/1 kselftest/arm64: Print ASCII version of unknown signal frame magic values
The signal magic values are supposed to be allocated as somewhat meaningful ASCII so if we encounter a bad magic value print the any alphanumeric characters we find in it as well as the hex value to aid debuggability.
Signed-off-by Mark Brown <[email protected]>
--- .../arm64/signal/testcases/testcases.c | 21 +++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)
tools/testing/selftests/arm64/signal/testcases/testcases.c +17 -4
@@ -1,5 +1,9 @@// SPDX-License-Identifier: GPL-2.0 /* Copyright (C) 2019 ARM Limited */ + +#include <ctype.h> +#include <string.h> +#include "testcases.h" struct _aarch64_ctx *get_header(struct _aarch64_ctx *head, uint32_t magic,
@@ -109,7 +113,7 @@ bool validate_reserved(ucontext_t *uc, size_t resv_sz, char **err)bool terminated = false;size_t offs =0 ;int flags =0 ; -int new_flags; +int new_flags, i;struct extra_context *extra =NULL ;struct sve_context *sve =NULL ;struct za_context *za =NULL ;
@@ -117,6 +121,7 @@ bool validate_reserved(ucontext_t *uc, size_t resv_sz, char **err) (struct _aarch64_ctx *)uc->uc_mcontext.__reserved;void *extra_data =NULL ;size_t extra_sz =0 ; +char magic[4 ];if (!err)return false;
@@ -194,11 +199,19 @@ bool validate_reserved(ucontext_t *uc, size_t resv_sz, char **err)/* * A still unknown Magic: potentially freshly added * to the Kernel code and still unknown to the -* tests. +* tests. Magic numbers are supposed to be allocated +* as somewhat meaningful ASCII strings so try to +* print as such as well as the raw number. */ +memcpy (magic, &head->magic,sizeof (magic)); +for (i =0 ; i <sizeof (magic); i++) +if (!isalnum (magic[i])) + magic[i] ='?' ; +fprintf (stdout, -"SKIP Unknown MAGIC: 0x%X - Is KSFT arm64/signal up to date ?\n" , - head->magic); +"SKIP Unknown MAGIC: 0x%X (%c%c%c%c) - Is KSFT arm64/signal up to date ?\n" , + head->magic, + magic[3 ], magic[2 ], magic[1 ], magic[0 ]);break ; }
base-commit: 30a0b95b1335e12efef89dd78518ed3e4a71a763
Signature · 1 line
2.30.2
Will Deacon
maintainerQuoted 5 lines · Mark Brown
The signal magic values are supposed to be allocated as somewhat meaningful ASCII so if we encounter a bad magic value print the any alphanumeric characters we find in it as well as the hex value to aid debuggability.
Applied to arm64 (for-next/selftests), thanks!
[1/1] kselftest/arm64: Print ASCII version of unknown signal frame magic values
https://git.kernel.org/arm64/c/9b283888a6d5
Cheers,
Signature · 5 lines
Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev