Skip to contentSkip to conversation

net/mlx5: fix shared Rx queue config reuse

PATCH In review Alexander Kozyrev 3 participants 3 messages Nov 2, 2022 – Nov 6, 2022 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: fix shared Rx queue config reuse

There is a check for the configuration match between all the Rx queues shared among multiple ports in DPDK. This check ensures that the configuration is the same.

The issue is this check takes place before the queue is released and configured again in case of reconfiguration. That leads to checking against the old configuration and preventing the shared Rx queue to start properly.

Release the old configuration and prepare a new Rx queue before checking that its parameters match the config.

Fixes 09c2555303 ("net/mlx5: support shared Rx queue")
---
 drivers/net/mlx5/mlx5_rxq.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/net/mlx5/mlx5_rxq.c +7 -3
index b7818f9598..0d9d11680b 100644
@@ -902,16 +902,20 @@ mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
 		/* Try to reuse shared RXQ. */
 		rxq_ctrl = mlx5_shared_rxq_get(dev, conf->share_group,
 					       conf->share_qid);
+		res = mlx5_rx_queue_pre_setup(dev, idx, &desc, &rxq_ctrl);
+		if (res)
+			return res;
 		if (rxq_ctrl != NULL &&
 		    !mlx5_shared_rxq_match(rxq_ctrl, dev, idx, desc, socket,
 					   conf, mp)) {
 			rte_errno = EINVAL;
 			return -rte_errno;
 		}
+	} else {
+		res = mlx5_rx_queue_pre_setup(dev, idx, &desc, &rxq_ctrl);
+		if (res)
+			return res;
 	}
-	res = mlx5_rx_queue_pre_setup(dev, idx, &desc, &rxq_ctrl);
-	if (res)
-		return res;
 	/* Allocate RXQ. */
 	rxq = mlx5_malloc(MLX5_MEM_RTE | MLX5_MEM_ZERO, sizeof(*rxq), 0,
 			  SOCKET_ID_ANY);
Signature · 1 line
2.18.2
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines

There is a check for the configuration match between all the Rx queues shared among multiple ports in DPDK.
This check ensures that the configuration is the same.

The issue is this check takes place before the queue is released and configured again in case of reconfiguration.
That leads to checking against the old configuration and preventing the shared Rx queue to start properly.

Quoted 6 lines

Release the old configuration and prepare a new Rx queue before checking that its parameters match the config.

Fixes 09c2555303 ("net/mlx5: support shared Rx queue")
#2 lore raw
In reply to Alexander Kozyrev

Hi,

Quoted 18 lines

-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Wednesday, November 2, 2022 4:25 PM
To: [email protected]
Cc: [email protected]; Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>; Xueming(Steven) Li <[email protected]>
Subject: [PATCH] net/mlx5: fix shared Rx queue config reuse

There is a check for the configuration match between all the Rx queues shared among multiple ports in DPDK.
This check ensures that the configuration is the same.

The issue is this check takes place before the queue is released and configured again in case of reconfiguration.
That leads to checking against the old configuration and preventing the shared Rx queue to start properly.

Quoted 6 lines

Release the old configuration and prepare a new Rx queue before checking that its parameters match the config.

Fixes 09c2555303 ("net/mlx5: support shared Rx queue")

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh