Skip to contentSkip to conversation

baseband/acc: coverity fix RC2

PATCH Applied Nicolas Chautru 2 participants 3 messages Nov 2, 2022 – Nov 3, 2022

lore
Share & tools
lore
#0 lore raw

cover baseband/acc: coverity fix RC2

Another fix for coverity issue just raised on RC2
for ACC200 PMD.

Nicolas Chautru (1):
baseband/acc: fix to possible negative shift

 drivers/baseband/acc/rte_acc200_pmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.37.1
#1 lore raw

PATCH 1/1 baseband/acc: fix to possible negative shift

Potential occurrence of negative shift when using invalid configuration on ACC200. Enforcing that depth > 0.

Coverity issue: 381636

Fixes 40e3adbdd3 ("baseband/acc200: add queue configuration")
---
 drivers/baseband/acc/rte_acc200_pmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/baseband/acc/rte_acc200_pmd.c +2 -2
index 8ee9023451..7d7a6c6389 100644
@@ -105,9 +105,9 @@ aqDepth(int qg_idx, struct rte_acc_conf *acc_conf)
 	qtopFromAcc(&q_top, acc_enum, acc_conf);
 
 	if (unlikely(q_top == NULL))
-		return 0;
+		return 1;
 
-	return q_top->aq_depth_log2;
+	return RTE_MAX(1, q_top->aq_depth_log2);
 }
 
 /* Return the AQ depth for a Queue Group Index. */
Signature · 1 line
2.37.1
Applied
#2 lore raw

RE: [EXT] [PATCH v1 1/1] baseband/acc: fix to possible negative shift

Quoted 7 lines

Potential occurrence of negative shift when using invalid configuration on ACC200. Enforcing that depth > 0.

Coverity issue: 381636

Fixes 40e3adbdd3 ("baseband/acc200: add queue configuration")

Applied to dpdk-next-crypto

Thanks.