Skip to contentSkip to conversation

dt-bindings: media: imx7-csi: Document i.MX8M power-domains property

PATCH In review Marek Vasut 4 participants 9 messages Nov 2, 2022 – Jan 2, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: media: imx7-csi: Document i.MX8M power-domains property

The power-domains property is mandatory on i.MX8M Quad and Mini. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

---
Cc: Fabio Estevam <[email protected]>
Cc: Hans Verkuil <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Martin Kepplinger <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: NXP Linux Team <[email protected]>
To: [email protected]

---
 .../devicetree/bindings/media/nxp,imx7-csi.yaml   | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml +15 -0
index 4f7b782653361..358019e85d907 100644
@@ -37,6 +37,9 @@ properties:
     items:
       - const: mclk
 
+  power-domains:
+    maxItems: 1
+
   port:
     $ref: /schemas/graph.yaml#/properties/port
 
@@ -50,6 +53,18 @@ required:
 
 additionalProperties: false
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx8mq-csi
+              - fsl,imx8mm-csi
+    then:
+      required:
+        - power-domains
+
 examples:
   - |
     #include <dt-bindings/clock/imx7d-clock.h>
Signature · 7 lines
2.35.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw
Quoted 5 lines · Marek Vasut

The power-domains property is mandatory on i.MX8M Quad and Mini. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

Quoted 12 lines

---
Cc: Fabio Estevam <[email protected]>
Cc: Hans Verkuil <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Martin Kepplinger <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: NXP Linux Team <[email protected]>
To: [email protected]

You keep skipping me in all your submissions.

Again, use get_maintainers.pl and/or update your tree to based on something recent. Patches made on 1-year-old kernel are not for upstream...

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 19 lines · Krzysztof Kozlowski
Quoted 5 lines · Marek Vasut

The power-domains property is mandatory on i.MX8M Quad and Mini. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

Quoted 12 lines

---
Cc: Fabio Estevam <[email protected]>
Cc: Hans Verkuil <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Martin Kepplinger <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: NXP Linux Team <[email protected]>
To: [email protected]

Quoted 1 line

You keep skipping me in all your submissions.

I seem to be copying the same CC list from somewhere, lemme update it.

Quoted 2 lines

Again, use get_maintainers.pl and/or update your tree to based on something recent. Patches made on 1-year-old kernel are not for upstream...

I am on next-20221102 .

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#3 lore raw
In reply to Krzysztof Kozlowski
Quoted 19 lines · Krzysztof Kozlowski
Quoted 5 lines · Marek Vasut

The power-domains property is mandatory on i.MX8M Quad and Mini. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

Quoted 12 lines

---
Cc: Fabio Estevam <[email protected]>
Cc: Hans Verkuil <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Martin Kepplinger <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: NXP Linux Team <[email protected]>
To: [email protected]

Quoted 1 line

You keep skipping me in all your submissions.

Marek, could you please also CC the linux-media mailing list ? get_maintainers.pl should report it.

Quoted 2 lines

Again, use get_maintainers.pl and/or update your tree to based on something recent. Patches made on 1-year-old kernel are not for upstream...

Krzysztof, as Marek mentioned in a separate reply, this patch was based on mainline, and applies cleanly. Are you waiting for a resubmission to review it, or can I merge it ?

Signature · 8 lines
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#4 lore raw
Quoted 25 lines · Laurent Pinchart
Quoted 19 lines · Krzysztof Kozlowski
Quoted 5 lines · Marek Vasut

The power-domains property is mandatory on i.MX8M Quad and Mini. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

Quoted 12 lines

---
Cc: Fabio Estevam <[email protected]>
Cc: Hans Verkuil <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Martin Kepplinger <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: NXP Linux Team <[email protected]>
To: [email protected]

Quoted 1 line

You keep skipping me in all your submissions.

Marek, could you please also CC the linux-media mailing list ? get_maintainers.pl should report it.

Quoted 7 lines
Quoted 2 lines

Again, use get_maintainers.pl and/or update your tree to based on something recent. Patches made on 1-year-old kernel are not for upstream...

Krzysztof, as Marek mentioned in a separate reply, this patch was based on mainline, and applies cleanly. Are you waiting for a resubmission to review it, or can I merge it ?

Hm, I thought I acked it.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw
Quoted 29 lines · Krzysztof Kozlowski
Quoted 28 lines · Laurent Pinchart
Quoted 19 lines · Krzysztof Kozlowski
Quoted 5 lines · Marek Vasut

The power-domains property is mandatory on i.MX8M Quad and Mini. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

Quoted 12 lines

---
Cc: Fabio Estevam <[email protected]>
Cc: Hans Verkuil <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Martin Kepplinger <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: NXP Linux Team <[email protected]>
To: [email protected]

Quoted 1 line

You keep skipping me in all your submissions.

Marek, could you please also CC the linux-media mailing list ? get_maintainers.pl should report it.

Quoted 2 lines

Again, use get_maintainers.pl and/or update your tree to based on something recent. Patches made on 1-year-old kernel are not for upstream...

Quoted 8 lines
Quoted 4 lines

Krzysztof, as Marek mentioned in a separate reply, this patch was based on mainline, and applies cleanly. Are you waiting for a resubmission to review it, or can I merge it ?

Hm, I thought I acked it.

Laurent, shall I still resubmit this one more time ?

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#6 lore raw

Hi Marek,

Quoted 35 lines · Marek Vasut
Quoted 34 lines · Krzysztof Kozlowski
Quoted 32 lines · Laurent Pinchart
Quoted 19 lines · Krzysztof Kozlowski
Quoted 5 lines · Marek Vasut

The power-domains property is mandatory on i.MX8M Quad and Mini. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

Quoted 12 lines

---
Cc: Fabio Estevam <[email protected]>
Cc: Hans Verkuil <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Martin Kepplinger <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: NXP Linux Team <[email protected]>
To: [email protected]

Quoted 1 line

You keep skipping me in all your submissions.

Marek, could you please also CC the linux-media mailing list ? get_maintainers.pl should report it.

Quoted 2 lines

Again, use get_maintainers.pl and/or update your tree to based on something recent. Patches made on 1-year-old kernel are not for upstream...

Krzysztof, as Marek mentioned in a separate reply, this patch was based on mainline, and applies cleanly. Are you waiting for a resubmission to review it, or can I merge it ?

Quoted 5 lines
Quoted 3 lines

Hm, I thought I acked it.

Laurent, shall I still resubmit this one more time ?

No, I have the patch in my tree, I'll send a pull request this week.

Signature · 8 lines
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#7 lore raw
Quoted 38 lines · Laurent Pinchart

Hi Marek,

Quoted 35 lines · Marek Vasut
Quoted 34 lines · Krzysztof Kozlowski
Quoted 32 lines · Laurent Pinchart
Quoted 19 lines · Krzysztof Kozlowski
Quoted 5 lines · Marek Vasut

The power-domains property is mandatory on i.MX8M Quad and Mini. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

Quoted 12 lines

---
Cc: Fabio Estevam <[email protected]>
Cc: Hans Verkuil <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Martin Kepplinger <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: NXP Linux Team <[email protected]>
To: [email protected]

Quoted 1 line

You keep skipping me in all your submissions.

Marek, could you please also CC the linux-media mailing list ? get_maintainers.pl should report it.

Quoted 2 lines

Again, use get_maintainers.pl and/or update your tree to based on something recent. Patches made on 1-year-old kernel are not for upstream...

Krzysztof, as Marek mentioned in a separate reply, this patch was based on mainline, and applies cleanly. Are you waiting for a resubmission to review it, or can I merge it ?

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Hm, I thought I acked it.

Laurent, shall I still resubmit this one more time ?

No, I have the patch in my tree, I'll send a pull request this week.

Thanks!

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#8 lore raw
In reply to Marek Vasut

Am Mittwoch, 2. November 2022, 20:19:10 CET schrieb Marek Vasut:

Quoted 45 lines

The power-domains property is mandatory on i.MX8M Quad and Mini. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

---
Cc: Fabio Estevam <[email protected]>
Cc: Hans Verkuil <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Martin Kepplinger <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: NXP Linux Team <[email protected]>
To: [email protected]

---
 .../devicetree/bindings/media/nxp,imx7-csi.yaml   | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
(quoted diff) +0 -0

b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml index 4f7b782653361..358019e85d907 100644

Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml +8 -0
@@ -37,6 +37,9 @@ properties:
     items:
       - const: mclk
 
+  power-domains:
+    maxItems: 1
+
   port:
     $ref: /schemas/graph.yaml#/properties/port
 
@@ -50,6 +53,18 @@ required:
 
 additionalProperties: false
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:

Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml required: · line 70

Quoted 10 lines
Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml +7 -0
+            enum:
+              - fsl,imx8mq-csi
+              - fsl,imx8mm-csi
+    then:
+      required:
+        - power-domains
+
 examples:
   - |
     #include <dt-bindings/clock/imx7d-clock.h>

Acked-by:
Alexander Stein <[email protected]>

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel