net/mlx5: remove redundant ret variable
Subsystems (4)
PATCH 1/1 net/mlx5: remove redundant ret variable
From 74562e313cf9a1b96c7030f27964f826a0c2572d Mon Sep 17 00:00:00 2001
From: zhang songyi <[email protected]>
Date: Wed, 2 Nov 2022 20:48:08 +0800
Subject: [PATCH linux-next] net/mlx5: remove redundant ret variable
Return value from mlx5dr_send_postsend_action() directly instead of taking this in another redundant variable.
--- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c +1 -4
@@ -724,7 +724,6 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn, struct mlx5dr_action *action) {struct postsend_info send_info = {}; -int ret; send_info.write.addr = (uintptr_t )action->rewrite->data; send_info.write.length = action->rewrite->num_of_actions *
@@ -734,9 +733,7 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,mlx5dr_icm_pool_get_chunk_mr_addr (action->rewrite->chunk); send_info.rkey =mlx5dr_icm_pool_get_chunk_rkey (action->rewrite->chunk); - ret =dr_postsend_icm_data (dmn, &send_info); - -return ret; +return dr_postsend_icm_data (dmn, &send_info); } static int dr_modify_qp_rst2init(struct mlx5_core_dev *mdev,
--
2.15.2
Quoted 4 lines · On Wed, Nov 02, 2022 at 09:50:40PM +0800, [email protected] wrote:
From
74562e313cf9a1b96c7030f27964f826a0c2572dMon Sep 17 00:00:00 2001
From: zhang songyi <[email protected]>
Date: Wed, 2 Nov 2022 20:48:08 +0800
Subject: [PATCH linux-next] net/mlx5: remove redundant ret variable
Subject line should be "[PATCH net-next] ..." for all net patches. And please use git send-email utility to send the patches.
Thanks
Quoted 35 lines
Return value from
mlx5dr_send_postsend_action()directly instead of taking this in another redundant variable.Reported-by Zeal Robot <[email protected]>Signed-off-by zhang songyi <[email protected]>--- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c +1
-5@@ -724,7 +724,6 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn, struct mlx5dr_action *action) {struct postsend_info send_info = {}; -int ret; send_info.write.addr = (uintptr_t )action->rewrite->data; send_info.write.length = action->rewrite->num_of_actions *@@ -734,9 +733,7 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,mlx5dr_icm_pool_get_chunk_mr_addr (action->rewrite->chunk); send_info.rkey =mlx5dr_icm_pool_get_chunk_rkey (action->rewrite->chunk); - ret =dr_postsend_icm_data (dmn, &send_info); - -return ret; +return dr_postsend_icm_data (dmn, &send_info); } static int dr_modify_qp_rst2init(struct mlx5_core_dev *mdev, --2.15.2
Quoted 10 lines · Leon Romanovsky
Quoted 4 lines · On Wed, Nov 02, 2022 at 09:50:40PM +0800, [email protected] wrote:
From
74562e313cf9a1b96c7030f27964f826a0c2572dMon Sep 17 00:00:00 2001
From: zhang songyi <[email protected]>
Date: Wed, 2 Nov 2022 20:48:08 +0800
Subject: [PATCH linux-next] net/mlx5: remove redundant ret variableSubject line should be "[PATCH net-next] ..." for all net patches. And please use git send-email utility to send the patches.
Thanks
Also this patch doesn't apply to net-next.