Skip to contentSkip to conversation

ice: use int for n_per_out loop

PATCH In review Jacob Keller 2 participants 2 messages Nov 2, 2022 – Nov 4, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ice: use int for n_per_out loop

In ice_ptp_enable_all_clkout and ice_ptp_disable_all_clkout we use a uint for a for loop iterating over the n_per_out value from the struct ptp_clock_info. The struct member is a signed int, and the use of uint generates a -Wsign-compare warning:

drivers/net/ethernet/intel/ice/ice_ptp.c: In function ‘ice_ptp_enable_all_clkout’:
drivers/net/ethernet/intel/ice/ice_ptp.c:1710:23: error: comparison of integer expressions of different signedness: ‘uint’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare]
1710 | for (i = 0; i < pf->ptp.info.n_per_out; i++)
| ^
cc1: all warnings being treated as errors

While we don't generally compile with -Wsign-compare, its still a good idea not to mix types. Fix the two functions to use a plain signed integer.

Fixes 9ee313433c48 ("ice: restart periodic outputs around time changes")
---
 drivers/net/ethernet/intel/ice/ice_ptp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ice/ice_ptp.c +2 -2
index 011b727ab190..be147fb641ae 100644
@@ -1688,7 +1688,7 @@ static int ice_ptp_cfg_clkout(struct ice_pf *pf, unsigned int chan,
  */
 static void ice_ptp_disable_all_clkout(struct ice_pf *pf)
 {
-	uint i;
+	int i;
 
 	for (i = 0; i < pf->ptp.info.n_per_out; i++)
 		if (pf->ptp.perout_channels[i].ena)
@@ -1705,7 +1705,7 @@ static void ice_ptp_disable_all_clkout(struct ice_pf *pf)
  */
 static void ice_ptp_enable_all_clkout(struct ice_pf *pf)
 {
-	uint i;
+	int i;
 
 	for (i = 0; i < pf->ptp.info.n_per_out; i++)
 		if (pf->ptp.perout_channels[i].ena)

base-commit: c70e8985365ba84d8d668a27a45c21d1fc26f818

Signature · 6 lines
2.38.0.83.gd420dda05763

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Tested-by on v1 1/1
#1 lore raw
Quoted 23 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Jacob Keller
Sent: Thursday, November 3, 2022 5:30 AM
To: Intel Wired LAN <[email protected]>
Subject: [Intel-wired-lan] [PATCH net] ice: use int for n_per_out loop

In ice_ptp_enable_all_clkout and ice_ptp_disable_all_clkout we use a uint for a for loop iterating over the n_per_out value from the struct ptp_clock_info. The struct member is a signed int, and the use of uint generates a -Wsign-compare warning:

drivers/net/ethernet/intel/ice/ice_ptp.c: In function
‘ice_ptp_enable_all_clkout’:
drivers/net/ethernet/intel/ice/ice_ptp.c:1710:23: error: comparison of
integer expressions of different signedness: ‘uint’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare]
1710 | for (i = 0; i < pf->ptp.info.n_per_out; i++)
| ^
cc1: all warnings being treated as errors

Quoted 9 lines

While we don't generally compile with -Wsign-compare, its still a good idea not to mix types. Fix the two functions to use a plain signed integer.

Fixes 9ee313433c48 ("ice: restart periodic outputs around time changes")
---
 drivers/net/ethernet/intel/ice/ice_ptp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan