Skip to contentSkip to conversation

arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name

PATCH In review Rafał Miłecki 2 participants 3 messages Nov 3, 2022 – Nov 9, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name

From: Rafał Miłecki <[email protected]>

String "nand" was never a valid interrupt name. It was never documented and never used in Linux or U-Boot driver. This mistake was propagated from the bcm63138.dtsi.

The whole "interrupt-names" property is optional and can be skipped.

Fixes 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")
---
 arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi +0 -1
index dac9d3b4e91d..ba1d44e98c32 100644
@@ -532,7 +532,6 @@ nand-controller@1800 {
 			reg = <0x1800 0x600>, <0x2000 0x10>;
 			reg-names = "nand", "nand-int-base";
 			interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
-			interrupt-names = "nand";
 			status = "okay";
 
 			nandcs: nand@0 {
Signature · 1 line
2.34.1
#1 lore raw
Quoted 10 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

String "nand" was never a valid interrupt name. It was never documented and never used in Linux or U-Boot driver. This mistake was propagated from the bcm63138.dtsi.

The whole "interrupt-names" property is optional and can be skipped.

Fixes 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")

Do you still want me to apply this patch, or are we happy with renaming that interrupt to "nand_ctlrdy" instead?

Signature · 1 line
Florian
#2 lore raw
Quoted 7 lines · Florian Fainelli
Quoted 6 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

String "nand" was never a valid interrupt name. It was never documented and never used in Linux or U-Boot driver. This mistake was propagated from the bcm63138.dtsi.

Quoted 6 lines
Quoted 4 lines

The whole "interrupt-names" property is optional and can be skipped.

Fixes 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")

Do you still want me to apply this patch, or are we happy with renaming that interrupt to "nand_ctlrdy" instead?

I don't have any real preference.

Since we already have this patch, we may just apply it. If you think having "interrupt-names" with just "nand_ctlrdy" is cleaner, I can send V2.