Skip to contentSkip to conversation

net/i40e: fix PCTYPE configuration for X722

PATCH Applied Mingjin Ye 3 participants 3 messages Nov 3, 2022 – Nov 9, 2022 Network drivers

lore
Share & tools
lore

Mingjin Ye

author
#0 lore raw

PATCH 1/1 net/i40e: fix PCTYPE configuration for X722

To make X722's PCTYPE is compatible with X710, the PCTYPE in the FD programming descriptor is translated into different types by using GLQF_FD_PCTYPE table. But the types of 'UNICAST_IPV4_UDP' and 'MULTICAST_IPV4_UDP' are only supported for X722, so that the corresponding registers can not be configured after translation.

This patch removes the transition before the FD filter is programmed.

Fixes ef4c16fd9148 ("net/i40e: refactor RSS flow")
---
 drivers/net/i40e/i40e_hash.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/net/i40e/i40e_hash.c +0 -4
index a1ff85fceb..0c84818977 100644
@@ -659,10 +659,6 @@ i40e_hash_config_pctype_symmetric(struct i40e_hw *hw,
 	struct i40e_pf *pf = &((struct i40e_adapter *)hw->back)->pf;
 	uint32_t reg;
 
-	/* For X722, get translated pctype in fd pctype register */
-	if (hw->mac.type == I40E_MAC_X722)
-		pctype = i40e_read_rx_ctl(hw, I40E_GLQF_FD_PCTYPES(pctype));
-
 	reg = i40e_read_rx_ctl(hw, I40E_GLQF_HSYM(pctype));
 	if (symmetric) {
 		if (reg & I40E_GLQF_HSYM_SYMH_ENA_MASK)
Signature · 1 line
2.34.1
Tested-by on v1 1/1
#1 lore raw
Quoted 17 lines

-----Original Message-----
From: Mingjin Ye <[email protected]>
Sent: Friday, November 4, 2022 12:57 AM
To: [email protected]
Cc: [email protected]; Zhou, YidingX <[email protected]>; Ye, MingjinX <[email protected]>; Zhang, Yuying <[email protected]>; Xing, Beilei <[email protected]>; Alvin Zhang <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: [PATCH] net/i40e: fix PCTYPE configuration for X722

To make X722's PCTYPE is compatible with X710, the PCTYPE in the FD programming descriptor is translated into different types by using GLQF_FD_PCTYPE table. But the types of 'UNICAST_IPV4_UDP' and 'MULTICAST_IPV4_UDP' are only supported for X722, so that the corresponding registers can not be configured after translation.

Quoted 7 lines

This patch removes the transition before the FD filter is programmed.

Fixes ef4c16fd9148 ("net/i40e: refactor RSS flow")

---

Applied
#2 lore raw
Quoted 31 lines

-----Original Message-----
From: Chen, LingliX <[email protected]>
Sent: Wednesday, November 9, 2022 9:36 AM
To: [email protected]
Cc: [email protected]; Zhou, YidingX <[email protected]>; Ye, MingjinX <[email protected]>; Zhang, Yuying <[email protected]>; Xing, Beilei <[email protected]>; Alvin Zhang <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: RE: [PATCH] net/i40e: fix PCTYPE configuration for X722

Quoted 18 lines

-----Original Message-----
From: Mingjin Ye <[email protected]>
Sent: Friday, November 4, 2022 12:57 AM
To: [email protected]
Cc: [email protected]; Zhou, YidingX <[email protected]>; Ye, MingjinX <[email protected]>; Zhang, Yuying <[email protected]>; Xing, Beilei <[email protected]>; Alvin Zhang <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: [PATCH] net/i40e: fix PCTYPE configuration for X722

To make X722's PCTYPE is compatible with X710, the PCTYPE in the FD programming descriptor is translated into different types by using GLQF_FD_PCTYPE table. But the types of 'UNICAST_IPV4_UDP' and 'MULTICAST_IPV4_UDP' are only supported for X722, so that the corresponding registers can not be configured after translation.

This patch removes the transition before the FD filter is programmed.

Quoted 7 lines
Quoted 5 lines
Fixes ef4c16fd9148 ("net/i40e: refactor RSS flow")

---

Applied to dpdk-next-net-intel.

Thanks
Qi