Skip to contentSkip to conversation

Initial SDM670 and Pixel 3a support

PATCH Superseded Richard Acayan 2 participants 8 messages Nov 3, 2022 – Nov 4, 2022

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover Initial SDM670 and Pixel 3a support

Changes since v1:
- remove i2c interconnects (4/4)
- change regulator phandle names (4/4)
- change regulators node names (4/4)
- remove clock-output-names from xo-board (4/4)
- remove vdd-supply from touchscreen (4/4)
- move clocks to device dts (4/4)
- reorder pmic nodes, root nodes, and phandle references in dts (4/4)
- move status properties to bottom of nodes (4/4)
- accumulate commit message tags (1-3/4)

Do not apply this series yet. It is only for review comments. It can be applied once the "qcom,sdm670-smmu-500" compatible string gets added (or now if you don't care about handling an unnecessary quirk).

This adds the device trees and bindings to support the Qualcomm Snapdragon 670 and Google Pixel 3a. This patch series, specifically the last patch, depends on:

[PATCH v4 0/3] SDM670 Global Clocks
https://lore.kernel.org/all/[email protected]/T/
[PATCH v2 0/2] RPMh Support for PM660 and PM660L
https://lore.kernel.org/all/[email protected]/T/
[PATCH v2 0/2] SDM670 RPMh Clocks
https://lore.kernel.org/all/[email protected]/T/
[PATCH v2 0/2] SDM670 USB 2.0 support
https://lore.kernel.org/all/[email protected]/T/
[PATCH 0/2] SDM670 SDHCI support
https://lore.kernel.org/all/[email protected]/T/
[PATCH v2 0/2] SDM670 Power Domains
https://lore.kernel.org/all/[email protected]/T/
[PATCH v10 0/3] SDM670 Pin Control Driver
https://lore.kernel.org/all/[email protected]/T/
[PATCH v6 0/4] SDM670 GPI DMA support
https://lore.kernel.org/all/[email protected]/T/
[RFC PATCH 0/9] iommy/arm-smmu-qcom: Rework Qualcomm SMMU bindings and implementation
https://lore.kernel.org/linux-iommu/[email protected]/T/

Richard Acayan (4):
dt-bindings: arm: cpus: add qcom kryo 360 compatible
dt-bindings: arm: qcom: add sdm670 and pixel 3a compatible
dt-bindings: firmware: scm: add sdm670 compatible
arm64: dts: qcom: add sdm670 and pixel 3a device trees

 .../devicetree/bindings/arm/cpus.yaml         |    1 +
 .../devicetree/bindings/arm/qcom.yaml         |    6 +
 .../bindings/firmware/qcom,scm.yaml           |    1 +
 arch/arm64/boot/dts/qcom/Makefile             |    1 +
 .../boot/dts/qcom/sdm670-google-sargo.dts     |  532 ++++++++
 arch/arm64/boot/dts/qcom/sdm670.dtsi          | 1169 +++++++++++++++++
 6 files changed, 1710 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sdm670.dtsi

P.S.: Thank you to all the maintainers and reviewers who went through everything and made helpful comments!

Signature · 1 line
2.38.1
#1 lore raw

PATCH v2 1/4 dt-bindings: arm: cpus: add qcom kryo 360 compatible

The Snapdragon 670 uses CPUs named Kryo 360 silver and Kryo 360 gold. Add the compatible string in the documentation.

---
 Documentation/devicetree/bindings/arm/cpus.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/cpus.yaml +1 -0
index 5c13b73e4d57..1247e9a975c9 100644
@@ -178,6 +178,7 @@ properties:
       - qcom,kryo250
       - qcom,kryo260
       - qcom,kryo280
+      - qcom,kryo360
       - qcom,kryo385
       - qcom,kryo468
       - qcom,kryo485
Signature · 1 line
2.38.1
#2 lore raw

PATCH v2 2/4 dt-bindings: arm: qcom: add sdm670 and pixel 3a compatible

In reply to Richard Acayan

The Snapdragon 670 and Pixel 3a initial device trees are about to be added. Add the compatible strings for the board.

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +6 -0
index 207e28260206..f9eddc22d4a4 100644
@@ -51,6 +51,7 @@ description: |
         sdm632
         sdm636
         sdm660
+        sdm670
         sdm845
         sdx55
         sdx65
@@ -654,6 +655,11 @@ properties:
               - xiaomi,lavender
           - const: qcom,sdm660
 
+      - items:
+          - enum:
+              - google,sargo
+          - const: qcom,sdm670
+
       - items:
           - enum:
               - qcom,sdx55-mtp
Signature · 1 line
2.38.1
#3 lore raw

PATCH v2 3/4 dt-bindings: firmware: scm: add sdm670 compatible

In reply to Richard Acayan

The Snapdragon 670 uses SCM as for PSCI power management. Document the appropriate compatible string for it.

---
 Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/firmware/qcom,scm.yaml +1 -0
index be1b5746eddb..25688571ee7c 100644
@@ -41,6 +41,7 @@ properties:
           - qcom,scm-sc7180
           - qcom,scm-sc7280
           - qcom,scm-sc8280xp
+          - qcom,scm-sdm670
           - qcom,scm-sdm845
           - qcom,scm-sdx55
           - qcom,scm-sdx65
Signature · 1 line
2.38.1
#4 lore raw

Re: [PATCH v2 3/4] dt-bindings: firmware: scm: add sdm670 compatible

Quoted 2 lines · Richard Acayan

The Snapdragon 670 uses SCM as for PSCI power management. Document the appropriate compatible string for it.

SCM and SMC (and SMCCC) are closely related but not the same.

SMC (secure monitor call) is the standard mechanism of invoking communication

with TZ.

SCM (secure channel manager) is a QC mechanism of communicating with their

vast vast vast HYP and TZ implementations, using HVC (hypervisor call) and SMC

respectively.

SMCCC (secure monitor call calling convention) is a standard for how to structure

SMCs and HVCs.

PSCI uses SMC calls on sdm670.

Konrad

Quoted 20 lines
---
  Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
  1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/firmware/qcom,scm.yaml +1 -0
index be1b5746eddb..25688571ee7c 100644
@@ -41,6 +41,7 @@ properties:
            - qcom,scm-sc7180
            - qcom,scm-sc7280
            - qcom,scm-sc8280xp
+          - qcom,scm-sdm670
            - qcom,scm-sdm845
            - qcom,scm-sdx55
            - qcom,scm-sdx65
#5 lore raw

PATCH v2 4/4 arm64: dts: qcom: add sdm670 and pixel 3a device trees

In reply to Richard Acayan

The Qualcomm Snapdragon 670 has been out for a while. Add a device tree for it and the Google Pixel 3a as the first device.

The Pixel 3a has the same bootloader issue as the Pixel 3 and will not work on Android 10 bootloaders or later until it gets fixed for the Pixel 3.

SoC Initial Features:
- power management
- clocks
- pinctrl
- eMMC
- USB 2.0
- GENI I2C
- IOMMU
- RPMh
- interrupts

Device-Specific Initial Features:
- side buttons (keys)
- regulators
- touchscreen

---
 arch/arm64/boot/dts/qcom/Makefile             |    1 +
 .../boot/dts/qcom/sdm670-google-sargo.dts     |  532 ++++++++
 arch/arm64/boot/dts/qcom/sdm670.dtsi          | 1169 +++++++++++++++++
 3 files changed, 1702 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sdm670.dtsi
arch/arm64/boot/dts/qcom/Makefile +1 -0
index b0558d3389e5..4eb5d8829efb 100644
@@ -124,6 +124,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sdm630-sony-xperia-nile-voyager.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm632-fairphone-fp3.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm636-sony-xperia-ganges-mermaid.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm660-xiaomi-lavender.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= sdm670-google-sargo.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm845-cheza-r1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm845-cheza-r2.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sdm845-cheza-r3.dtb
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts new file +532 -0

532 lines not on this page · raw message

arch/arm64/boot/dts/qcom/sdm670.dtsi new file +1169 -0

1,169 lines not on this page · raw message

Signature · 1 line
2.38.1
#6 lore raw

Re: [PATCH v2 4/4] arm64: dts: qcom: add sdm670 and pixel 3a device trees

Quoted 85 lines · Richard Acayan

The Qualcomm Snapdragon 670 has been out for a while. Add a device tree for it and the Google Pixel 3a as the first device.

The Pixel 3a has the same bootloader issue as the Pixel 3 and will not work on Android 10 bootloaders or later until it gets fixed for the Pixel 3.

SoC Initial Features:
- power management
- clocks
- pinctrl
- eMMC
- USB 2.0
- GENI I2C
- IOMMU
- RPMh
- interrupts

Device-Specific Initial Features:
- side buttons (keys)
- regulators
- touchscreen

---
  arch/arm64/boot/dts/qcom/Makefile             |    1 +
  .../boot/dts/qcom/sdm670-google-sargo.dts     |  532 ++++++++
  arch/arm64/boot/dts/qcom/sdm670.dtsi          | 1169 +++++++++++++++++
  3 files changed, 1702 insertions(+)

create mode 100644 arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts create mode 100644 arch/arm64/boot/dts/qcom/sdm670.dtsi

arch/arm64/boot/dts/qcom/Makefile +1 -0
index b0558d3389e5..4eb5d8829efb 100644
@@ -124,6 +124,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sdm630-sony-xperia-nile-voyager.dtb
  dtb-$(CONFIG_ARCH_QCOM)	+= sdm632-fairphone-fp3.dtb
  dtb-$(CONFIG_ARCH_QCOM)	+= sdm636-sony-xperia-ganges-mermaid.dtb
  dtb-$(CONFIG_ARCH_QCOM)	+= sdm660-xiaomi-lavender.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= sdm670-google-sargo.dtb
  dtb-$(CONFIG_ARCH_QCOM)	+= sdm845-cheza-r1.dtb
  dtb-$(CONFIG_ARCH_QCOM)	+= sdm845-cheza-r2.dtb
  dtb-$(CONFIG_ARCH_QCOM)	+= sdm845-cheza-r3.dtb
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts new file +36 -0
new file mode 100644
index 000000000000..3a01859dd42c
@@ -0,0 +1,532 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Device tree for Google Pixel 3a, adapted from google-blueline device tree,
+ * xiaomi-lavender device tree, and oneplus-common device tree.
+ *
+ * Copyright (c) 2022, Richard Acayan. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
+#include <dt-bindings/power/qcom-rpmpd.h>
+#include "sdm670.dtsi"
+#include "pm660.dtsi"
+#include "pm660l.dtsi"
+
+/delete-node/ &mpss_region;
+/delete-node/ &venus_mem;
+/delete-node/ &wlan_msa_mem;
+/delete-node/ &cdsp_mem;
+/delete-node/ &mba_region;
+/delete-node/ &adsp_mem;
+/delete-node/ &ipa_fw_mem;
+/delete-node/ &ipa_gsi_mem;
+/delete-node/ &gpu_mem;
+
+/ {
+	model = "Google Pixel 3a";
+	compatible = "google,sargo", "qcom,sdm670";
+	qcom,board-id = <0x00041e05 0>;
+	qcom,msm-id = <321 0x20001>;
+
+	aliases { };
+

arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts line 46

Quoted 10 lines
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts new file +10 -0
+	chosen {
+		stdout-path = "serial0:115200n8";
+
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		framebuffer@9c000000 {
+			compatible = "simple-framebuffer";
+			reg = <0x0 0x9c000000 0x0 (1080 * 2220 * 4)>;

Please use '0x0' and '0' consistently in reg properties.

Quoted 7 lines
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts new file +7 -0
+			width = <1080>;
+			height = <2220>;
+			stride = <(1080 * 4)>;
+			format = "a8r8g8b8";
+		};
+	};
+

[...]

arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts line 420

Quoted 11 lines
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts new file +10 -0
+
+&i2c9 {
+	clock-frequency = <100000>;
+	status = "okay";
+
+	synaptics-rmi4-i2c@20 {
+		compatible = "syna,rmi4-i2c";
+		reg = <0x20>;
+		#address-cells = <0x1>;
+		#size-cells = <0x0>;

#-cells properties should have decimal values.

[...]

Quoted 15 lines
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts new file +1 -0
+};
arch/arm64/boot/dts/qcom/sdm670.dtsi new file +8 -0
new file mode 100644
index 000000000000..cbebe29ca6f8
@@ -0,0 +1,1169 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * SDM670 SoC device tree source, adapted from SDM845 SoC device tree
+ *
+ * Copyright (c) 2018, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022, Richard Acayan. All rights reserved.
+ */
+

[...]

Quoted 11 lines
arch/arm64/boot/dts/qcom/sdm670.dtsi new file +11 -0
+
+		gpi_dma0: dma-controller@800000 {
+			#dma-cells = <3>;
+			compatible = "qcom,sdm670-gpi-dma", "qcom,sdm845-gpi-dma";
+			reg = <0 0x00800000 0 0x60000>;
+			interrupts = <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 245 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 248 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 249 IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/qcom/sdm670.dtsi line 454

Quoted 10 lines
arch/arm64/boot/dts/qcom/sdm670.dtsi new file +10 -0
+				     <GIC_SPI 250 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 251 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 252 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 253 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 254 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 255 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>;
+			dma-channels = <13>;
+			dma-channel-mask = <0xfa>;
+			iommus = <&apps_smmu 0x0016 0x0>;

&apps_smmu 0x16 0x0

[...]

arch/arm64/boot/dts/qcom/sdm670.dtsi line 1165

Quoted 10 lines
arch/arm64/boot/dts/qcom/sdm670.dtsi new file +10 -0
+
+		intc: interrupt-controller@17a00000 {
+			compatible = "arm,gic-v3";
+			#address-cells = <2>;
+			#size-cells = <2>;
+			ranges;
+			#interrupt-cells = <3>;
+			interrupt-controller;
+			reg = <0 0x17a00000 0 0x10000>,     /* GICD */
+			      <0 0x17a60000 0 0x100000>;    /* GICR * 8 */

reg second, #cells and ranges last, please.

Other than that, lgtm

Konrad

Quoted 4 lines
arch/arm64/boot/dts/qcom/sdm670.dtsi new file +4 -0
+			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
+		};
+	};
+};
#7 lore raw

Re: [PATCH v2 4/4] arm64: dts: qcom: add sdm670 and pixel 3a device trees

Quoted 90 lines · Konrad Dybcio
Quoted 89 lines · Richard Acayan

The Qualcomm Snapdragon 670 has been out for a while. Add a device tree for it and the Google Pixel 3a as the first device.

The Pixel 3a has the same bootloader issue as the Pixel 3 and will not work on Android 10 bootloaders or later until it gets fixed for the Pixel 3.

SoC Initial Features:
- power management
- clocks
- pinctrl
- eMMC
- USB 2.0
- GENI I2C
- IOMMU
- RPMh
- interrupts

Device-Specific Initial Features:
- side buttons (keys)
- regulators
- touchscreen

---
  arch/arm64/boot/dts/qcom/Makefile             |    1 +
  .../boot/dts/qcom/sdm670-google-sargo.dts     |  532 ++++++++
  arch/arm64/boot/dts/qcom/sdm670.dtsi          | 1169 +++++++++++++++++
  3 files changed, 1702 insertions(+)

create mode 100644 arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts create mode 100644 arch/arm64/boot/dts/qcom/sdm670.dtsi

arch/arm64/boot/dts/qcom/Makefile +1 -0
index b0558d3389e5..4eb5d8829efb 100644
@@ -124,6 +124,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sdm630-sony-xperia-nile-voyager.dtb
  dtb-$(CONFIG_ARCH_QCOM)	+= sdm632-fairphone-fp3.dtb
  dtb-$(CONFIG_ARCH_QCOM)	+= sdm636-sony-xperia-ganges-mermaid.dtb
  dtb-$(CONFIG_ARCH_QCOM)	+= sdm660-xiaomi-lavender.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= sdm670-google-sargo.dtb
  dtb-$(CONFIG_ARCH_QCOM)	+= sdm845-cheza-r1.dtb
  dtb-$(CONFIG_ARCH_QCOM)	+= sdm845-cheza-r2.dtb
  dtb-$(CONFIG_ARCH_QCOM)	+= sdm845-cheza-r3.dtb
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts new file +40 -0
new file mode 100644
index 000000000000..3a01859dd42c
@@ -0,0 +1,532 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Device tree for Google Pixel 3a, adapted from google-blueline device tree,
+ * xiaomi-lavender device tree, and oneplus-common device tree.
+ *
+ * Copyright (c) 2022, Richard Acayan. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
+#include <dt-bindings/power/qcom-rpmpd.h>
+#include "sdm670.dtsi"
+#include "pm660.dtsi"
+#include "pm660l.dtsi"
+
+/delete-node/ &mpss_region;
+/delete-node/ &venus_mem;
+/delete-node/ &wlan_msa_mem;
+/delete-node/ &cdsp_mem;
+/delete-node/ &mba_region;
+/delete-node/ &adsp_mem;
+/delete-node/ &ipa_fw_mem;
+/delete-node/ &ipa_gsi_mem;
+/delete-node/ &gpu_mem;
+
+/ {
+	model = "Google Pixel 3a";
+	compatible = "google,sargo", "qcom,sdm670";
+	qcom,board-id = <0x00041e05 0>;
+	qcom,msm-id = <321 0x20001>;
+
+	aliases { };
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+
+		#address-cells = <2>;
Quoted 8 lines

arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts line 46

Quoted 6 lines
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts new file +6 -0
+		#size-cells = <2>;
+		ranges;
+
+		framebuffer@9c000000 {
+			compatible = "simple-framebuffer";
+			reg = <0x0 0x9c000000 0x0 (1080 * 2220 * 4)>;

Please use '0x0' and '0' consistently in reg properties.

Will also do this in aop_cmd_db_mem because grep works, but not in cpus because the sm6350 has <0x0 0x0> in cpus and <0x0 0x80000000 0x0 0x0> in memory. The sdm670 dtsi has <0 0x80000000 0 0>, maybe I should change that according to other dtsi's already in the kernel.

Quoted 76 lines
Quoted 9 lines
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts new file +7 -0
+			width = <1080>;
+			height = <2220>;
+			stride = <(1080 * 4)>;
+			format = "a8r8g8b8";
+		};
+	};
+

[...]

arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts line 420

Quoted 11 lines
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts new file +10 -0
+
+&i2c9 {
+	clock-frequency = <100000>;
+	status = "okay";
+
+	synaptics-rmi4-i2c@20 {
+		compatible = "syna,rmi4-i2c";
+		reg = <0x20>;
+		#address-cells = <0x1>;
+		#size-cells = <0x0>;

#-cells properties should have decimal values.

[...]

Quoted 15 lines
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts new file +1 -0
+};
arch/arm64/boot/dts/qcom/sdm670.dtsi new file +8 -0
new file mode 100644
index 000000000000..cbebe29ca6f8
@@ -0,0 +1,1169 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * SDM670 SoC device tree source, adapted from SDM845 SoC device tree
+ *
+ * Copyright (c) 2018, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022, Richard Acayan. All rights reserved.
+ */
+

[...]

Quoted 11 lines
arch/arm64/boot/dts/qcom/sdm670.dtsi new file +11 -0
+
+		gpi_dma0: dma-controller@800000 {
+			#dma-cells = <3>;
+			compatible = "qcom,sdm670-gpi-dma", "qcom,sdm845-gpi-dma";
+			reg = <0 0x00800000 0 0x60000>;
+			interrupts = <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 245 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 248 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 249 IRQ_TYPE_LEVEL_HIGH>,

arch/arm64/boot/dts/qcom/sdm670.dtsi line 454

Quoted 10 lines
arch/arm64/boot/dts/qcom/sdm670.dtsi new file +10 -0
+				     <GIC_SPI 250 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 251 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 252 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 253 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 254 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 255 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>;
+			dma-channels = <13>;
+			dma-channel-mask = <0xfa>;
+			iommus = <&apps_smmu 0x0016 0x0>;

&apps_smmu 0x16 0x0

[...]

Quoted 12 lines

arch/arm64/boot/dts/qcom/sdm670.dtsi line 1165

Quoted 10 lines
arch/arm64/boot/dts/qcom/sdm670.dtsi new file +10 -0
+
+		intc: interrupt-controller@17a00000 {
+			compatible = "arm,gic-v3";
+			#address-cells = <2>;
+			#size-cells = <2>;
+			ranges;
+			#interrupt-cells = <3>;
+			interrupt-controller;
+			reg = <0 0x17a00000 0 0x10000>,     /* GICD */
+			      <0 0x17a60000 0 0x100000>;    /* GICR * 8 */

reg second, #cells and ranges last, please.

I'll also move the label property down in apps_rsc and move the #cells down in touchscreen.

Quoted 11 lines

Other than that, lgtm

Konrad

Quoted 4 lines
arch/arm64/boot/dts/qcom/sdm670.dtsi new file +4 -0
+			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
+		};
+	};
+};