Skip to contentSkip to conversation

net: ethernet: Simplify bool conversion

PATCH Superseded Yang Li 3 participants 3 messages Nov 4, 2022

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH v2 1/1 net: ethernet: Simplify bool conversion

The result of 'scaled_ppm < 0' is Boolean, and the question mark expression is redundant, remove it to clear the below warning:

./drivers/net/ethernet/renesas/rcar_gen4_ptp.c:32:40-45: WARNING: conversion to bool not needed here

---

change in v2:
--According to Bagas's suggestion, describe what this patch does to fix this warning.

 drivers/net/ethernet/renesas/rcar_gen4_ptp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/renesas/rcar_gen4_ptp.c +1 -1
index c007e33c47e1..37f7359678e5 100644
@@ -29,7 +29,7 @@ static const struct rcar_gen4_ptp_reg_offset s4_offs = {
 static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm)
 {
 	struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp);
-	bool neg_adj = scaled_ppm < 0 ? true : false;
+	bool neg_adj = scaled_ppm < 0;
 	s64 addend = ptp_priv->default_addend;
 	s64 diff;
 
Signature · 1 line
2.20.1.7.g153144c
#1 lore raw

drivers/net/ethernet/renesas/rcar_gen4_ptp.c static const struct rcar_gen4_ptp_reg_offset s4_offs = { · line 34

Quoted 12 lines · Yang Li
drivers/net/ethernet/renesas/rcar_gen4_ptp.c +1 -1
index c007e33c47e1..37f7359678e5 100644
@@ -29,7 +29,7 @@ static const struct rcar_gen4_ptp_reg_offset s4_offs = {
 static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm)
 {
 	struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp);
-	bool neg_adj = scaled_ppm < 0 ? true : false;
+	bool neg_adj = scaled_ppm < 0;
 	s64 addend = ptp_priv->default_addend;
 	s64 diff;

Please preserve reverse Christmas tree order.

Thanks,
Richard

#2 lore raw
In reply to Yang Li
Quoted 5 lines · Yang Li

The result of 'scaled_ppm < 0' is Boolean, and the question mark expression is redundant, remove it to clear the below warning:

./drivers/net/ethernet/renesas/rcar_gen4_ptp.c:32:40-45: WARNING: conversion to bool not needed here

Quoted 7 lines

---

change in v2:
--According to Bagas's suggestion, describe what this patch does to fix this warning.

The Subject line is too generic. It is a good idea to run git log on the file you are changing and see how it is generally referred to:

b48b89f9c189 net: drop the weight argument from netif_napi_add 0140a7168f8b Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
6a1dbfefdae4 net: sh_eth: Fix PHY state warning splat during system resume 4924c0cdce75 net: ravb: Fix PHY state warning splat during system resume 1089877ada8d ravb: Add RZ/G2L MII interface support
949f252a8594 net: ravb: Add R-Car Gen4 support
e1154be73153 ravb: Add support for RZ/V2M
72069a7b2821 ravb: Use separate clock for gPTP
b0265dcba3d6 ravb: Support separate Line0 (Desc), Line1 (Err) and Line2 (Mgmt) irqs cb99badde146 ravb: Separate handling of irq enable/disable regs into feature 91398a960edf ravb: Use GFP_KERNEL instead of GFP_ATOMIC when possible 9a90986efcff sh_eth: kill useless initializers in sh_eth_{suspend|resume}() e7d966f9ea52 sh_eth: sh_eth_close() always returns 0
be94a51f3e5e ravb: ravb_close() always returns 0

Without something specific like ravb, you won't get the right people noticing the patch.

Andrew