Skip to contentSkip to conversation

mhi: pci_generic: add support for sc8280xp-crd SDX55 variant

PATCH In review Johan Hovold 2 participants 3 messages Nov 4, 2022 – Nov 7, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mhi: pci_generic: add support for sc8280xp-crd SDX55 variant

The SC8280XP Compute Reference Design (CRD) has an on-PCB SDX55 modem which uses MBIM.

The exact channel configuration is not known but the Foxconn SDX55 configuration allows the modem to be used so reuse that one for now.

---

Changes in v2
- drop comment describing this variant (Mani)

 drivers/bus/mhi/host/pci_generic.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/bus/mhi/host/pci_generic.c +2 -0
index caa4ce28cf9e..7dcd0ef3184a 100644
@@ -542,6 +542,8 @@ static const struct mhi_pci_dev_info mhi_telit_fn990_info = {
 static const struct pci_device_id mhi_pci_id_table[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0304),
 		.driver_data = (kernel_ulong_t) &mhi_qcom_sdx24_info },
+	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, PCI_VENDOR_ID_QCOM, 0x010c),
+		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
 	/* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */
 	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),
 		.driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info },
Signature · 1 line
2.37.3
maintainer Reviewed-by on v2 1/1
#1 lore raw
Quoted 7 lines · Johan Hovold

The SC8280XP Compute Reference Design (CRD) has an on-PCB SDX55 modem which uses MBIM.

The exact channel configuration is not known but the Foxconn SDX55 configuration allows the modem to be used so reuse that one for now.

Thanks,
Mani

Quoted 26 lines

---

Changes in v2
- drop comment describing this variant (Mani)

 drivers/bus/mhi/host/pci_generic.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/bus/mhi/host/pci_generic.c +2 -0
index caa4ce28cf9e..7dcd0ef3184a 100644
@@ -542,6 +542,8 @@ static const struct mhi_pci_dev_info mhi_telit_fn990_info = {
 static const struct pci_device_id mhi_pci_id_table[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0304),
 		.driver_data = (kernel_ulong_t) &mhi_qcom_sdx24_info },
+	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, PCI_VENDOR_ID_QCOM, 0x010c),
+		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
 	/* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */
 	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),
 		.driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info },
Signature · 1 line
2.37.3
Signature · 1 line
மணிவண்ணன் சதாசிவம்
#2 lore raw
In reply to Johan Hovold
Quoted 7 lines · Johan Hovold

The SC8280XP Compute Reference Design (CRD) has an on-PCB SDX55 modem which uses MBIM.

The exact channel configuration is not known but the Foxconn SDX55 configuration allows the modem to be used so reuse that one for now.

Modified the subject to the format "bus: mhi: host: pci_generic" and applied to mhi-next!

Thanks,
Mani

Quoted 26 lines

---

Changes in v2
- drop comment describing this variant (Mani)

 drivers/bus/mhi/host/pci_generic.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/bus/mhi/host/pci_generic.c +2 -0
index caa4ce28cf9e..7dcd0ef3184a 100644
@@ -542,6 +542,8 @@ static const struct mhi_pci_dev_info mhi_telit_fn990_info = {
 static const struct pci_device_id mhi_pci_id_table[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0304),
 		.driver_data = (kernel_ulong_t) &mhi_qcom_sdx24_info },
+	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, PCI_VENDOR_ID_QCOM, 0x010c),
+		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
 	/* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */
 	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200),
 		.driver_data = (kernel_ulong_t) &mhi_sierra_em919x_info },
Signature · 1 line
2.37.3
Signature · 1 line
மணிவண்ணன் சதாசிவம்