crypto/ipsec-mb: fix qp setup for secondary process
PATCH 1/1 crypto/ipsec-mb: fix qp setup for secondary process
If a secondary process is using a queue pair that has been setup by the primary process, we need to reset mb_mgr pointers.
This commit removes an error return in this case, allowing secondary to do the remaining setup for the existing qp.
--- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 --- 1 file changed, 3 deletions(-)
drivers/crypto/ipsec_mb/ipsec_mb_ops.c +0 -3
@@ -273,9 +273,6 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,return ipsec_mb_secondary_qp_op (dev->data->dev_id, qp_id, qp_conf, socket_id,RTE_IPSEC_MB_MP_REQ_QP_SET ); } - -IPSEC_MB_LOG (ERR ,"Queue pair already setup'ed." ); -return -EINVAL ; }else {/* Free memory prior to re-allocation if needed. */ if (dev->data->queue_pairs[qp_id] !=NULL )
Signature · 1 line
2.25.1
Quoted 42 lines
-----Original Message-----
From: Power, Ciara <[email protected]>
Sent: Friday, November 4, 2022 9:43 AM
To: Ji, Kai <[email protected]>; De Lara Guarch, Pablo <[email protected]>
Cc: [email protected]; [email protected]; Power, Ciara <[email protected]>
Subject: [PATCH]crypto/ipsec-mb: fix qp setup for secondary processIf a secondary process is using a queue pair that has been setup by the primary process, we need to reset
mb_mgrpointers.
This commit removes an error return in this case, allowing secondary to do the remaining setup for the existing qp.Fixes b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler")Signed-off-by Ciara Power <[email protected]>--- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 --- 1 file changed, 3 deletions(-)drivers/crypto/ipsec_mb/ipsec_mb_ops.c +0
-3@@ -273,9 +273,6 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, return ipsec_mb_secondary_qp_op(dev->data->dev_id, qp_id, qp_conf, socket_id,RTE_IPSEC_MB_MP_REQ_QP_SET ); } - -IPSEC_MB_LOG (ERR ,"Queue pair already setup'ed." ); -return -EINVAL ;drivers/crypto/ipsec_mb/ipsec_mb_ops.c +0
-1}else {/* Free memory prior to re-allocation if needed. */ if (dev->data->queue_pairs[qp_id] !=NULL ) --2.25.1
Akhil Goyal
AppliedQuoted 13 lines
Acked-by Kai Ji <[email protected]>Quoted 8 lines
Subject: [PATCH]
crypto/ipsec-mb: fix qp setup for secondary processIf a secondary process is using a queue pair that has been setup by the primary process, we need to reset
mb_mgrpointers.
This commit removes an error return in this case, allowing secondary to do the remaining setup for the existing qp.Fixes b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC requesthandler")
Quoted 3 lines
Signed-off-by Ciara Power <[email protected]>
Applied to dpdk-next-crypto
Thanks.