Skip to contentSkip to conversation

ath9k: Remove unused variable mismatch

PATCH In review Colin Ian King 4 participants 4 messages Nov 4, 2022 – Nov 9, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath9k: Remove unused variable mismatch

Variable mismatch is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.

---
 drivers/net/wireless/ath/ath9k/ar9003_mci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/wireless/ath/ath9k/ar9003_mci.c +1 -2
index 9899661f9a60..8d7efd80d97a 100644
@@ -585,7 +585,7 @@ static u32 ar9003_mci_wait_for_gpm(struct ath_hw *ah, u8 gpm_type,
 {
 	struct ath_common *common = ath9k_hw_common(ah);
 	struct ath9k_hw_mci *mci = &ah->btcoex_hw.mci;
-	u32 *p_gpm = NULL, mismatch = 0, more_data;
+	u32 *p_gpm = NULL, more_data;
 	u32 offset;
 	u8 recv_type = 0, recv_opcode = 0;
 	bool b_is_bt_cal_done = (gpm_type == MCI_GPM_BT_CAL_DONE);
@@ -656,7 +656,6 @@ static u32 ar9003_mci_wait_for_gpm(struct ath_hw *ah, u8 gpm_type,
 		} else {
 			ath_dbg(common, MCI, "MCI GPM subtype not match 0x%x\n",
 				*(p_gpm + 1));
-			mismatch++;
 			ar9003_mci_process_gpm_extra(ah, recv_type,
 						     recv_opcode, p_gpm);
 		}
Signature · 1 line
2.38.1
maintainer
#1 lore raw
Quoted 4 lines · On Fri, 4 Nov 2022 14:07:23 +0000 Colin Ian King wrote:

Variable mismatch is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.

Good sir, you don't have to CC netdev on wireless patches. Especially trivial ones. I'm saying this because you're a major contributor and I presume you send patches based on some scripted integration with get_maintainer so I hope this could nudge you to improve get_maintainer itself? :)

Perhaps any entry which has a tree specified should mask off entries higher up?

#3 lore raw
In reply to Colin Ian King
Quoted 6 lines · Colin Ian King

Variable mismatch is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it.

Patch applied to ath-next branch of ath.git, thanks.

dc45398446be wifi: ath9k: Remove unused variable mismatch

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches