Skip to contentSkip to conversation

soc: apple: sart: Stop casting function pointer signatures

PATCH Applied Sven Peter 2 participants 2 messages Nov 4, 2022 – Nov 28, 2022 Arm/Apple machine support

lore
Share & tools
lore

Sven Peter

author
#0 lore raw

PATCH 1/1 soc: apple: sart: Stop casting function pointer signatures

Fixes b170143ae111 ("soc: apple: Add SART driver")
---
 drivers/soc/apple/sart.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/soc/apple/sart.c +6 -1
index 83804b16ad03..afa111736899 100644
@@ -164,6 +164,11 @@ static int apple_sart_probe(struct platform_device *pdev)
 	return 0;
 }
 
+static void apple_sart_put_device(void *dev)
+{
+	put_device(dev);
+}
+
 struct apple_sart *devm_apple_sart_get(struct device *dev)
 {
 	struct device_node *sart_node;
@@ -187,7 +192,7 @@ struct apple_sart *devm_apple_sart_get(struct device *dev)
 		return ERR_PTR(-EPROBE_DEFER);
 	}
 
-	ret = devm_add_action_or_reset(dev, (void (*)(void *))put_device,
+	ret = devm_add_action_or_reset(dev, apple_sart_put_device,
 				       &sart_pdev->dev);
 	if (ret)
 		return ERR_PTR(ret);
Signature · 1 line
2.25.1
#1 lore raw
Quoted 24 lines · Sven Peter
Fixes b170143ae111 ("soc: apple: Add SART driver")
---
 drivers/soc/apple/sart.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/soc/apple/sart.c +5 -0
index 83804b16ad03..afa111736899 100644
@@ -164,6 +164,11 @@ static int apple_sart_probe(struct platform_device *pdev)
 	return 0;
 }
 
+static void apple_sart_put_device(void *dev)
+{
+	put_device(dev);
+}
+
 struct apple_sart *devm_apple_sart_get(struct device *dev)
 {
 	struct device_node *sart_node;

drivers/soc/apple/sart.c struct apple_sart *devm_apple_sart_get(struct device *dev) · line 198

Quoted 8 lines
drivers/soc/apple/sart.c +1 -1
@@ -187,7 +192,7 @@ struct apple_sart *devm_apple_sart_get(struct device *dev)
 		return ERR_PTR(-EPROBE_DEFER);
 	}
 
-	ret = devm_add_action_or_reset(dev, (void (*)(void *))put_device,
+	ret = devm_add_action_or_reset(dev, apple_sart_put_device,
 				       &sart_pdev->dev);
 	if (ret)
 		return ERR_PTR(ret);

Applied to asahi-soc/soc, thanks!

- Hector