Skip to contentSkip to conversation

configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR

PATCH New Tim Harvey 2 participants 2 messages Nov 4, 2022 – Nov 8, 2022 Arm i.MX and Layerscape

lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/1 configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR

The IMX8M based Venice boards all have device-tree fec nodes that use proper dt with a phy-handle pointing to a phy with reg assigned to the proper phy address.

There is no need to keep using the CONFIG_FEC_MXC_PHYADDR hack when a proper dt is used - remove it.

This was previously done in commit 400eebf10d9b
("configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR") but got clobbered by commit 6889412ad5e7
("Convert CONFIG_SYS_BARGSIZE to Kconfig")

---
 include/configs/imx8mm_venice.h | 4 ----
 include/configs/imx8mn_venice.h | 4 ----
 2 files changed, 8 deletions(-)
include/configs/imx8mm_venice.h +0 -4
index 44c6bc331dc7..6ecc3477f1b6 100644
@@ -82,8 +82,4 @@
 #define PHYS_SDRAM                      0x40000000
 #define PHYS_SDRAM_SIZE			SZ_4G
 
-/* FEC */
-#define CONFIG_FEC_MXC_PHYADDR          0
-#define FEC_QUIRK_ENET_MAC
-
 #endif
include/configs/imx8mn_venice.h +0 -4
index 6694820e76e5..4266eb076029 100644
@@ -76,8 +76,4 @@
 #define PHYS_SDRAM                      0x40000000
 #define PHYS_SDRAM_SIZE			SZ_4G
 
-/* FEC */
-#define CONFIG_FEC_MXC_PHYADDR          0
-#define FEC_QUIRK_ENET_MAC
-
 #endif
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR

Quoted 10 lines

The IMX8M based Venice boards all have device-tree fec nodes that use proper dt with a phy-handle pointing to a phy with reg assigned to the proper phy address.
There is no need to keep using the CONFIG_FEC_MXC_PHYADDR hack when a proper dt is used - remove it.
This was previously done in commit 400eebf10d9b
("configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR") but got clobbered by commit 6889412ad5e7
("Convert CONFIG_SYS_BARGSIZE to Kconfig")

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================