Skip to contentSkip to conversation

Makefile: unexport PERL_MM_OPT

PATCH Applied Gleb Mazovetskiy 2 participants 2 messages Nov 6, 2022 – Nov 7, 2022 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: unexport PERL_MM_OPT

Compilation of Perl-related packages fails if PERL_MM_OPT is defined.

We previously issued an error in this case.
Instead, simply unexport the variable.

---
 Makefile                             | 3 +++
 support/dependencies/dependencies.sh | 9 ---------
 2 files changed, 3 insertions(+), 9 deletions(-)
Makefile +3 -0
index 7c1c07a2e4..71b622474f 100644
@@ -396,6 +396,9 @@ unexport DESTDIR
 # Causes breakage with packages that needs host-ruby
 unexport RUBYOPT
 
+# Compilation of perl-related packages will fail otherwise
+unexport PERL_MM_OPT
+
 include package/pkg-utils.mk
 include package/doc-asciidoc.mk
 
support/dependencies/dependencies.sh +0 -9
index 2b678ae8c4..4b5012b807 100755
@@ -46,15 +46,6 @@ case ":${PATH:-unset}:" in
 	;;
 esac
 
-if test -n "$PERL_MM_OPT" ; then
-	echo
-	echo "You have PERL_MM_OPT defined because Perl local::lib"
-	echo "is installed on your system. Please unset this variable"
-	echo "before starting Buildroot, otherwise the compilation of"
-	echo "Perl related packages will fail"
-	exit 1
-fi
-
 check_prog_host()
 {
 	prog="$1"
Signature · 6 lines
2.37.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 10 lines · On Sun, 6 Nov 2022 14:26:34 +0000 Gleb Mazovetskiy <[email protected]> wrote:

Compilation of Perl-related packages fails if PERL_MM_OPT is defined.

We previously issued an error in this case.
Instead, simply unexport the variable.

---
 Makefile                             | 3 +++
 support/dependencies/dependencies.sh | 9 ---------
 2 files changed, 3 insertions(+), 9 deletions(-)

Applied to next, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot