Skip to contentSkip to conversation

arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt

PATCH Applied Chen-Yu Tsai 3 participants 3 messages Nov 6, 2022 – Nov 15, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt

From: Chen-Yu Tsai <[email protected]>

Ths PMIC's interrupt line is tied to GPIO0_A3. This is described correctly for the pinmux setting, but incorrectly for the interrupt.

Correct the interrupt setting so that interrupts from the PMIC get delivered.

Fixes dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")
---
 arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts +1 -1
index 77b179cd20e7..b276eb0810c7 100644
@@ -246,7 +246,7 @@ rk809: pmic@20 {
 		compatible = "rockchip,rk809";
 		reg = <0x20>;
 		interrupt-parent = <&gpio0>;
-		interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
+		interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
 		assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
 		assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
 		clock-names = "mclk";
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Chen-Yu Tsai

From: Chen-Yu Tsai <[email protected]>

Ths PMIC's interrupt line is tied to GPIO0_A3. This is described correctly for the pinmux setting, but incorrectly for the interrupt.

Correct the interrupt setting so that interrupts from the PMIC get delivered.

Fixes dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")

Good catch, thanks!

Quoted 25 lines
---
 arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts +1 -2
index 77b179cd20e7..b276eb0810c7 100644
@@ -246,7 +246,7 @@ rk809: pmic@20 {
                compatible = "rockchip,rk809";
                reg = <0x20>;
                interrupt-parent = <&gpio0>;
-               interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
+               interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
                assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
                assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
                clock-names = "mclk";
--

2.34.1

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

maintainer Applied
#2 lore raw
In reply to Chen-Yu Tsai
Quoted 9 lines · Chen-Yu Tsai

From: Chen-Yu Tsai <[email protected]>

Ths PMIC's interrupt line is tied to GPIO0_A3. This is described correctly for the pinmux setting, but incorrectly for the interrupt.

Correct the interrupt setting so that interrupts from the PMIC get delivered.

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt

      commit: 562105c1b072411c71ac2202410d83ee79297624

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>