arm64: dts: qcom: hk10: use "okay" instead of "ok"

PATCH Applied Robert Marko 4 participants 11 messages Nov 7, 2022 – Nov 8, 2022

Subsystems (3)

Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support

lore

Share & tools

lore

Robert Marko

author

2022-11-07 09:29 UTC #0 lore raw

PATCH 1/3 arm64: dts: qcom: hk10: use "okay" instead of "ok"

Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.

Signed-off-by Robert Marko <[email protected]>

---
 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +8 -8

index db4b87944cdf..262b937e0bc6 100644
@@ -22,7 +22,7 @@ memory {
 };
 
 &blsp1_spi1 {
-	status = "ok";
+	status = "okay";
 
 	flash@0 {
 		#address-cells = <1>;

@@ -34,33 +34,33 @@ flash@0 {
 };
 
 &blsp1_uart5 {
-	status = "ok";
+	status = "okay";
 };
 
 &pcie0 {
-	status = "ok";
+	status = "okay";
 	perst-gpios = <&tlmm 58 0x1>;
 };
 
 &pcie1 {
-	status = "ok";
+	status = "okay";
 	perst-gpios = <&tlmm 61 0x1>;
 };
 
 &pcie_phy0 {
-	status = "ok";
+	status = "okay";
 };
 
 &pcie_phy1 {
-	status = "ok";
+	status = "okay";
 };
 
 &qpic_bam {
-	status = "ok";
+	status = "okay";
 };
 
 &qpic_nand {
-	status = "ok";
+	status = "okay";
 
 	nand@0 {
 		reg = <0>;

Signature · 1 line

2.38.1

Robert Marko

author

2022-11-07 09:29 UTC #1 lore raw

PATCH 2/3 arm64: dts: qcom: hk10: use GPIO flags for tlmm

Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of harcoding the cell value.

Signed-off-by Robert Marko <[email protected]>

---
 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +3 -2

index 262b937e0bc6..651a231554e0 100644
@@ -5,6 +5,7 @@
 /dts-v1/;
 
 #include "ipq8074.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	aliases {

@@ -39,12 +40,12 @@ &blsp1_uart5 {
 
 &pcie0 {
 	status = "okay";
-	perst-gpios = <&tlmm 58 0x1>;
+	perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
 };
 
 &pcie1 {
 	status = "okay";
-	perst-gpios = <&tlmm 61 0x1>;
+	perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
 };
 
 &pcie_phy0 {

Signature · 1 line

2.38.1

Konrad Dybcio

Reviewed-by on v1 2/3

2022-11-07 09:58 UTC #2 lore raw

Re: [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm

Quoted 5 lines · Robert Marko

Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of harcoding the cell value.
Signed-off-by Robert Marko <[email protected]>
---

Reviewed-by Konrad Dybcio <[email protected]>

KOnrad

Quoted 30 lines

  arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +3 -2

index 262b937e0bc6..651a231554e0 100644
@@ -5,6 +5,7 @@
  /dts-v1/;
 
  #include "ipq8074.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
  / {
  	aliases {

@@ -39,12 +40,12 @@ &blsp1_uart5 {
 
  &pcie0 {
  	status = "okay";
-	perst-gpios = <&tlmm 58 0x1>;
+	perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
  };
 
  &pcie1 {
  	status = "okay";
-	perst-gpios = <&tlmm 61 0x1>;
+	perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
  };
 
  &pcie_phy0 {

Konrad Dybcio

Reviewed-by on v1 2/3

2022-11-07 09:58 UTC #3 lore raw

Re: [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm

In reply to Robert Marko

Quoted 5 lines · Robert Marko

Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of harcoding the cell value.
Signed-off-by Robert Marko <[email protected]>
---

Reviewed-by Konrad Dybcio <[email protected]>

Konrad

Quoted 30 lines

  arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +3 -2

index 262b937e0bc6..651a231554e0 100644
@@ -5,6 +5,7 @@
  /dts-v1/;
 
  #include "ipq8074.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
  / {
  	aliases {

@@ -39,12 +40,12 @@ &blsp1_uart5 {
 
  &pcie0 {
  	status = "okay";
-	perst-gpios = <&tlmm 58 0x1>;
+	perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
  };
 
  &pcie1 {
  	status = "okay";
-	perst-gpios = <&tlmm 61 0x1>;
+	perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
  };
 
  &pcie_phy0 {

Krzysztof Kozlowski

Reviewed-by on v1 2/3

2022-11-07 10:31 UTC #4 lore raw

Re: [PATCH 2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm

In reply to Robert Marko

Quoted 4 lines · Robert Marko

Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of harcoding the cell value.
Signed-off-by Robert Marko <[email protected]>

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Robert Marko

author

2022-11-07 09:29 UTC #5 lore raw

PATCH 3/3 arm64: dts: qcom: hk01: use GPIO flags for tlmm

In reply to Robert Marko

Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of harcoding the cell value.

Signed-off-by Robert Marko <[email protected]>

---
 arch/arm64/boot/dts/qcom/ipq8074-hk01.dts | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

arch/arm64/boot/dts/qcom/ipq8074-hk01.dts +3 -2

index b60b2d4c2ea5..c3f3f78271e9 100644
@@ -4,6 +4,7 @@
  */
 #include "ipq8074.dtsi"
 #include "pmp8074.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "Qualcomm Technologies, Inc. IPQ8074-HK01";

@@ -52,12 +53,12 @@ &blsp1_uart5 {
 
 &pcie0 {
 	status = "okay";
-	perst-gpios = <&tlmm 61 0x1>;
+	perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
 };
 
 &pcie1 {
 	status = "okay";
-	perst-gpios = <&tlmm 58 0x1>;
+	perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
 };
 
 &pcie_phy0 {

Signature · 1 line

2.38.1

Konrad Dybcio

Reviewed-by on v1 3/3

2022-11-07 09:59 UTC #6 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: hk01: use GPIO flags for tlmm

Quoted 5 lines · Robert Marko

Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of harcoding the cell value.
Signed-off-by Robert Marko <[email protected]>
---

Reviewed-by Konrad Dybcio <[email protected]>

Konrad

Quoted 30 lines

  arch/arm64/boot/dts/qcom/ipq8074-hk01.dts | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

arch/arm64/boot/dts/qcom/ipq8074-hk01.dts +3 -2

index b60b2d4c2ea5..c3f3f78271e9 100644
@@ -4,6 +4,7 @@
   */
  #include "ipq8074.dtsi"
  #include "pmp8074.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
  / {
  	model = "Qualcomm Technologies, Inc. IPQ8074-HK01";

@@ -52,12 +53,12 @@ &blsp1_uart5 {
 
  &pcie0 {
  	status = "okay";
-	perst-gpios = <&tlmm 61 0x1>;
+	perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
  };
 
  &pcie1 {
  	status = "okay";
-	perst-gpios = <&tlmm 58 0x1>;
+	perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
  };
 
  &pcie_phy0 {

Krzysztof Kozlowski

Reviewed-by on v1 3/3

2022-11-07 10:32 UTC #7 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: hk01: use GPIO flags for tlmm

In reply to Robert Marko

Quoted 5 lines · Robert Marko

Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of harcoding the cell value.
Signed-off-by Robert Marko <[email protected]>
---

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Konrad Dybcio

Reviewed-by on v1 1/3

2022-11-07 09:53 UTC #8 lore raw

In reply to Robert Marko

Quoted 4 lines · Robert Marko

Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.
Signed-off-by Robert Marko <[email protected]>
---

Reviewed-by Konrad Dybcio <[email protected]>

Konrad

Quoted 57 lines

  arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 16 ++++++++--------
  1 file changed, 8 insertions(+), 8 deletions(-)

arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +8 -8

index db4b87944cdf..262b937e0bc6 100644
@@ -22,7 +22,7 @@ memory {
  };
 
  &blsp1_spi1 {
-	status = "ok";
+	status = "okay";
 
  	flash@0 {
  		#address-cells = <1>;

@@ -34,33 +34,33 @@ flash@0 {
  };
 
  &blsp1_uart5 {
-	status = "ok";
+	status = "okay";
  };
 
  &pcie0 {
-	status = "ok";
+	status = "okay";
  	perst-gpios = <&tlmm 58 0x1>;
  };
 
  &pcie1 {
-	status = "ok";
+	status = "okay";
  	perst-gpios = <&tlmm 61 0x1>;
  };
 
  &pcie_phy0 {
-	status = "ok";
+	status = "okay";
  };
 
  &pcie_phy1 {
-	status = "ok";
+	status = "okay";
  };
 
  &qpic_bam {
-	status = "ok";
+	status = "okay";
  };
 
  &qpic_nand {
-	status = "ok";
+	status = "okay";
 
  	nand@0 {
  		reg = <0>;

Krzysztof Kozlowski

Reviewed-by on v1 1/3

2022-11-07 10:31 UTC #9 lore raw

In reply to Robert Marko

Quoted 6 lines · Robert Marko

Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.
Signed-off-by Robert Marko <[email protected]>
---
 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Bjorn Andersson

maintainer Applied

2022-11-08 01:29 UTC #10 lore raw

Re: (subset) [PATCH 1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok"

In reply to Robert Marko

Quoted 3 lines · Robert Marko

Use "okay" instead of "ok" in USB nodes as "ok" is deprecated.

Applied, thanks!

[1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok"

      commit: 7284a3943909606016128b79fb18dd107bc0fe26
[2/3] arm64: dts: qcom: hk10: use GPIO flags for tlmm
      commit: 3f49bdaf6f84959bb8fc3ed5add7983907491240
[3/3] arm64: dts: qcom: hk01: use GPIO flags for tlmm
      commit: 1bc6b7f26bc72c8fd5a49ff000bb76a234e75e11

Best regards,

Signature · 1 line

Bjorn Andersson <[email protected]>