Skip to contentSkip to conversation

mirrors.bbclass: use shallow tarball for nativesdk-binutils

PATCH In review Etienne Cordonnier 2 participants 3 messages Nov 7, 2022 – Nov 14, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mirrors.bbclass: use shallow tarball for nativesdk-binutils

This is useful e.g. when using meta-clang, which introduces a dependency to nativesdk-binutils when populating the SDK, and then a full tarball of binutils is fetched additionally to a shallow tarball.

---
 meta/classes-global/mirrors.bbclass | 2 ++
 1 file changed, 2 insertions(+)
meta/classes-global/mirrors.bbclass +2 -0
index 81fef7f660..8b984de3bf 100644
@@ -91,6 +91,8 @@ BB_GIT_SHALLOW:pn-binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} = "1"
 BB_GIT_SHALLOW:pn-binutils-cross-testsuite = "1"
 BB_GIT_SHALLOW:pn-binutils-crosssdk-${SDK_SYS} = "1"
 BB_GIT_SHALLOW:pn-binutils-native = "1"
+BB_GIT_SHALLOW:pn-nativesdk-binutils = "1"
+
 BB_GIT_SHALLOW:pn-glibc = "1"
 PREMIRRORS += "git://sourceware.org/git/glibc.git https://downloads.yoctoproject.org/mirror/sources/ \
               git://sourceware.org/git/binutils-gdb.git https://downloads.yoctoproject.org/mirror/sources/"
Signature · 1 line
2.36.1.vfs.0.0
#1 lore raw

Hi Etienne

Many thanks for the patch!

Quoted 4 lines · Etienne Cordonnier via lists.openembedded.org

This is useful e.g. when using meta-clang, which introduces a dependency to nativesdk-binutils when populating the SDK, and then a full tarball of binutils is fetched additionally to a shallow tarball.

However, there's a problem with the way your patches are received on the Yocto Project mailing lists though. I used to have it too.

If I apply your patch through "git am", the author of the commit will be:
Etienne Cordonnier via lists.openembedded.org <[email protected]> instead of
Etienne Cordonnier <[email protected]>

That's because of the configuration of the Yocto Project mailing lists, if I understood correctly.

Because of this issue, the maintainer has to manually fix this field when accepting your patch. Worse, if he doesn't catch this, that's harder to fix afterwards.

You should be able to fix this by running:
git config --global sendemail.from "[email protected]"

This should add a "From" field to the sent patch which "git am" should be able to match with your name.
At least this worked for me. See https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Sending_using_git-send-email

Could you try to send an update (don't hesitate to send a private one to me first)?

Thanks in advance
Michael.

Signature · 3 lines
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

Hi Michael,
thanks for your reply and sorry about the wrong email. I changed the configuration and added "sendemail.from" (I had used sendemail.envelopesender previously). However this patch is already applied to the master branch, so I didn't send an updated patch.

Quoted 50 lines · Michael Opdenacker

Hi Etienne

Many thanks for the patch!

Quoted 1 line · Etienne Cordonnier via lists.openembedded.org

This is useful e.g. when using meta-clang, which introduces a dependency

to nativesdk-binutils when

Quoted 1 line

populating the SDK, and then a full tarball of binutils is fetched

additionally to a shallow tarball.

Quoted 2 lines

However, there's a problem with the way your patches are received on the Yocto Project mailing lists though. I used to have it too.

If I apply your patch through "git am", the author of the commit will be:
Etienne Cordonnier via lists.openembedded.org <[email protected]>
instead of
Etienne Cordonnier <[email protected]>

That's because of the configuration of the Yocto Project mailing lists, if I understood correctly.

Because of this issue, the maintainer has to manually fix this field when accepting your patch. Worse, if he doesn't catch this, that's harder to fix afterwards.

You should be able to fix this by running:
git config --global sendemail.from "[email protected]"

This should add a "From" field to the sent patch which "git am" should be able to match with your name.
At least this worked for me. See

https://urldefense.proofpoint.com/v2/url?u=https-3A__www.openembedded.org_wiki_How-5Fto-5Fsubmit-5Fa-5Fpatch-5Fto-5FOpenEmbedded-23Sending-5Fusing-5Fgit-2Dsend-2Demail&d=DwICaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=OATWj9fV3DIgh3gSYx7h1yPhVJlnNDVyzQschgNMU_R_oANac6LSiRo7KudX_voS&s=u9CUuyjhy1CAiQqvOo0blFXDVHF2H69Kkre3Sm8ViaY&e=

Could you try to send an update (don't hesitate to send a private one to me first)?

Thanks in advance
Michael.

--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering

https://urldefense.proofpoint.com/v2/url?u=https-3A__bootlin.com&d=DwICaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=OATWj9fV3DIgh3gSYx7h1yPhVJlnNDVyzQschgNMU_R_oANac6LSiRo7KudX_voS&s=33HzPwa4N8A8AGPjlZNOGbTWftq-kFhbFm3OVBa0QXw&e=