net/mlx5/hws: fix possible action setter segmenation fault
PATCH 1/1 net/mlx5/hws: fix possible action setter segmenation fault
When the maximum action combination in RX is used we can get a segfault due to an incorrecrt max array size define. This bug can happen on RX/TX or FDB in the most complex cases.
Current max was set to 7, but actual max is:
Max TX: 8, Max RX: 10, Max FDB: 9
--- drivers/net/mlx5/hws/mlx5dr_action.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/hws/mlx5dr_action.h +1 -1
@@ -6,7 +6,7 @@#define MLX5DR_ACTION_H_ /* Max number of STEs needed for a rule (including match) */ -#define MLX5DR_ACTION_MAX_STE 7 +#define MLX5DR_ACTION_MAX_STE 10enum mlx5dr_action_stc_idx {MLX5DR_ACTION_STC_IDX_CTRL =0 ,
Signature · 1 line
2.18.1
PATCH 1/1 net/mlx5/hws: fix possible action setter segmenation fault
When the maximum action combination in RX is used we can get a segfault due to an incorrecrt max array size define. This bug can happen on RX/TX or FDB in the most complex cases.
Current max was set to 7, but actual max is:
Max TX: 8, Max RX: 10, Max FDB: 9
--- drivers/net/mlx5/hws/mlx5dr_action.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/hws/mlx5dr_action.h +1 -1
@@ -6,7 +6,7 @@#define MLX5DR_ACTION_H_ /* Max number of STEs needed for a rule (including match) */ -#define MLX5DR_ACTION_MAX_STE 7 +#define MLX5DR_ACTION_MAX_STE 10enum mlx5dr_action_stc_idx {MLX5DR_ACTION_STC_IDX_CTRL =0 ,
Signature · 1 line
2.18.1
PATCH v2 1/1 net/mlx5/hws: fix possible action setter segmenation fault
In reply to Alex VeskerWhen the maximum action combination in RX is used we can get a segfault due to an incorrecrt max array size define. This bug can happen on RX/TX or FDB in the most complex cases.
Current max was set to 7, but actual max is:
Max TX: 8, Max RX: 10, Max FDB: 9
--- drivers/net/mlx5/hws/mlx5dr_action.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/hws/mlx5dr_action.h +1 -1
@@ -6,7 +6,7 @@#define MLX5DR_ACTION_H_ /* Max number of STEs needed for a rule (including match) */ -#define MLX5DR_ACTION_MAX_STE 7 +#define MLX5DR_ACTION_MAX_STE 10enum mlx5dr_action_stc_idx {MLX5DR_ACTION_STC_IDX_CTRL =0 ,
Signature · 1 line
2.18.1
Hi,
Quoted 11 lines
-----Original Message-----
From: Alex Vesker <[email protected]>
Sent: Monday, November 7, 2022 12:18 PM
To: Alex Vesker <[email protected]>; Slava Ovsiienko <[email protected]>; NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Suanming Mou <[email protected]>; Matan Azrad <[email protected]>
Cc: [email protected]; Ori Kam <[email protected]>
Subject: [PATCH v2]net/mlx5/hws: fix possible action setter segmenation fault
Quoted 7 lines
When the maximum action combination in RX is used we can get a segfault due to an incorrecrt max array size define.
This bug can happen on RX/TX or FDB in the most complex cases. Current max was set to 7, but actual max is:
Max TX: 8, Max RX: 10, Max FDB: 9Fixes f8c8a6d ("net/mlx5/hws: add action object")
missing empty line - will handle during integration
Quoted 3 lines
Signed-off-by Alex Vesker <[email protected]>Reviewed-by Erez Shitrit <[email protected]>Acked-by Matan Azrad <[email protected]>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh