Skip to contentSkip to conversation

virtio-blk: set req->state to MQ_RQ_COMPLETE after polling I/O is finished

PATCH New Suwan Kim 1 participant 1 message Nov 7, 2022

Subsystems (3)
lore
Share & tools
lore

Suwan Kim

author
#0 lore raw

PATCH 1/1 virtio-blk: set req->state to MQ_RQ_COMPLETE after polling I/O is finished

Driver should set req->state to MQ_RQ_COMPLETE after it finishes to process req. But virtio-blk doesn't set MQ_RQ_COMPLETE after virtblk_poll() handles req and req->state still remains MQ_RQ_IN_FLIGHT. Fortunately so far there is no issue about it because blk_mq_end_request_batch() sets req->state to MQ_RQ_IDLE. This patch properly sets req->state after polling I/O is finished.

Fixes 4e0400525691 ("virtio-blk: support polling I/O")
---
 drivers/block/virtio_blk.c | 1 +
 1 file changed, 1 insertion(+)
drivers/block/virtio_blk.c +1 -0
index 19da5defd734..cf64d256787e 100644
@@ -839,6 +839,7 @@ static void virtblk_complete_batch(struct io_comp_batch *iob)
 	rq_list_for_each(&iob->req_list, req) {
 		virtblk_unmap_data(req, blk_mq_rq_to_pdu(req));
 		virtblk_cleanup_cmd(req);
+		blk_mq_set_request_complete(req);
 	}
 	blk_mq_end_request_batch(iob);
 }
Signature · 1 line
2.26.3