Skip to contentSkip to conversation

dt-bindings: serial: arm,sbsa-uart: Convert to json-schema

PATCH In review Thierry Reding 3 participants 3 messages Nov 4, 2022 – Nov 7, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: serial: arm,sbsa-uart: Convert to json-schema

From: Thierry Reding <[email protected]>

Convert the ARM SBSA UART device tree bindings from the free-form text format to json-schema.

---
 .../bindings/serial/arm,sbsa-uart.yaml        | 37 +++++++++++++++++++
 .../bindings/serial/arm_sbsa_uart.txt         | 10 -----
 2 files changed, 37 insertions(+), 10 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
 delete mode 100644 Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt
Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml new file +37 -0
new file mode 100644
index 000000000000..afaa1ef7f2e6
@@ -0,0 +1,37 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/serial/arm,sbsa-uart.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ARM SBSA defined generic UART
+
+maintainers:
+  - Rob Herring <[email protected]>
+  - Greg Kroah-Hartman <[email protected]>
+
+description:
+  This UART uses a subset of the PL011 registers and consequently lives
+  in the PL011 driver. It's baudrate and other communication parameters
+  cannot be adjusted at runtime, so it lacks a clock specifier here.
+
+properties:
+  compatible:
+    const: arm,sbsa-uart
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+allOf:
+  - $ref: serial.yaml
+
+unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+...
Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt deleted +0 -10
deleted file mode 100644
index 4163e7eb7763..000000000000
@@ -1,10 +0,0 @@
-* ARM SBSA defined generic UART
-This UART uses a subset of the PL011 registers and consequently lives
-in the PL011 driver. It's baudrate and other communication parameters
-cannot be adjusted at runtime, so it lacks a clock specifier here.
-
-Required properties:
-- compatible: must be "arm,sbsa-uart"
-- reg: exactly one register range
-- interrupts: exactly one interrupt specifier
-- current-speed: the (fixed) baud rate set by the firmware
Signature · 1 line
2.38.1
#1 lore raw
Quoted 20 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Convert the ARM SBSA UART device tree bindings from the free-form text format to json-schema.

---
 .../bindings/serial/arm,sbsa-uart.yaml        | 37 +++++++++++++++++++
 .../bindings/serial/arm_sbsa_uart.txt         | 10 -----
 2 files changed, 37 insertions(+), 10 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
 delete mode 100644 Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt
Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml new file +1 -0
new file mode 100644
index 000000000000..afaa1ef7f2e6
@@ -0,0 +1,37 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml line 11

Quoted 10 lines
Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml new file +10 -0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/serial/arm,sbsa-uart.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ARM SBSA defined generic UART
+
+maintainers:
+  - Rob Herring <[email protected]>
+  - Greg Kroah-Hartman <[email protected]>

This shouldn't be Greg but someone nothing the hardware. Rob might work, but maybe also Russell who is mentioned in maintainers entry?

Please resend with him cced.

Quoted 16 lines
Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml new file +16 -0
+
+description:
+  This UART uses a subset of the PL011 registers and consequently lives
+  in the PL011 driver. It's baudrate and other communication parameters
+  cannot be adjusted at runtime, so it lacks a clock specifier here.
+
+properties:
+  compatible:
+    const: arm,sbsa-uart
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+

Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml line 37

Quoted 10 lines
Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml new file +10 -0
+allOf:
+  - $ref: serial.yaml
+
+unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+...

Example would be nice, although it is not a requirement.

Best regards,
Krzysztof

maintainer
#2 lore raw
Quoted 6 lines · Krzysztof Kozlowski
Quoted 5 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Convert the ARM SBSA UART device tree bindings from the free-form text format to json-schema.

Quoted 7 lines
Quoted 7 lines
---
 .../bindings/serial/arm,sbsa-uart.yaml        | 37 +++++++++++++++++++
 .../bindings/serial/arm_sbsa_uart.txt         | 10 -----
 2 files changed, 37 insertions(+), 10 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml
 delete mode 100644 Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt

Note that NXP LS2160a has a warning with this. The warning is correct because both PL011 and SBSA UART is wrong IMO. The question is which one is it really. I would assume someone went with SBSA for some reason. The pl011 compatible should be ignored given 'arm,primecell' is missing.

Quoted 12 lines
Quoted 12 lines
Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml new file +6 -0
new file mode 100644
index 000000000000..afaa1ef7f2e6
@@ -0,0 +1,37 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/serial/arm,sbsa-uart.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
Quoted 8 lines

Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml line 11

Quoted 5 lines
Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml new file +5 -0
+title: ARM SBSA defined generic UART
+
+maintainers:
+  - Rob Herring <[email protected]>
+  - Greg Kroah-Hartman <[email protected]>

This shouldn't be Greg but someone nothing the hardware. Rob might work, but maybe also Russell who is mentioned in maintainers entry?

I'm fine with it given I already have pl011 binding.

Quoted 7 lines

Please resend with him cced.

Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml line 16

Quoted 5 lines
Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml new file +5 -0
+
+description:
+  This UART uses a subset of the PL011 registers and consequently lives
+  in the PL011 driver. It's baudrate and other communication parameters
+  cannot be adjusted at runtime, so it lacks a clock specifier here.

Differences to PL011 are relavent, but location of the (Linux) driver is not.

Quoted 29 lines
Quoted 11 lines
Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml new file +11 -0
+
+properties:
+  compatible:
+    const: arm,sbsa-uart
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+

Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml line 37

Quoted 10 lines
Documentation/devicetree/bindings/serial/arm,sbsa-uart.yaml new file +10 -0
+allOf:
+  - $ref: serial.yaml
+
+unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+...

Example would be nice, although it is not a requirement.

Best regards,
Krzysztof