Skip to contentSkip to conversation

baseband/acc100: fix for RC2

PATCH Applied Nicolas Chautru 3 participants 4 messages Nov 7, 2022 – Nov 8, 2022

lore
Share & tools
lore
#0 lore raw

cover baseband/acc100: fix for RC2

Bug introduced in 22.11. The change to padding can lead to reporting input size mismatch which is not a problem and should not be considered as an error.

Nicolas Chautru (1):
baseband/acc100: fix to input error related to padding

 drivers/baseband/acc/rte_acc100_pmd.c | 3 ---
 1 file changed, 3 deletions(-)
Signature · 1 line
2.37.1
#1 lore raw

PATCH 1/1 baseband/acc100: fix to input error related to padding

Previous commit includes some padding for some cases, which may cause input warning from the HW which should be safely ignored to avoid false alarm.

Fixes 6f3325bbfa ("baseband/acc100: add LDPC encoder padding function")
---
 drivers/baseband/acc/rte_acc100_pmd.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/baseband/acc/rte_acc100_pmd.c +0 -3
index 96daef87bc..ba8247d47e 100644
@@ -3779,7 +3779,6 @@ dequeue_enc_one_op_cb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
 	/* Clearing status, it will be set based on response */
 	op->status = 0;
 
-	op->status |= ((rsp.input_err) ? (1 << RTE_BBDEV_DATA_ERROR) : 0);
 	op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
 	op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
 
@@ -3853,8 +3852,6 @@ dequeue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
 		rte_bbdev_log_debug("Resp. desc %p: %x descs %d cbs %d\n",
 				desc, rsp.val, descs_in_tb, desc->req.numCBs);
 
-		op->status |= ((rsp.input_err)
-				? (1 << RTE_BBDEV_DATA_ERROR) : 0);
 		op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
 		op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
 
Signature · 1 line
2.37.1
Applied
#2 lore raw

RE: [EXT] [PATCH v1 1/1] baseband/acc100: fix to input error related to padding

Quoted 7 lines

Previous commit includes some padding for some cases, which may cause input warning from the HW which should be safely ignored to avoid false alarm.

Fixes 6f3325bbfa ("baseband/acc100: add LDPC encoder padding function")

Applied to dpdk-next-crypto.

Reviewed-by on v1 1/1
#3 lore raw

Re: [PATCH v1 1/1] baseband/acc100: fix to input error related to padding

In reply to Nicolas Chautru
Quoted 24 lines · Nicolas Chautru

Previous commit includes some padding for some cases, which may cause input warning from the HW which should be safely ignored to avoid false alarm.

Fixes 6f3325bbfa ("baseband/acc100: add LDPC encoder padding function")
---
  drivers/baseband/acc/rte_acc100_pmd.c | 3 ---
  1 file changed, 3 deletions(-)
drivers/baseband/acc/rte_acc100_pmd.c +0 -1
index 96daef87bc..ba8247d47e 100644
@@ -3779,7 +3779,6 @@ dequeue_enc_one_op_cb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
  	/* Clearing status, it will be set based on response */
  	op->status = 0;
 
-	op->status |= ((rsp.input_err) ? (1 << RTE_BBDEV_DATA_ERROR) : 0);
  	op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
  	op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
 

drivers/baseband/acc/rte_acc100_pmd.c dequeue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op, · line 3857

Quoted 8 lines
drivers/baseband/acc/rte_acc100_pmd.c +0 -2
@@ -3853,8 +3852,6 @@ dequeue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
  		rte_bbdev_log_debug("Resp. desc %p: %x descs %d cbs %d\n",
  				desc, rsp.val, descs_in_tb, desc->req.numCBs);
 
-		op->status |= ((rsp.input_err)
-				? (1 << RTE_BBDEV_DATA_ERROR) : 0);
  		op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
  		op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
 

Thanks,
Maxime