Skip to contentSkip to conversation

i915/gvt: remove hardcoded value on crc32_start calculation

PATCH In review Paulo Miguel Almeida 3 participants 4 messages Oct 30, 2022 – Nov 8, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i915/gvt: remove hardcoded value on crc32_start calculation

struct gvt_firmware_header has a crc32 member in which all members that come after the that field are used to calculate it. The previous implementation added the value '4' (crc32's u32 size) to calculate the crc32_start offset which came across as a bit cryptic until you take a deeper look at the struct.

This patch changes crc32_start offset to the 'version' member which is the first member of the struct gvt_firmware_header after crc32.

It's worth mentioning that doing a build before/after this patch results in no binary output differences.

---
 drivers/gpu/drm/i915/gvt/firmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gvt/firmware.c +1 -1
index 54fe442238c6..a683c22d5b64 100644
@@ -104,7 +104,7 @@ static int expose_firmware_sysfs(struct intel_gvt *gvt)
 
 	memcpy(p, gvt->firmware.mmio, info->mmio_size);
 
-	crc32_start = offsetof(struct gvt_firmware_header, crc32) + 4;
+	crc32_start = offsetof(struct gvt_firmware_header, version);
 	h->crc32 = crc32_le(0, firmware + crc32_start, size - crc32_start);
 
 	firmware_attr.size = size;
Signature · 1 line
2.25.4
#1 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for i915/gvt: remove hardcoded value on crc32_start calculation

== Series Details ==

== Series Details ==

Series: i915/gvt: remove hardcoded value on crc32_start calculation
URL : https://patchwork.freedesktop.org/series/110310/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12322 -> Patchwork_110310v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/index.html

Participating hosts (38 -> 39)
------------------------------

Additional (2): fi-cfl-8700k fi-elk-e7500
Missing (1): fi-rkl-11600

Known issues
------------

Here are the changes found in Patchwork_110310v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_huc_copy@huc-copy:
- fi-cfl-8700k: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/fi-cfl-8700k/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- fi-cfl-8700k: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/fi-cfl-8700k/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-elk-e7500: NOTRUN -> [SKIP][3] ([fdo#109271]) +20 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/fi-elk-e7500/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-icl-u2: NOTRUN -> [INCOMPLETE][4] ([i915#4890])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/fi-icl-u2/igt@i915_selftest@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- bat-adlp-4: NOTRUN -> [SKIP][5] ([fdo#111827])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/bat-adlp-4/igt@[email protected]

* igt@kms_chamelium@dp-hpd-fast:
- fi-cfl-8700k: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827]) +8 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/fi-cfl-8700k/igt@[email protected]

* igt@kms_chamelium@hdmi-edid-read:
- fi-elk-e7500: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/fi-elk-e7500/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-cfl-8700k: NOTRUN -> [SKIP][8] ([fdo#109271]) +10 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/fi-cfl-8700k/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-adlp-4: NOTRUN -> [SKIP][9] ([i915#3546])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/bat-adlp-4/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3@smem:
- {bat-rplp-1}: [DMESG-WARN][10] ([i915#2867]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/bat-rplp-1/igt@gem_exec_suspend@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/bat-rplp-1/igt@gem_exec_suspend@[email protected]

* igt@gem_tiled_blits@basic:
- fi-pnv-d510: [SKIP][12] ([fdo#109271]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/fi-pnv-d510/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/fi-pnv-d510/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- {bat-rpls-2}: [DMESG-WARN][14] ([i915#5537]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/bat-rpls-2/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/bat-rpls-2/igt@[email protected]

* igt@i915_selftest@live@gt_lrc:
- fi-icl-u2: [DMESG-FAIL][16] ([i915#4890]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/fi-icl-u2/igt@i915_selftest@live@gt_lrc.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/fi-icl-u2/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@migrate:
- bat-adlp-4: [INCOMPLETE][18] ([i915#7308] / [i915#7348]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/bat-adlp-4/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/bat-adlp-4/igt@i915_selftest@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-hdmi-a-2:
- fi-bdw-5557u: [INCOMPLETE][20] ([i915#146]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/fi-bdw-5557u/igt@kms_pipe_crc_basic@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/fi-bdw-5557u/igt@kms_pipe_crc_basic@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4890]: https://gitlab.freedesktop.org/drm/intel/issues/4890
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7308]: https://gitlab.freedesktop.org/drm/intel/issues/7308
[i915#7348]: https://gitlab.freedesktop.org/drm/intel/issues/7348

Build changes
-------------

* Linux: CI_DRM_12322 -> Patchwork_110310v1

CI-20190529: 20190529
CI_DRM_12322: 7509583d5279ae70fb08f4fec9823c0be6452701 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7031: 54abd9445f732b55556d4e612d24f50803515904 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110310v1: 7509583d5279ae70fb08f4fec9823c0be6452701 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

e838b25ea395 i915/gvt: remove hardcoded value on crc32_start calculation

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/index.html

#2 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915/gvt: remove hardcoded value on crc32_start calculation

In reply to Paulo Miguel Almeida
== Series Details ==

== Series Details ==

Series: i915/gvt: remove hardcoded value on crc32_start calculation
URL : https://patchwork.freedesktop.org/series/110310/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12322_full -> Patchwork_110310v1_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_110310v1_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_110310v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (11 -> 11)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_110310v1_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_universal_plane@universal-plane-pipe-c-sanity:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-tglb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-tglb8/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_110310v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][3] ([i915#4991])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl8/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-apl: NOTRUN -> [FAIL][4] ([i915#2846])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl6/igt@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2842])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-glk6/igt@gem_exec_fair@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-glk6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: NOTRUN -> [FAIL][7] ([i915#2842]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-glk9/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@basic:
- shard-skl: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4613]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-skl6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][9] ([i915#4613])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb5/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random:
- shard-apl: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl8/igt@[email protected]

* igt@gem_workarounds@suspend-resume-fd:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([i915#7299])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-skl6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-skl1/igt@[email protected]

* igt@gen9_exec_parse@bb-oversize:
- shard-iclb: NOTRUN -> [SKIP][13] ([i915#2856])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb5/igt@[email protected]

* igt@gen9_exec_parse@secure-batches:
- shard-tglb: NOTRUN -> [SKIP][14] ([i915#2527] / [i915#2856])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-tglb7/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- shard-tglb: [PASS][15] -> [DMESG-WARN][16] ([i915#5591])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-tglb5/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-tglb2/igt@i915_selftest@[email protected]

* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-glk: NOTRUN -> [SKIP][17] ([fdo#109271]) +38 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-glk9/igt@[email protected]

* igt@kms_big_fb@linear-8bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][18] ([fdo#111614])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-tglb7/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-tglb: [PASS][19] -> [FAIL][20] ([i915#3743])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-tglb1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-tglb6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html

* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3886]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl8/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][22] ([fdo#109278])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb5/igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#3886]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-glk9/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3886]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-skl4/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_chamelium@dp-audio-edid:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl8/igt@[email protected]

* igt@kms_chamelium@dp-hpd-fast:
- shard-iclb: NOTRUN -> [SKIP][26] ([fdo#109284] / [fdo#111827])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb5/igt@[email protected]

* igt@kms_chamelium@hdmi-cmp-planar-formats:
- shard-tglb: NOTRUN -> [SKIP][27] ([fdo#109284] / [fdo#111827])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-tglb7/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827]) +10 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-skl1/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-glk: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-glk9/igt@[email protected]

* igt@kms_content_protection@srm@pipe-a-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][30] ([i915#7121] / [i915#7173])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl8/igt@kms_content_protection@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][31] -> [INCOMPLETE][32] ([i915#180])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-apl8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl6/igt@[email protected]

* igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#109274])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb5/igt@[email protected]

* igt@kms_flip@2x-nonexisting-fb:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271]) +91 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl6/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: NOTRUN -> [FAIL][35] ([i915#79]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-skl4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][36] -> [FAIL][37] ([i915#79])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-skl4/igt@kms_flip@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-skl10/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-interruptible@c-edp1:
- shard-iclb: [PASS][38] -> [DMESG-WARN][39] ([i915#4391])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-iclb5/igt@kms_flip@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb7/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][40] ([i915#2672]) +4 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][41] ([i915#2587] / [i915#2672]) +4 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][42] ([i915#2672] / [i915#3555]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-wc:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#109280] / [fdo#111825]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#6497])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-tglb7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-skl: NOTRUN -> [SKIP][45] ([fdo#109271]) +184 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-skl6/igt@[email protected]

* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-c-edp-1:
- shard-iclb: NOTRUN -> [SKIP][46] ([i915#5176]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb5/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][47] -> [SKIP][48] ([i915#5235]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-iclb8/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html

* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#2920])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-tglb7/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#658]) +4 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-skl1/igt@[email protected]

* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109642] / [fdo#111068] / [i915#658])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb5/igt@kms_psr2_su@page_flip-nv12.html

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][52] -> [SKIP][53] ([fdo#109441]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@kms_vblank@pipe-b-accuracy-idle:
- shard-glk: NOTRUN -> [FAIL][54] ([i915#43])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-glk9/igt@[email protected]

* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#533])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl6/igt@[email protected]

* igt@perf_pmu@rc6-suspend:
- shard-apl: [PASS][56] -> [DMESG-WARN][57] ([i915#180]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-apl7/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl7/igt@[email protected]

* igt@sysfs_clients@busy:
- shard-glk: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2994])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-glk3/igt@[email protected]

* igt@sysfs_clients@recycle:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#2994])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl6/igt@[email protected]

* igt@sysfs_clients@sema-25:
- shard-skl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2994]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-skl4/igt@[email protected]

#### Possible fixes ####

* igt@api_intel_allocator@fork-simple-stress-signal:
- shard-tglb: [INCOMPLETE][61] -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-tglb6/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-tglb7/igt@[email protected]

* igt@gem_ctx_persistence@many-contexts:
- shard-iclb: [INCOMPLETE][63] -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-iclb7/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb5/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- {shard-dg1}: [FAIL][65] ([i915#5784]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-dg1-15/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-dg1-13/igt@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][67] ([i915#2842]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-apl6/igt@gem_exec_fair@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl2/igt@gem_exec_fair@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-glk: [DMESG-WARN][69] ([i915#5566] / [i915#716]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-glk7/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-glk3/igt@[email protected]

* igt@i915_module_load@reload:
- shard-skl: [DMESG-WARN][71] ([i915#1982]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-skl6/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-skl1/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][73] ([i915#3989] / [i915#454]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-iclb3/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb7/igt@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][75] ([i915#180]) -> [PASS][76] +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-apl1/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl8/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-apl: [FAIL][77] ([i915#79]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-apl2/igt@kms_flip@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl8/igt@kms_flip@[email protected]

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][79] ([fdo#109441]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html

#### Warnings ####

* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][81] ([i915#6117]) -> [SKIP][82] ([i915#4525])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-iclb1/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb6/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-apl: [INCOMPLETE][83] ([i915#7248]) -> [WARN][84] ([i915#2658])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-apl7/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-apl2/igt@[email protected]

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][85] ([i915#658]) -> [SKIP][86] ([i915#588])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-iclb8/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb2/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle@bcs0:
- shard-iclb: [WARN][87] ([i915#2684]) -> [FAIL][88] ([i915#2684])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-iclb5/igt@i915_pm_rc6_residency@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb2/igt@i915_pm_rc6_residency@[email protected]

* igt@i915_selftest@mock@vma:
- shard-skl: [INCOMPLETE][89] ([i915#6950] / [i915#7065]) -> [INCOMPLETE][90] ([i915#6950])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-skl9/igt@i915_selftest@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-skl7/igt@i915_selftest@[email protected]

* igt@kms_big_fb@linear-16bpp-rotate-0:
- shard-iclb: [DMESG-FAIL][91] ([i915#5138] / [i915#6020]) -> [FAIL][92] ([i915#5138])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-iclb2/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb1/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][93] ([i915#658]) -> [SKIP][94] ([i915#2920])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-iclb5/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][95] ([i915#2920]) -> [SKIP][96] ([fdo#111068] / [i915#658])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-iclb2/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-iclb1/igt@[email protected]

* igt@runner@aborted:
- shard-skl: ([FAIL][97], [FAIL][98]) ([i915#3002] / [i915#4312]) -> ([FAIL][99], [FAIL][100]) ([i915#4312])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-skl6/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12322/shard-skl2/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-skl3/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/shard-skl5/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#6020]: https://gitlab.freedesktop.org/drm/intel/issues/6020
[i915#6032]: https://gitlab.freedesktop.org/drm/intel/issues/6032
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6950]: https://gitlab.freedesktop.org/drm/intel/issues/6950
[i915#7065]: https://gitlab.freedesktop.org/drm/intel/issues/7065
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7121]: https://gitlab.freedesktop.org/drm/intel/issues/7121
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#7299]: https://gitlab.freedesktop.org/drm/intel/issues/7299
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79

Build changes
-------------

* Linux: CI_DRM_12322 -> Patchwork_110310v1

CI-20190529: 20190529
CI_DRM_12322: 7509583d5279ae70fb08f4fec9823c0be6452701 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7031: 54abd9445f732b55556d4e612d24f50803515904 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_110310v1: 7509583d5279ae70fb08f4fec9823c0be6452701 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110310v1/index.html

Reviewed-by on v1 1/1
#3 lore raw
In reply to Paulo Miguel Almeida
Quoted 33 lines · Paulo Miguel Almeida

struct gvt_firmware_header has a crc32 member in which all members that come after the that field are used to calculate it. The previous implementation added the value '4' (crc32's u32 size) to calculate the crc32_start offset which came across as a bit cryptic until you take a deeper look at the struct.

This patch changes crc32_start offset to the 'version' member which is the first member of the struct gvt_firmware_header after crc32.

It's worth mentioning that doing a build before/after this patch results in no binary output differences.

---
 drivers/gpu/drm/i915/gvt/firmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gvt/firmware.c +1 -1
index 54fe442238c6..a683c22d5b64 100644
@@ -104,7 +104,7 @@ static int expose_firmware_sysfs(struct intel_gvt *gvt)
 
 	memcpy(p, gvt->firmware.mmio, info->mmio_size);
 
-	crc32_start = offsetof(struct gvt_firmware_header, crc32) + 4;
+	crc32_start = offsetof(struct gvt_firmware_header, version);
 	h->crc32 = crc32_le(0, firmware + crc32_start, size - crc32_start);
 
 	firmware_attr.size = size;
Signature · 1 line
2.25.4

thanks!