lib: utils/serial: Fix semihosting compile error using LLVM
PATCH v2 1/1 lib: utils/serial: Fix semihosting compile error using LLVM
We fix the following semihosting compile error observed using LLVM:lib/utils/serial/semihosting.c:158:12: error: result of comparison of constant -1 with expression of type 'char' is always true [-Werror,-Wtautological-constant-out-of-range-compare]
ret = ch > -1 ? ch : -1;
~~ ^ ~~--- lib/utils/serial/semihosting.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/utils/serial/semihosting.c +2 -2
@@ -154,8 +154,8 @@ static int semihosting_getc(void)int ret;if (semihosting_infd <0 ) { - ch =semihosting_trap (SYSREADC ,NULL ); - ret = ch >-1 ? ch :-1 ; + ret =semihosting_trap (SYSREADC ,NULL ); + ret = ret <0 ?-1 : ret; }else ret =semihosting_read (semihosting_infd, &ch,1 ) >0 ? ch :-1 ;
Signature · 1 line
2.34.1
PATCH v2 1/1 lib: utils/serial: Fix semihosting compile error using LLVM
? 2022-11-08???? 17:40 +0530?Anup Patel???
Quoted 8 lines
We fix the following semihosting compile error observed using LLVM:
lib/utils/serial/semihosting.c:158:12: error: result of comparison of constant -1 with expression of type 'char' is always true [-Werror,- Wtautological-constant-out-of-range-compare]
??????????????? ret = ch > -1 ? ch : -1;
????????????????????? ~~ ^ ~~Fixes 7f09fba86e43 ("lib: utils/serial: add semihosting support")Signed-off-by Anup Patel <[email protected]>
LGTM
Quoted 23 lines
---
?lib/utils/serial/semihosting.c | 4 ++--
?1 file changed, 2 insertions(+), 2 deletions(-)lib/utils/serial/semihosting.c +0
-0@@ -154,8 +154,8 @@ static int semihosting_getc(void) ????????int ret;?
????????if (semihosting_infd< 0)? {
-???????????????ch =semihosting_trap(SYSREADC, NULL); -???????????????ret = ch > -1 ? ch : -1;
+???????????????ret =semihosting_trap(SYSREADC, NULL); +???????????????ret = ret < 0 ? -1 : ret;
????????} else
????????????????ret =semihosting_read(semihosting_infd, &ch, 1)> 0 ? ch : -1; ?Signature · 1 line
2.34.1
PATCH v2 1/1 lib: utils/serial: Fix semihosting compile error using LLVM
In reply to Anup PatelQuoted 12 lines · Anup Patel
We fix the following semihosting compile error observed using LLVM:
lib/utils/serial/semihosting.c:158:12: error: result of comparison of constant -1 with expression of type 'char' is always true [-Werror,-Wtautological-constant-out-of-range-compare]ret = ch > -1 ? ch : -1; ~~ ^ ~~Fixes 7f09fba86e43 ("lib: utils/serial: add semihosting support")Signed-off-by Anup Patel <[email protected]>--- lib/utils/serial/semihosting.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Anup Patel
AppliedPATCH v2 1/1 lib: utils/serial: Fix semihosting compile error using LLVM
In reply to Anup PatelQuoted 8 lines · Anup Patel
We fix the following semihosting compile error observed using LLVM:
lib/utils/serial/semihosting.c:158:12: error: result of comparison of constant -1 with expression of type 'char' is always true [-Werror,-Wtautological-constant-out-of-range-compare]ret = ch > -1 ? ch : -1; ~~ ^ ~~Fixes 7f09fba86e43 ("lib: utils/serial: add semihosting support")Signed-off-by Anup Patel <[email protected]>
Applied this patch to the riscv/opensbi repo.
Regards,
Anup
Quoted 22 lines
--- lib/utils/serial/semihosting.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)lib/utils/serial/semihosting.c +2
-3@@ -154,8 +154,8 @@ static int semihosting_getc(void)int ret;if (semihosting_infd <0 ) { - ch =semihosting_trap (SYSREADC ,NULL ); - ret = ch >-1 ? ch :-1 ; + ret =semihosting_trap (SYSREADC ,NULL ); + ret = ret <0 ?-1 : ret; }else ret =semihosting_read (semihosting_infd, &ch,1 ) >0 ? ch :-1 ; --2.34.1