Skip to contentSkip to conversation

mm-shmem-remove-unneeded-assignments-in-shmem_get_folio_gfp.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Nov 9, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm/shmem: remove unneeded assignments in shmem_get_folio_gfp()
has been removed from the -mm tree. Its filename was
mm-shmem-remove-unneeded-assignments-in-shmem_get_folio_gfp.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Lukas Bulwahn <[email protected]>
Subject: mm/shmem: remove unneeded assignments in shmem_get_folio_gfp()
Date: Fri, 7 Oct 2022 10:50:27 +0200

After the rework of shmem_get_folio_gfp() to use a folio, the local variable hindex is only needed to be set once before passing it to shmem_add_to_page_cache().

Remove the unneeded initialization and assignments of the variable hindex before the actual effective assignment and first use.

No functional change. No change in object code.

---

 mm/shmem.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
mm/shmem.c renamed from mm/shmem.c~mm-shmem-remove-unneeded-assignments-in-shmem_get_folio_gfp +1 -2
@@ -1826,7 +1826,7 @@ static int shmem_get_folio_gfp(struct in
 	struct shmem_sb_info *sbinfo;
 	struct mm_struct *charge_mm;
 	struct folio *folio;
-	pgoff_t hindex = index;
+	pgoff_t hindex;
 	gfp_t huge_gfp;
 	int error;
 	int once = 0;
@@ -1864,7 +1864,6 @@ repeat:
 	}
 
 	if (folio) {
-		hindex = folio->index;
 		if (sgp == SGP_WRITE)
 			folio_mark_accessed(folio);
 		if (folio_test_uptodate(folio))

_

Patches currently in -mm which might be from [email protected] are