ov8858 device tree addition
Subsystems (2)
Device tree entry for ov8858 image sensor.
Changes since v1:
* Fixed CC list
* Changed filename and path
* Added documentation for power GPIO
* Fixed linter errors
PATCH v2 1/1 dt-bindings: media: Add Omnivision ov8858 binding
Add a device tree binding for the Omnivision OV8858 image sensor. The OV8858 is an 8 megapixel image sensor which provides images in RAW format over MIPI CSI-2 data bus and is controlled through an I2C-compatibile SCCB bus.
Tested on PinePhone Pro with libcamera cam and qcam.
--- .../devicetree/bindings/media/i2c/ov8858.yaml | 139 ++++++++++++++++++ 1 file changed, 139 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8858.yaml
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +139 -0
@@ -0,0 +1,139 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ov8858.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Omnivision OV8856 CMOS Sensor Device Tree Bindings + +maintainers: + - Nicholas Roth <[email protected]> + +description: |- + The Omnivision OV8858 is an 8 megapixel image sensor which provides + images in RAW format over MIPI CSI-2 data bus with up to 4 lanes + and is controlled through an I2C-compatibile SCCB bus. + +properties: + compatible: + const: ovti,ov8858 + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + description: + Input clock for the sensor. + items: + - const: xvclk + + clock-frequency: + description: + Frequency of the xvclk clock in Hertz. + minimum: 6000000 + default: 24000000 + maximum: 27000000 + + dovdd-supply: + description: + Definition of the regulator used as interface power supply. + + avdd-supply: + description: + Definition of the regulator used as analog power supply. + + dvdd-supply: + description: + Definition of the regulator used as digital power supply. + + reset-gpios: + description: + The phandle and specifier for the GPIO that controls sensor reset. + This corresponds to the hardware pin XSHUTDN which is physically + active low. + + powerdown-gpios: + description: + The phandle and specifier for the GPIO that controls power down. + This corresponds to the hardware pin PWDNB which is physically + active low. + + port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + description: |- + The driver supports both two- and four-lane operation. + items: + - const: 1 + - const: 2 + - const: 3 + - const: 4 + + link-frequencies: + description: Frequencies listed are driver, not h/w limitations. + maxItems: 1 + items: + enum: [ 360000000 ] + + required: + - link-frequencies + +required: + - compatible + - reg + - clocks + - clock-names + - clock-frequency + - dovdd-supply + - avdd-supply + - dvdd-supply + - reset-gpios + - port + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + ucam: camera@36 { + compatible = "ovti,ov8858"; + reg = <0x36>; + + reset-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; + powerdown-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&ucam_pdn &ucam_rst>; + + clocks = <&cam_osc>; + clock-names = "xvclk"; + clock-frequency = <24000000>; + + dovdd-supply = <&vcc1v8_dvp>; + dvdd-supply = <&vcc1v2_dvp>; + avdd-supply = <&vcc2v8_dvp>; + + port { + ucam_out: endpoint { + remote-endpoint = <&mipi_in_ucam>; + data-lanes = <1 2 3 4>; + link-frequencies = /bits/ 64 <360000000>; + }; + }; + }; + };
Signature · 1 line
2.34.1
Re: [PATCH v2] dt-bindings: media: Add Omnivision ov8858 binding
Quoted 6 lines · Nicholas Roth
Add a device tree binding for the Omnivision OV8858 image sensor. The OV8858 is an 8 megapixel image sensor which provides images in RAW format over MIPI CSI-2 data bus and is controlled through an I2C-compatibile SCCB bus.
Tested on PinePhone Pro with libcamera cam and qcam.
How can you test bindings with libcamera?
Quoted 2 lines
Signed-off-by Nicholas Roth <[email protected]>
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.
Thank you.
1. There is no driver, no DTS. You received the feedback about it.
2. Wrong cc list. You were asked to use get_maintainers.pl and still decide not to.
Quoted 11 lines
--- .../devicetree/bindings/media/i2c/ov8858.yaml | 139 ++++++++++++++++++ 1 file changed, 139 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8858.yamlDocumentation/devicetree/bindings/media/i2c/ov8858.yaml new file +0
-0
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 4
Quoted 4 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +4
-0@@ -0,0 +1,139 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ov8858.yaml#
Filename still does not match compatible. ovti,ov8858.yaml
Quoted 21 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +21
-0+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Omnivision OV8856 CMOS Sensor Device Tree Bindings + +maintainers: + - Nicholas Roth <[email protected]> + +description: |- + The Omnivision OV8858 is an 8 megapixel image sensor which provides + images in RAW format over MIPI CSI-2 data bus with up to 4 lanes + and is controlled through an I2C-compatibile SCCB bus. + +properties: + compatible: + const: ovti,ov8858 + + reg: + maxItems: 1 + + clocks: + maxItems: 1
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 35
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +10
-0+ + clock-names: + description: + Input clock for the sensor. + items: + - const: xvclk + + clock-frequency: + description: + Frequency of the xvclk clock in Hertz.
The frequency of clock should go via common clock framework - you have get_rate and set_rate. Drop entire property.
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 42
Quoted 7 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +7
-0+ minimum: 6000000 + default: 24000000 + maximum: 27000000 + + dovdd-supply: + description: + Definition of the regulator used as interface power supply.
Drop "Definition of the regulator used as "
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 54
Quoted 12 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +12
-0+ + avdd-supply: + description: + Definition of the regulator used as analog power supply. + + dvdd-supply: + description: + Definition of the regulator used as digital power supply. + + reset-gpios: + description: + The phandle and specifier for the GPIO that controls sensor reset.
Drop this sentence.
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 60
Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +6
-0+ This corresponds to the hardware pin XSHUTDN which is physically + active low. + + powerdown-gpios: + description: + The phandle and specifier for the GPIO that controls power down.
Drop this sentence.
Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +6
-0+ This corresponds to the hardware pin PWDNB which is physically + active low. + + port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 76
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +10
-0+ + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + description: |- + The driver supports both two- and four-lane operation.
Which driver? In OpenBSD? Which version of OpenBSD? Drop the sentence.
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 84
Quoted 8 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +8
-0+ items: + - const: 1 + - const: 2 + - const: 3 + - const: 4 + + link-frequencies: + description: Frequencies listed are driver, not h/w limitations.
If these are driver limitations, then drop it. Link frequencies are hardware related and you should here describe the minimum and maximum. Or leave it empty if any is allowed by hardware.
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +10
-0+ maxItems: 1 + items: + enum: [ 360000000 ] + + required: + - link-frequencies + +required: + - compatible + - reg
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 104
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +10
-0+ - clocks + - clock-names + - clock-frequency + - dovdd-supply + - avdd-supply + - dvdd-supply + - reset-gpios + - port + +additionalProperties: false
Best regards,
Krzysztof
Re: [PATCH v2] dt-bindings: media: Add Omnivision ov8858 binding
Hello,
I’m doing my best to follow along here. Your feedback didn’t get lost and I tried my best to follow it— I just must not have understood it correctly.
Quoted 2 lines
Where is the driver? If it was sent separately, you must resent entire patchset.
...
Quoted 1 line
1. There is no driver, no DTS. You received the feedback about it.
Driver: I submitted the .c files to linux-media, and as part of the review they asked for me to separately submit device tree bindings
(https://patchwork.kernel.org/project/linux-media/patch/[email protected]/).
Are you saying that the driver and the bindings should be the same commit after all? Are you saying that I need to change this into a series and include both linux-media@ and devicetree@ mailing lists in a v3 with both patches? Are you saying something else? I’m afraid I still don’t understand what you mean by this, but I want to, and I’m trying to.
Quoted 2 lines
2. Wrong cc list. You were asked to use get_maintainers.pl and still decide not to.
I included the people from get_maintainers.pl, but it seems like you would like for me to include all entries, including the multiple mailing lists. Do I understand correctly?
Quoted 1 line
Subject: drop redundant, second "binding".
Is this new subject good, or would you prefer just "dt-bindings:
media: Add Omnivision ov8858"? Just want to make sure I follow up.
Quoted 1 line
How can you test bindings with libcamera?
I validated the device tree + driver on this setup, though I did not know about the binding linter (and this one should pass). I am happy to drop the comment about validation though and just say this is tested with the binding checker, or say nothing at all if you'd like.
Quoted 1 line
Filename matching the compatible.
...
Quoted 1 line
Filename still does not match compatible. ovti,ov8858.yaml
I didn't understand this the first time, but now I think I do-- seems like you're asking me to change the binding filename to "ovti,ov8858.yaml". I was trying to be consistent with ov8856.yaml, but happy to change the file name if that’s the convention. Is there a doc I can read with this information or is it institutional knowledge?
Quoted 2 lines
The frequency of clock should go via common clock framework - you have
get_rateandset_rate. Drop entire property.
I am trying to be consistent with the ov8856 driver and bindings but would be happy to change if there's a different standard I should be following. I’m not familiar with that framework though. Is there somewhere I could read about this common clock framework, including the driver and device-tree changes I need in order to use it as compared to this or the ov8856 driver?
Quoted 1 line
Which driver? In OpenBSD? Which version of OpenBSD? Drop the sentence.
Seems like your point here and in the subsequent comments is to avoid implementation specifics. That makes a ton of sense, and I’ll make those changes for v3.
All of your other comments make sense explicitly and I’ll make these changes. Please help me understand what you mean by (1) and (2), correct me where I’m wrong or misunderstanding you here, clarify where needed, and I’ll submit the v3.
Thanks,
-Nicholas
Quoted 170 lines · Krzysztof Kozlowski
Quoted 6 lines · Nicholas Roth
Add a device tree binding for the Omnivision OV8858 image sensor. The OV8858 is an 8 megapixel image sensor which provides images in RAW format over MIPI CSI-2 data bus and is controlled through an I2C-compatibile SCCB bus.
Tested on PinePhone Pro with libcamera cam and qcam.
How can you test bindings with libcamera?
Quoted 2 lines
Signed-off-by Nicholas Roth <[email protected]>This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.
Thank you.
1. There is no driver, no DTS. You received the feedback about it.
2. Wrong cc list. You were asked to use get_maintainers.pl and still decide not to.Quoted 11 lines
--- .../devicetree/bindings/media/i2c/ov8858.yaml | 139 ++++++++++++++++++ 1 file changed, 139 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8858.yamlDocumentation/devicetree/bindings/media/i2c/ov8858.yaml new file +0
-0Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 4
Quoted 4 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +4
-0@@ -0,0 +1,139 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ov8858.yaml#Filename still does not match compatible. ovti,ov8858.yaml
Quoted 21 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +21
-0+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Omnivision OV8856 CMOS Sensor Device Tree Bindings + +maintainers: + - Nicholas Roth <[email protected]> + +description: |- + The Omnivision OV8858 is an 8 megapixel image sensor which provides + images in RAW format over MIPI CSI-2 data bus with up to 4 lanes + and is controlled through an I2C-compatibile SCCB bus. + +properties: + compatible: + const: ovti,ov8858 + + reg: + maxItems: 1 + + clocks: + maxItems: 1Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 35
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +10
-0+ + clock-names: + description: + Input clock for the sensor. + items: + - const: xvclk + + clock-frequency: + description: + Frequency of the xvclk clock in Hertz.The frequency of clock should go via common clock framework - you have
get_rateandset_rate. Drop entire property.Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 42
Quoted 7 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +7
-0+ minimum: 6000000 + default: 24000000 + maximum: 27000000 + + dovdd-supply: + description: + Definition of the regulator used as interface power supply.Drop "Definition of the regulator used as "
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 54
Quoted 12 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +12
-0+ + avdd-supply: + description: + Definition of the regulator used as analog power supply. + + dvdd-supply: + description: + Definition of the regulator used as digital power supply. + + reset-gpios: + description: + The phandle and specifier for the GPIO that controls sensor reset.Drop this sentence.
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 60
Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +6
-0+ This corresponds to the hardware pin XSHUTDN which is physically + active low. + + powerdown-gpios: + description: + The phandle and specifier for the GPIO that controls power down.Drop this sentence.
Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +6
-0+ This corresponds to the hardware pin PWDNB which is physically + active low. + + port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: falseDocumentation/devicetree/bindings/media/i2c/ov8858.yaml line 76
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +10
-0+ + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + description: |- + The driver supports both two- and four-lane operation.Which driver? In OpenBSD? Which version of OpenBSD? Drop the sentence.
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 84
Quoted 8 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +8
-0+ items: + - const: 1 + - const: 2 + - const: 3 + - const: 4 + + link-frequencies: + description: Frequencies listed are driver, not h/w limitations.If these are driver limitations, then drop it. Link frequencies are hardware related and you should here describe the minimum and maximum. Or leave it empty if any is allowed by hardware.
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +10
-0+ maxItems: 1 + items: + enum: [ 360000000 ] + + required: + - link-frequencies + +required: + - compatible + - regDocumentation/devicetree/bindings/media/i2c/ov8858.yaml line 104
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +10
-0+ - clocks + - clock-names + - clock-frequency + - dovdd-supply + - avdd-supply + - dvdd-supply + - reset-gpios + - port + +additionalProperties: falseBest regards,
Krzysztof
Re: [PATCH v2] dt-bindings: media: Add Omnivision ov8858 binding
I just got your earlier email reply regarding the CC list, and I think that clarifies (2) for me. Indeed, it seems like you were asking me to also include the mailing lists. I didn't want to bother that many people, but it seems like this is the procedure.
Quoted 242 lines · Nicholas Roth
Hello,
I’m doing my best to follow along here. Your feedback didn’t get lost and I tried my best to follow it— I just must not have understood it correctly.
Quoted 2 lines
Where is the driver? If it was sent separately, you must resent entire patchset.
...
Quoted 1 line
1. There is no driver, no DTS. You received the feedback about it.
Driver: I submitted the .c files to linux-media, and as part of the review they asked for me to separately submit device tree bindings
(https://patchwork.kernel.org/project/linux-media/patch/[email protected]/).
Are you saying that the driver and the bindings should be the same commit after all? Are you saying that I need to change this into a series and include both linux-media@ and devicetree@ mailing lists in a v3 with both patches? Are you saying something else? I’m afraid I still don’t understand what you mean by this, but I want to, and I’m trying to.Quoted 2 lines
2. Wrong cc list. You were asked to use get_maintainers.pl and still decide not to.
I included the people from get_maintainers.pl, but it seems like you would like for me to include all entries, including the multiple mailing lists. Do I understand correctly?
Quoted 1 line
Subject: drop redundant, second "binding".
Is this new subject good, or would you prefer just "dt-bindings:
media: Add Omnivision ov8858"? Just want to make sure I follow up.Quoted 1 line
How can you test bindings with libcamera?
I validated the device tree + driver on this setup, though I did not know about the binding linter (and this one should pass). I am happy to drop the comment about validation though and just say this is tested with the binding checker, or say nothing at all if you'd like.
Quoted 1 line
Filename matching the compatible.
...
Quoted 1 line
Filename still does not match compatible. ovti,ov8858.yaml
I didn't understand this the first time, but now I think I do-- seems like you're asking me to change the binding filename to "ovti,ov8858.yaml". I was trying to be consistent with
ov8856.yaml, but happy to change the file name if that’s the convention. Is there a doc I can read with this information or is it institutional knowledge?Quoted 2 lines
The frequency of clock should go via common clock framework - you have
get_rateandset_rate. Drop entire property.I am trying to be consistent with the ov8856 driver and bindings but would be happy to change if there's a different standard I should be following. I’m not familiar with that framework though. Is there somewhere I could read about this common clock framework, including the driver and device-tree changes I need in order to use it as compared to this or the ov8856 driver?
Quoted 1 line
Which driver? In OpenBSD? Which version of OpenBSD? Drop the sentence.
Seems like your point here and in the subsequent comments is to avoid implementation specifics. That makes a ton of sense, and I’ll make those changes for v3.
All of your other comments make sense explicitly and I’ll make these changes. Please help me understand what you mean by (1) and (2), correct me where I’m wrong or misunderstanding you here, clarify where needed, and I’ll submit the v3.
Thanks,
-NicholasQuoted 170 lines · Krzysztof Kozlowski
Quoted 6 lines · Nicholas Roth
Add a device tree binding for the Omnivision OV8858 image sensor. The OV8858 is an 8 megapixel image sensor which provides images in RAW format over MIPI CSI-2 data bus and is controlled through an I2C-compatibile SCCB bus.
Tested on PinePhone Pro with libcamera cam and qcam.
How can you test bindings with libcamera?
Quoted 2 lines
Signed-off-by Nicholas Roth <[email protected]>This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them.
Thank you.
1. There is no driver, no DTS. You received the feedback about it.
2. Wrong cc list. You were asked to use get_maintainers.pl and still decide not to.Quoted 11 lines
--- .../devicetree/bindings/media/i2c/ov8858.yaml | 139 ++++++++++++++++++ 1 file changed, 139 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8858.yamlDocumentation/devicetree/bindings/media/i2c/ov8858.yaml new file +0
-0Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 4
Quoted 4 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +4
-0@@ -0,0 +1,139 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ov8858.yaml#Filename still does not match compatible. ovti,ov8858.yaml
Quoted 21 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +21
-0+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Omnivision OV8856 CMOS Sensor Device Tree Bindings + +maintainers: + - Nicholas Roth <[email protected]> + +description: |- + The Omnivision OV8858 is an 8 megapixel image sensor which provides + images in RAW format over MIPI CSI-2 data bus with up to 4 lanes + and is controlled through an I2C-compatibile SCCB bus. + +properties: + compatible: + const: ovti,ov8858 + + reg: + maxItems: 1 + + clocks: + maxItems: 1Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 35
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +10
-0+ + clock-names: + description: + Input clock for the sensor. + items: + - const: xvclk + + clock-frequency: + description: + Frequency of the xvclk clock in Hertz.The frequency of clock should go via common clock framework - you have
get_rateandset_rate. Drop entire property.Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 42
Quoted 7 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +7
-0+ minimum: 6000000 + default: 24000000 + maximum: 27000000 + + dovdd-supply: + description: + Definition of the regulator used as interface power supply.Drop "Definition of the regulator used as "
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 54
Quoted 12 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +12
-0+ + avdd-supply: + description: + Definition of the regulator used as analog power supply. + + dvdd-supply: + description: + Definition of the regulator used as digital power supply. + + reset-gpios: + description: + The phandle and specifier for the GPIO that controls sensor reset.Drop this sentence.
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 60
Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +6
-0+ This corresponds to the hardware pin XSHUTDN which is physically + active low. + + powerdown-gpios: + description: + The phandle and specifier for the GPIO that controls power down.Drop this sentence.
Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +6
-0+ This corresponds to the hardware pin PWDNB which is physically + active low. + + port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: falseDocumentation/devicetree/bindings/media/i2c/ov8858.yaml line 76
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +10
-0+ + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + description: |- + The driver supports both two- and four-lane operation.Which driver? In OpenBSD? Which version of OpenBSD? Drop the sentence.
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 84
Quoted 8 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +8
-0+ items: + - const: 1 + - const: 2 + - const: 3 + - const: 4 + + link-frequencies: + description: Frequencies listed are driver, not h/w limitations.If these are driver limitations, then drop it. Link frequencies are hardware related and you should here describe the minimum and maximum. Or leave it empty if any is allowed by hardware.
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +10
-0+ maxItems: 1 + items: + enum: [ 360000000 ] + + required: + - link-frequencies + +required: + - compatible + - regDocumentation/devicetree/bindings/media/i2c/ov8858.yaml line 104
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +10
-0+ - clocks + - clock-names + - clock-frequency + - dovdd-supply + - avdd-supply + - dvdd-supply + - reset-gpios + - port + +additionalProperties: falseBest regards,
Krzysztof
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH v2] dt-bindings: media: Add Omnivision ov8858 binding
Quoted 7 lines · Nicholas Roth
Hey,
I’m doing my best to follow along here. Your feedback didn’t get lost and I tried my best to follow it— I just must not have understood it correctly.
Quoted 1 line
1. There is no driver, no DTS. You received the feedback about it.
Driver: I submitted the .c files to linux-media, and as part of the review they asked for me to separately submit device tree bindings (https://patchwork.kernel.org/project/linux-media/patch/[email protected]/). Are you saying that the driver and the bindings should be the same commit after all? Are you saying something else? I’m afraid I still don’t understand what you mean by this, but I want to, and I’m trying to.
They come as one patchset. Separate patches, one patchset. Otherwise you get checkpatch errors, right?
Quoted 4 lines
Quoted 3 lines
2. Wrong cc list. You were asked to use get_maintainers.pl and still decide not to.
I included the people from get_maintainers.pl, but it seems like you would like for me to include all entries, including the multiple mailing lists. Do I understand correctly?
Yes. Do not strip some lists based on your preference. Why only some people should receive this, not everyone involved in the subsystem?
Quoted 4 lines
Quoted 3 lines
How can you test bindings with libcamera?
I validate the device tree + driver on this setup, but I am happy to drop the comment about validation.
It's not about bindings then.
Quoted 4 lines
Quoted 3 lines
Filename still does not match compatible. ovti,ov8858.yaml
I was trying to be consistent with
ov8856.yaml, but happy to change the file name if that’s the convention. Is there a doc I can read with this information or is it institutional knowledge?
All recent submissions follow this, so the best is to take last commits.
Quoted 4 lines
Quoted 3 lines
The frequency of clock should go via common clock framework - you have
get_rateandset_rate. Drop entire property.I am trying to be consistent with the ov8856 driver and bindings but would be happy to change. I’m not familiar with that framework though. Is there somewhere I could read about this, including the driver and device-tree changes I need to use this?
This is very difficult to respond. Please use inline comments, I have no clue which part you are now commenting. This is not mailing list style response.
Quoted 5 lines
Quoted 2 lines
Which driver? In OpenBSD? Which version of OpenBSD? Drop the sentence.
Seems like your point here and in the subsequent comments is to avoid implementation specifics. That makes a ton of sense, and I’ll make those changes for v3.
All of your other comments make sense explicitly and I’ll make these changes. Please help me understand what you mean by (1) and (2), correct me where I’m wrong or misunderstanding you here, and I’ll submit the v3.
Best regards,
Krzysztof
Re: [PATCH v2] dt-bindings: media: Add Omnivision ov8858 binding
Happy to reply inline next time. I'm still getting used to this format :-). Here's the context around my clock frequency question-- I'd really like to understand this better:
Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml line 35
Quoted 9 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +9
-0+ clock-names: + description: + Input clock for the sensor. + items: + - const: xvclk + + clock-frequency: + description: + Frequency of the xvclk clock in Hertz.
Quoted 2 lines
The frequency of clock should go via common clock framework - you have
get_rateandset_rate. Drop entire property.
I am trying to be consistent with the ov8856 driver and bindings but would be happy to change. I’m not familiar with that framework though. Is there somewhere I could read about this, including the driver and device-tree changes I need to use this?
Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +7
-0+ minimum: 6000000 + default: 24000000 + maximum: 27000000 + + dovdd-supply: + description: + Definition of the regulator used as interface power supply.
Quoted 54 lines · Krzysztof Kozlowski
Quoted 7 lines · Nicholas Roth
Hey,
I’m doing my best to follow along here. Your feedback didn’t get lost and I tried my best to follow it— I just must not have understood it correctly.
Quoted 1 line
1. There is no driver, no DTS. You received the feedback about it.
Driver: I submitted the .c files to linux-media, and as part of the review they asked for me to separately submit device tree bindings (https://patchwork.kernel.org/project/linux-media/patch/[email protected]/). Are you saying that the driver and the bindings should be the same commit after all? Are you saying something else? I’m afraid I still don’t understand what you mean by this, but I want to, and I’m trying to.
They come as one patchset. Separate patches, one patchset. Otherwise you get checkpatch errors, right?
Quoted 4 lines
Quoted 3 lines
2. Wrong cc list. You were asked to use get_maintainers.pl and still decide not to.
I included the people from get_maintainers.pl, but it seems like you would like for me to include all entries, including the multiple mailing lists. Do I understand correctly?
Yes. Do not strip some lists based on your preference. Why only some people should receive this, not everyone involved in the subsystem?
Quoted 4 lines
Quoted 3 lines
How can you test bindings with libcamera?
I validate the device tree + driver on this setup, but I am happy to drop the comment about validation.
It's not about bindings then.
Quoted 4 lines
Quoted 3 lines
Filename still does not match compatible. ovti,ov8858.yaml
I was trying to be consistent with
ov8856.yaml, but happy to change the file name if that’s the convention. Is there a doc I can read with this information or is it institutional knowledge?All recent submissions follow this, so the best is to take last commits.
Quoted 4 lines
Quoted 3 lines
The frequency of clock should go via common clock framework - you have
get_rateandset_rate. Drop entire property.I am trying to be consistent with the ov8856 driver and bindings but would be happy to change. I’m not familiar with that framework though. Is there somewhere I could read about this, including the driver and device-tree changes I need to use this?
This is very difficult to respond. Please use inline comments, I have no clue which part you are now commenting. This is not mailing list style response.
Quoted 5 lines
Quoted 2 lines
Which driver? In OpenBSD? Which version of OpenBSD? Drop the sentence.
Seems like your point here and in the subsequent comments is to avoid implementation specifics. That makes a ton of sense, and I’ll make those changes for v3.
All of your other comments make sense explicitly and I’ll make these changes. Please help me understand what you mean by (1) and (2), correct me where I’m wrong or misunderstanding you here, and I’ll submit the v3.
Best regards,
Krzysztof
Re: [PATCH v2] dt-bindings: media: Add Omnivision ov8858 binding
Quoted 14 lines · Nicholas Roth
Happy to reply inline next time. I'm still getting used to this format :-). Here's the context around my clock frequency question-- I'd really like to understand this better:
Quoted 10 lines
Quoted 9 lines
Documentation/devicetree/bindings/media/i2c/ov8858.yaml new file +9
-0+ clock-names: + description: + Input clock for the sensor. + items: + - const: xvclk + + clock-frequency: + description: + Frequency of the xvclk clock in Hertz.
Quoted 7 lines
Quoted 2 lines
The frequency of clock should go via common clock framework - you have
get_rateandset_rate. Drop entire property.I am trying to be consistent with the ov8856 driver and bindings but would be happy to change. I’m not familiar with that framework though. Is there somewhere I could read about this, including the driver and device-tree changes I need to use this?
git grep clk_get_rate -- drivers/media/i2c/
For example imx219 or imx334.
Best regards,
Krzysztof