migration: Fix yank on postcopy multifd crashing guest after migration
PATCH 1/1 migration: Fix yank on postcopy multifd crashing guest after migration
When multifd and postcopy-ram capabilities are enabled, if a migrate-start-postcopy is attempted, the migration will finish sending the memory pages and then crash with the following error:
qemu-system-x86_64: ../util/yank.c:107: yank_unregister_instance: Assertion `QLIST_EMPTY(&entry->yankfns)' failed.
This happens because even though all multifd channels could yank_register_function(), none of them could unregister it before unregistering the MIGRATION_YANK_INSTANCE, causing the assert to fail.
Fix that by calling multifd_load_cleanup() on postcopy_ram_listen_thread() before MIGRATION_YANK_INSTANCE is unregistered.
--- migration/migration.h | 1 + migration/migration.c | 18 +++++++++++++----- migration/savevm.c | 2 ++ 3 files changed, 16 insertions(+), 5 deletions(-)
migration/migration.h +1 -0
@@ -473,6 +473,7 @@ void migration_make_urgent_request(void);void migration_consume_urgent_request (void );bool migration_rate_limit (void );void migration_cancel (const Error *error); +bool migration_load_cleanup (void );void populate_vfio_info (MigrationInfo *info);void postcopy_temp_page_reset (PostcopyTmpPage *tmp_page);
migration/migration.c +13 -5
@@ -486,6 +486,17 @@ void migrate_add_address(SocketAddress *address) QAPI_CLONE(SocketAddress, address)); } +bool migration_load_cleanup (void ) +{ +Error *local_err =NULL ; + +if (multifd_load_cleanup (&local_err)) { +error_report_err (local_err); +return true; + } +return false; +} +static void qemu_start_incoming_migration (const char *uri,Error **errp) {const char *p =NULL ;
@@ -540,8 +551,7 @@ static void process_incoming_migration_bh(void *opaque)*/ qemu_announce_self (&mis->announce_timer,migrate_announce_params ()); -if (multifd_load_cleanup (&local_err) !=0 ) { -error_report_err (local_err); +if (migration_load_cleanup ()) { autostart = false; }/* If global state section was not received or we are in running
@@ -646,9 +656,7 @@ fail:migrate_set_state (&mis->state,MIGRATION_STATUS_ACTIVE ,MIGRATION_STATUS_FAILED );qemu_fclose (mis->from_src_file); -if (multifd_load_cleanup (&local_err) !=0 ) { -error_report_err (local_err); - } +migration_load_cleanup ();exit (EXIT_FAILURE ); }
migration/savevm.c +2 -0
@@ -1889,6 +1889,8 @@ static void *postcopy_ram_listen_thread(void *opaque)exit (EXIT_FAILURE ); } +migration_load_cleanup (); +migrate_set_state (&mis->state,MIGRATION_STATUS_POSTCOPY_ACTIVE ,MIGRATION_STATUS_COMPLETED );/*
Signature · 1 line
2.38.1
Quoted 3 lines · * Leonardo Bras ([email protected]) wrote:
When multifd and postcopy-ram capabilities are enabled, if a migrate-start-postcopy is attempted, the migration will finish sending the memory pages and then crash with the following error:
How does that happen? Isn't multifd+postcopy still disabled, I see in migrate_caps_check
if (cap_list[MIGRATION_CAPABILITY_POSTCOPY_RAM]) {
....
if (cap_list[MIGRATION_CAPABILITY_MULTIFD]) {
error_setg(errp, "Postcopy is not yet compatible with multifd");
return false;
}
}Dave
Quoted 90 lines
qemu-system-x86_64:
../util/yank.c:107:yank_unregister_instance: Assertion `QLIST_EMPTY(&entry->yankfns)' failed.This happens because even though all multifd channels could
yank_register_function(), none of them could unregister it before unregistering theMIGRATION_YANK_INSTANCE, causing the assert to fail.Fix that by calling
multifd_load_cleanup()onpostcopy_ram_listen_thread()beforeMIGRATION_YANK_INSTANCEis unregistered.Fixes b5eea99ec2 ("migration: Add yank feature")Reported-by Li Xiaohui <[email protected]>Signed-off-by Leonardo Bras <[email protected]>--- migration/migration.h | 1 + migration/migration.c | 18 +++++++++++++----- migration/savevm.c | 2 ++ 3 files changed, 16 insertions(+), 5 deletions(-)migration/migration.h +1
-0@@ -473,6 +473,7 @@ void migration_make_urgent_request(void);void migration_consume_urgent_request (void );bool migration_rate_limit (void );void migration_cancel (const Error *error); +bool migration_load_cleanup (void );void populate_vfio_info (MigrationInfo *info);void postcopy_temp_page_reset (PostcopyTmpPage *tmp_page);migration/migration.c +13
-5@@ -486,6 +486,17 @@ void migrate_add_address(SocketAddress *address) QAPI_CLONE(SocketAddress, address)); } +bool migration_load_cleanup (void ) +{ +Error *local_err =NULL ; + +if (multifd_load_cleanup (&local_err)) { +error_report_err (local_err); +return true; + } +return false; +} +static void qemu_start_incoming_migration (const char *uri,Error **errp) {const char *p =NULL ;@@ -540,8 +551,7 @@ static void process_incoming_migration_bh(void *opaque)*/ qemu_announce_self (&mis->announce_timer,migrate_announce_params ()); -if (multifd_load_cleanup (&local_err) !=0 ) { -error_report_err (local_err); +if (migration_load_cleanup ()) { autostart = false; }/* If global state section was not received or we are in running @@ -646,9 +656,7 @@ fail:migrate_set_state (&mis->state,MIGRATION_STATUS_ACTIVE ,MIGRATION_STATUS_FAILED );qemu_fclose (mis->from_src_file); -if (multifd_load_cleanup (&local_err) !=0 ) { -error_report_err (local_err); - } +migration_load_cleanup ();exit (EXIT_FAILURE ); }migration/savevm.c +2
-0@@ -1889,6 +1889,8 @@ static void *postcopy_ram_listen_thread(void *opaque)exit (EXIT_FAILURE ); } +migration_load_cleanup (); +migrate_set_state (&mis->state,MIGRATION_STATUS_POSTCOPY_ACTIVE ,MIGRATION_STATUS_COMPLETED );/* Signature · 1 line
2.38.1
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK
Quoted 9 lines · Dr. David Alan Gilbert
Quoted 3 lines · * Leonardo Bras ([email protected]) wrote:
When multifd and postcopy-ram capabilities are enabled, if a migrate-start-postcopy is attempted, the migration will finish sending the memory pages and then crash with the following error:
How does that happen? Isn't multifd+postcopy still disabled, I see in
migrate_caps_check
Quoted 8 lines
if (cap_list[MIGRATION_CAPABILITY_POSTCOPY_RAM]) {
....
if (cap_list[MIGRATION_CAPABILITY_MULTIFD]) {
error_setg(errp, "Postcopy is not yet compatible with multifd");
return false;
}
}I can't see this happening in upstream code (v7.2.0-rc0). Could you please tell me the lines where this happens?
I mean, I see cap_list[MIGRATION_CAPABILITY_MULTIFD] and cap_list[MIGRATION_CAPABILITY_POSTCOPY_RAM] in migrate_caps_check() but I can't see them nested like this, so I am probably missing something.
This procedure to reproduce was shared by Xiaohui Li (I added a few tweaks):
1.Boot a guest with any qemu command on source host;
2.Boot a guest with same qemu command but append '-incoming defer' on
destination host;
3.Enable multifd and postcopy capabilities on src and dst hosts:
{"execute":"migrate-set-capabilities","arguments":{"capabilities":[{"capability":"multifd","state":true}]}} {"execute":"migrate-set-capabilities","arguments":{"capabilities":[{"capability":"postcopy-ram","state":true}]}} 4.During migration is active, switch to postcopy mode:
{"execute":"migrate-start-postcopy"}
Best regards,
Leo
Quoted 96 lines
Dave
Quoted 88 lines
qemu-system-x86_64:
../util/yank.c:107:yank_unregister_instance: Assertion `QLIST_EMPTY(&entry->yankfns)' failed.This happens because even though all multifd channels could
yank_register_function(), none of them could unregister it before unregistering theMIGRATION_YANK_INSTANCE, causing the assert to fail.Fix that by calling
multifd_load_cleanup()onpostcopy_ram_listen_thread()beforeMIGRATION_YANK_INSTANCEis unregistered.Fixes b5eea99ec2 ("migration: Add yank feature")Reported-by Li Xiaohui <[email protected]>Signed-off-by Leonardo Bras <[email protected]>--- migration/migration.h | 1 + migration/migration.c | 18 +++++++++++++----- migration/savevm.c | 2 ++ 3 files changed, 16 insertions(+), 5 deletions(-)migration/migration.h +1
-0@@ -473,6 +473,7 @@ void migration_make_urgent_request(void);void migration_consume_urgent_request (void );bool migration_rate_limit (void );void migration_cancel (const Error *error); +bool migration_load_cleanup (void );void populate_vfio_info (MigrationInfo *info);void postcopy_temp_page_reset (PostcopyTmpPage *tmp_page);migration/migration.c +13
-5@@ -486,6 +486,17 @@ void migrate_add_address(SocketAddress *address) QAPI_CLONE(SocketAddress, address)); } +bool migration_load_cleanup (void ) +{ +Error *local_err =NULL ; + +if (multifd_load_cleanup (&local_err)) { +error_report_err (local_err); +return true; + } +return false; +} +static void qemu_start_incoming_migration (const char *uri,Error **errp) {const char *p =NULL ;@@ -540,8 +551,7 @@ static void process_incoming_migration_bh(void *opaque)*/ qemu_announce_self (&mis->announce_timer,migrate_announce_params ()); -if (multifd_load_cleanup (&local_err) !=0 ) { -error_report_err (local_err); +if (migration_load_cleanup ()) { autostart = false; }/* If global state section was not received or we are in running @@ -646,9 +656,7 @@ fail:migrate_set_state (&mis->state,MIGRATION_STATUS_ACTIVE ,MIGRATION_STATUS_FAILED );qemu_fclose (mis->from_src_file); -if (multifd_load_cleanup (&local_err) !=0 ) { -error_report_err (local_err); - } +migration_load_cleanup ();exit (EXIT_FAILURE ); }migration/savevm.c +2
-1@@ -1889,6 +1889,8 @@ static void *postcopy_ram_listen_thread(void *opaque)exit (EXIT_FAILURE ); } +migration_load_cleanup (); +migrate_set_state (&mis->state,MIGRATION_STATUS_POSTCOPY_ACTIVE ,MIGRATION_STATUS_COMPLETED );/* -- Quoted 2 lines
2.38.1
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK
Leonardo Bras <[email protected]> wrote:
D> When multifd and postcopy-ram capabilities are enabled, if a
Quoted 6 lines
migrate-start-postcopy is attempted, the migration will finish sending the memory pages and then crash with the following error:
qemu-system-x86_64:
../util/yank.c:107:yank_unregister_instance: Assertion `QLIST_EMPTY(&entry->yankfns)' failed.
Quoted 6 lines
This happens because even though all multifd channels could
yank_register_function(), none of them could unregister it before unregistering theMIGRATION_YANK_INSTANCE, causing the assert to fail.Fix that by calling
multifd_load_cleanup()onpostcopy_ram_listen_thread()beforeMIGRATION_YANK_INSTANCEis unregistered.
Hi
One question,
What warantees that migration_load_cleanup() is not called twice?
I can't see anything that provides that here? Or does postcopy have never done the cleanup of multifd channels before?
Later, Juan.
Quoted 69 lines
Fixes b5eea99ec2 ("migration: Add yank feature")Reported-by Li Xiaohui <[email protected]>Signed-off-by Leonardo Bras <[email protected]>--- migration/migration.h | 1 + migration/migration.c | 18 +++++++++++++----- migration/savevm.c | 2 ++ 3 files changed, 16 insertions(+), 5 deletions(-)migration/migration.h +1
-0@@ -473,6 +473,7 @@ void migration_make_urgent_request(void);void migration_consume_urgent_request (void );bool migration_rate_limit (void );void migration_cancel (const Error *error); +bool migration_load_cleanup (void );void populate_vfio_info (MigrationInfo *info);void postcopy_temp_page_reset (PostcopyTmpPage *tmp_page);migration/migration.c +13
-5@@ -486,6 +486,17 @@ void migrate_add_address(SocketAddress *address) QAPI_CLONE(SocketAddress, address)); } +bool migration_load_cleanup (void ) +{ +Error *local_err =NULL ; + +if (multifd_load_cleanup (&local_err)) { +error_report_err (local_err); +return true; + } +return false; +} +static void qemu_start_incoming_migration (const char *uri,Error **errp) {const char *p =NULL ;@@ -540,8 +551,7 @@ static void process_incoming_migration_bh(void *opaque)*/ qemu_announce_self (&mis->announce_timer,migrate_announce_params ()); -if (multifd_load_cleanup (&local_err) !=0 ) { -error_report_err (local_err); +if (migration_load_cleanup ()) { autostart = false; }/* If global state section was not received or we are in running @@ -646,9 +656,7 @@ fail:migrate_set_state (&mis->state,MIGRATION_STATUS_ACTIVE ,MIGRATION_STATUS_FAILED );qemu_fclose (mis->from_src_file); -if (multifd_load_cleanup (&local_err) !=0 ) { -error_report_err (local_err); - } +migration_load_cleanup ();exit (EXIT_FAILURE ); }migration/savevm.c +0
-0
migration/savevm.c static void *postcopy_ram_listen_thread(void *opaque) · line 1893
Quoted 5 lines
migration/savevm.c +2
-0@@ -1889,6 +1889,8 @@ static void *postcopy_ram_listen_thread(void *opaque)exit (EXIT_FAILURE ); } +migration_load_cleanup (); +
This addition is the one that I don't understand why it was not needed/done before.
migration/savevm.c static void *postcopy_ram_listen_thread(void *opaque) · line 1896
Quoted 3 lines
migration/savevm.c +0
-0migrate_set_state (&mis->state,MIGRATION_STATUS_POSTCOPY_ACTIVE ,MIGRATION_STATUS_COMPLETED );/*
Later, Juan.
Quoted 16 lines · Juan Quintela
Leonardo Bras <[email protected]> wrote:
D> When multifd and postcopy-ram capabilities are enabled, if aQuoted 6 lines
migrate-start-postcopy is attempted, the migration will finish sending the memory pages and then crash with the following error:
qemu-system-x86_64:
../util/yank.c:107:yank_unregister_instance: Assertion `QLIST_EMPTY(&entry->yankfns)' failed.Quoted 6 lines
This happens because even though all multifd channels could
yank_register_function(), none of them could unregister it before unregistering theMIGRATION_YANK_INSTANCE, causing the assert to fail.Fix that by calling
multifd_load_cleanup()onpostcopy_ram_listen_thread()beforeMIGRATION_YANK_INSTANCEis unregistered.
Quoted 7 lines
Hi
One question,
What warantees thatmigration_load_cleanup()is not called twice?I can't see anything that provides that here? Or does postcopy have never done the cleanup of multifd channels before?
IIUC, postcopy is not doing multifd cleanup for a while, at least since 6.0.0-rc2.
That is as far as I went back testing, and by fixing other (build) bugs, I could get the yank to abort the target qemu after the migration finished on multifd + postcopy scenario.
Quoted 76 lines
Later, Juan.
Quoted 72 lines
Fixes b5eea99ec2 ("migration: Add yank feature")Reported-by Li Xiaohui <[email protected]>Signed-off-by Leonardo Bras <[email protected]>--- migration/migration.h | 1 + migration/migration.c | 18 +++++++++++++----- migration/savevm.c | 2 ++ 3 files changed, 16 insertions(+), 5 deletions(-)migration/migration.h +1
-0@@ -473,6 +473,7 @@ void migration_make_urgent_request(void);void migration_consume_urgent_request (void );bool migration_rate_limit (void );void migration_cancel (const Error *error); +bool migration_load_cleanup (void );void populate_vfio_info (MigrationInfo *info);void postcopy_temp_page_reset (PostcopyTmpPage *tmp_page);migration/migration.c +13
-5@@ -486,6 +486,17 @@ void migrate_add_address(SocketAddress *address) QAPI_CLONE(SocketAddress, address)); } +bool migration_load_cleanup (void ) +{ +Error *local_err =NULL ; + +if (multifd_load_cleanup (&local_err)) { +error_report_err (local_err); +return true; + } +return false; +} +static void qemu_start_incoming_migration (const char *uri,Error **errp) {const char *p =NULL ;@@ -540,8 +551,7 @@ static void process_incoming_migration_bh(void *opaque)*/ qemu_announce_self (&mis->announce_timer,migrate_announce_params ()); -if (multifd_load_cleanup (&local_err) !=0 ) { -error_report_err (local_err); +if (migration_load_cleanup ()) { autostart = false; }/* If global state section was not received or we are in running @@ -646,9 +656,7 @@ fail:migrate_set_state (&mis->state,MIGRATION_STATUS_ACTIVE ,MIGRATION_STATUS_FAILED );qemu_fclose (mis->from_src_file); -if (multifd_load_cleanup (&local_err) !=0 ) { -error_report_err (local_err); - } +migration_load_cleanup ();exit (EXIT_FAILURE ); }migration/savevm.c +0
-0@@ -1889,6 +1889,8 @@ static void *postcopy_ram_listen_thread(void *opaque)exit (EXIT_FAILURE ); }
Quoted 5 lines
migration/savevm.c static void *postcopy_ram_listen_thread(void *opaque) · line 1893
Quoted 2 lines
migration/savevm.c +2
-0+migration_load_cleanup (); +This addition is the one that I don't understand why it was not needed/done before.
Please see the above comment, but tl;dr, it was not done before.
Thanks you for reviewing,
Leo
Quoted 7 lines
migration/savevm.c static void *postcopy_ram_listen_thread(void *opaque) · line 1896
Quoted 4 lines
migration/savevm.c +0
-0migrate_set_state (&mis->state,MIGRATION_STATUS_POSTCOPY_ACTIVE ,MIGRATION_STATUS_COMPLETED );/* Later, Juan.
migration/savevm.c static void *postcopy_ram_listen_thread(void *opaque) · line 1892
Quoted 9 lines · Leonardo Bras
migration/savevm.c +1
-0@@ -1889,6 +1889,8 @@ static void *postcopy_ram_listen_thread(void *opaque)exit (EXIT_FAILURE ); } +migration_load_cleanup ();
It's a bit weird to call multifd-load-clean in a listen phase..
How about moving it right above trace_process_incoming_migration_co_postcopy_end_main()? Then the new helper can also be static.
Quoted 7 lines
migration/savevm.c +1
-0+migrate_set_state (&mis->state,MIGRATION_STATUS_POSTCOPY_ACTIVE ,MIGRATION_STATUS_COMPLETED );/* Signature · 1 line
2.38.1
Signature · 1 line
Peter Xu
Hello Peter,
Quoted 10 lines · Peter Xu
Quoted 8 lines · Leonardo Bras
migration/savevm.c +0
-0@@ -1889,6 +1889,8 @@ static void *postcopy_ram_listen_thread(void *opaque)exit (EXIT_FAILURE ); }
Quoted 3 lines
migration/savevm.c static void *postcopy_ram_listen_thread(void *opaque) · line 1892
Quoted 1 line
migration/savevm.c +1
-0+migration_load_cleanup ();It's a bit weird to call multifd-load-clean in a listen phase..
I agree.
Quoted 4 lines
How about moving it right above
trace_process_incoming_migration_co_postcopy_end_main()? Then the new helper can also be static.
Seems a nice Idea to have this function to be static.
We have to guarantee this is run after the migration finished, but before migration_incoming_state_destroy().
You suggested calling it right above of trace_process_incoming_migration_co_postcopy_end_main(), which git grep pointed me to an if clause in process_incoming_migration_co(). If I got the location correctly, it would not help: this coroutine is ran just after the VM went to the target host, and not when the migration finished.
If we are using multifd channels, this will break the migration with segmentation fault (SIGSEGV), since the channels have not finished sending yet.
Best regards,
Leo
Quoted 12 lines
Quoted 8 lines
migration/savevm.c +1
-1+migrate_set_state (&mis->state,MIGRATION_STATUS_POSTCOPY_ACTIVE ,MIGRATION_STATUS_COMPLETED );/* -- 2.38.1
--
Peter Xu
Quoted 1 line · Leonardo Bras Soares Passos
Hello Peter,
Leo,
Quoted 19 lines · Peter Xu
Quoted 10 lines · Leonardo Bras
Quoted 8 lines
migration/savevm.c +0
-0@@ -1889,6 +1889,8 @@ static void *postcopy_ram_listen_thread(void *opaque)exit (EXIT_FAILURE ); }Quoted 3 lines
migration/savevm.c static void *postcopy_ram_listen_thread(void *opaque) · line 1892
Quoted 1 line
migration/savevm.c +1
-0+migration_load_cleanup ();It's a bit weird to call multifd-load-clean in a listen phase..
I agree.
Quoted 1 line
Quoted 8 lines
Quoted 3 lines
How about moving it right above
trace_process_incoming_migration_co_postcopy_end_main()? Then the new helper can also be static.Seems a nice Idea to have this function to be static.
We have to guarantee this is run after the migration finished, but before
migration_incoming_state_destroy().
IIUC it doesn't need to be when migration finished. It should be fine as long as we finished precopy phase, and that's what the migration coroutine does, iiuc. The thing is postcopy doesn't use multifd at all, so logically it can be released before postcopy starts.
Actually, IMHO it'll be safer to do it like that, just to make sure we won't accidentally receive multifd pages _after_ postcopy starts, because that'll be another more severe and hard to debug issue since the guest can see partial copied pages from multifd recv channels.
Quoted 11 lines
You suggested calling it right above of
trace_process_incoming_migration_co_postcopy_end_main(), which git grep pointed me to an if clause inprocess_incoming_migration_co(). If I got the location correctly, it would not help: this coroutine is ran just after the VM went to the target host, and not when the migration finished.If we are using multifd channels, this will break the migration with segmentation fault (SIGSEGV), since the channels have not finished sending yet.
If this happens, then I had a feeling that there's something else that needs syncs. As I discussed above, we should make sure multifd pages all landed before we start vcpu threads.
Said that, now I think I'm not against your original proposal to fix this immediate crash. However I am still wondering whether we really should disable multifd with postcopy, as there seem to be still a few missing pieces even to enable multifd during precopy-only.
Thanks,
Signature · 1 line
Peter Xu
Quoted 59 lines · Peter Xu
Quoted 1 line · Leonardo Bras Soares Passos
Hello Peter,
Leo,
Quoted 19 lines · Peter Xu
Quoted 10 lines · Leonardo Bras
Quoted 8 lines
migration/savevm.c +0
-0@@ -1889,6 +1889,8 @@ static void *postcopy_ram_listen_thread(void *opaque)exit (EXIT_FAILURE ); }Quoted 3 lines
migration/savevm.c static void *postcopy_ram_listen_thread(void *opaque) · line 1892
Quoted 1 line
migration/savevm.c +1
-0+migration_load_cleanup ();It's a bit weird to call multifd-load-clean in a listen phase..
I agree.
Quoted 1 line
Quoted 8 lines
Quoted 3 lines
How about moving it right above
trace_process_incoming_migration_co_postcopy_end_main()? Then the new helper can also be static.Seems a nice Idea to have this function to be static.
We have to guarantee this is run after the migration finished, but before
migration_incoming_state_destroy().IIUC it doesn't need to be when migration finished. It should be fine as long as we finished precopy phase, and that's what the migration coroutine does, iiuc. The thing is postcopy doesn't use multifd at all, so logically it can be released before postcopy starts.
Actually, IMHO it'll be safer to do it like that, just to make sure we won't accidentally receive multifd pages _after_ postcopy starts, because that'll be another more severe and hard to debug issue since the guest can see partial copied pages from multifd recv channels.
Quoted 11 lines
You suggested calling it right above of
trace_process_incoming_migration_co_postcopy_end_main(), which git grep pointed me to an if clause inprocess_incoming_migration_co(). If I got the location correctly, it would not help: this coroutine is ran just after the VM went to the target host, and not when the migration finished.If we are using multifd channels, this will break the migration with segmentation fault (SIGSEGV), since the channels have not finished sending yet.
If this happens, then I had a feeling that there's something else that needs syncs. As I discussed above, we should make sure multifd pages all landed before we start vcpu threads.
Quoted 7 lines
Said that, now I think I'm not against your original proposal to fix this immediate crash. However I am still wondering whether we really should disable multifd with postcopy, as there seem to be still a few missing pieces even to enable multifd during precopy-only.
Thanks,
I got side-tracked on this issue.
Is there any patch disabling multifd + postcopy, or would it be fine to go back working on a V2 for this one?
Best regards,
Leo
Quoted 4 lines · Leonardo Brás
I got side-tracked on this issue.
Is there any patch disabling multifd + postcopy, or would it be fine to go back working on a V2 for this one?
IMHO it'll always make sense to post a new version for the immediate crash.
Personally I still think we should disable the two features being present together until the full solution, but that can be discussed separately.
Thanks,
Signature · 1 line
Peter Xu