pinctrl: Put space between type and data in compound literal
Subsystems (2)
PATCH 1/1 pinctrl: Put space between type and data in compound literal
It's slightly better to read when compound literal data and type are separated by a space.
Signed-off-by Andy Shevchenko <[email protected]>
---
It also standard practice in the kernel:
$ git grep -l '(struct [^()]\+) {' | wc -l
1384$ git grep -l '(struct [^()]\+){' | wc -l
306include/linux/pinctrl/pinctrl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/pinctrl/pinctrl.h +1 -1
@@ -40,7 +40,7 @@ struct pingroup {/* Convenience macro to define a single named or anonymous pingroup */ #define PINCTRL_PINGROUP (_name, _pins, _npins) \ -(struct pingroup){ \ +(struct pingroup) { \ .name = _name, \ .pins = _pins, \ .npins = _npins, \
Signature · 1 line
2.35.1
Quoted 22 lines · Andy Shevchenko
It's slightly better to read when compound literal data and type are separated by a space.
Signed-off-by Andy Shevchenko <[email protected]>---
It also standard practice in the kernel:
$ git grep -l '(struct [^()]\+) {' | wc -l 1384$ git grep -l '(struct [^()]\+){' | wc -l 306include/linux/pinctrl/pinctrl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/linux/pinctrl/pinctrl.h +0
-0
include/linux/pinctrl/pinctrl.h struct pingroup { · line 46
Quoted 8 lines
include/linux/pinctrl/pinctrl.h +1
-1@@ -40,7 +40,7 @@ struct pingroup {/* Convenience macro to define a single named or anonymous pingroup */ #define PINCTRL_PINGROUP (_name, _pins, _npins) \ -(struct pingroup){ \ +(struct pingroup) { \ .name = _name, \ .pins = _pins, \ .npins = _npins, \
Looks good to me
Reviewed-by Basavaraj Natikar <[email protected]>
Thanks,
--
Basavaraj
Quoted 4 lines · Andy Shevchenko
It's slightly better to read when compound literal data and type are separated by a space.
Signed-off-by Andy Shevchenko <[email protected]>
Patch applied.
Yours,
Linus Walleij