Skip to contentSkip to conversation

package/nodejs: drop support for the MIPS architecture

PATCH Applied Thomas Petazzoni via buildroot 2 participants 4 messages Oct 26, 2022 – Nov 9, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/nodejs: drop support for the MIPS architecture

The build of NodeJS fails on mipsel due to an issue in the V8 code:

../../deps/v8/src/compiler/backend/mips/code-generator-mips.cc:4106:48: error: call of overloaded 'Operand(int64_t)' is ambiguous
4106 | Operand(static_cast<int64_t>(0)));

There is apparently a lack of maintenance of the MIPS port of V8, as is discussed in the Github issue at
https://github.com/nodejs/node/issues/26179.

Until this get improved/fixed, our best option is to drop support for MIPS in our NodeJS package.

Fixes:

http://autobuild.buildroot.net/results/0e6ee80c77bcb77afe18410e8d9da93b738cb0a4/

---
 package/nodejs/Config.in | 1 -
 1 file changed, 1 deletion(-)
package/nodejs/Config.in +0 -1
index 5375dfeacd..1489306be0 100644
@@ -2,7 +2,6 @@ config BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
 	bool
 	# On ARM, at least ARMv6+ with VFPv2+ is needed
 	default y if BR2_arm && !BR2_ARM_CPU_ARMV4 && !BR2_ARM_CPU_ARMV5 && BR2_ARM_CPU_HAS_VFPV2
-	default y if BR2_mipsel && !BR2_MIPS_SOFT_FLOAT
 	default y if BR2_aarch64 || BR2_i386 || BR2_x86_64
 	# libuv
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
Signature · 6 lines
2.37.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 12 lines · On Wed, 26 Oct 2022 19:57:05 +0200 Thomas Petazzoni via buildroot…

The build of NodeJS fails on mipsel due to an issue in the V8 code:

../../deps/v8/src/compiler/backend/mips/code-generator-mips.cc:4106:48: error: call of overloaded 'Operand(int64_t)' is ambiguous
4106 | Operand(static_cast<int64_t>(0)));

There is apparently a lack of maintenance of the MIPS port of V8, as is discussed in the Github issue at
https://github.com/nodejs/node/issues/26179.

Until this get improved/fixed, our best option is to drop support for MIPS in our NodeJS package.

Quoted 8 lines

Fixes:

http://autobuild.buildroot.net/results/0e6ee80c77bcb77afe18410e8d9da93b738cb0a4/

---
 package/nodejs/Config.in | 1 -
 1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Thomas Petazzoni via buildroot
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni via buildroot <[email protected]> writes:

The build of NodeJS fails on mipsel due to an issue in the V8 code:
../../deps/v8/src/compiler/backend/mips/code-generator-mips.cc:4106:48: error: call of overloaded 'Operand(int64_t)' is ambiguous
4106 | Operand(static_cast<int64_t>(0)));

There is apparently a lack of maintenance of the MIPS port of V8, as is discussed in the Github issue at
https://github.com/nodejs/node/issues/26179.

Quoted 8 lines

Until this get improved/fixed, our best option is to drop support for MIPS in our NodeJS package.

Fixes:

http://autobuild.buildroot.net/results/0e6ee80c77bcb77afe18410e8d9da93b738cb0a4/

:/

Committed to 2022.08.x, thanks.

Perhaps this is only a >= nodejs 16.x issue? We don't seem to have any similar build issues for 14.x on 2022.02.x.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw
Quoted 4 lines · On Wed, 09 Nov 2022 14:28:31 +0100 Peter Korsgaard <[email protected]> wrote:

Committed to 2022.08.x, thanks.

Perhaps this is only a >= nodejs 16.x issue? We don't seem to have any similar build issues for 14.x on 2022.02.x.

I honestly didn't look at older releases. It is indeed possible that it used to work, since when MIPS support was added I suppose someone was using it :-)

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot