drm/amdgpu: Ignore stop rlc on SRIOV environment.
Subsystems (3)
PATCH 1/1 drm/amdgpu: Ignore stop rlc on SRIOV environment.
For SRIOV, the guest driver should not do stop rlc. The host handles programing RLC.
On SRIOV, the stop rlc will be hang (RLC related registers are blocked by policy) when the RLCG interface is not enabled.
--- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +1 -1
@@ -1517,7 +1517,7 @@ static int smu_disable_dpms(struct smu_context *smu) }if (adev->ip_versions[GC_HWIP ][0 ] >=IP_VERSION (9 ,4 ,2 ) && - adev->gfx.rlc.funcs->stop) + !amdgpu_sriov_vf (adev) && adev->gfx.rlc.funcs->stop) adev->gfx.rlc.funcs->stop (adev);return ret;
Signature · 1 line
2.34.1
Quoted 8 lines · Gavin Wan
For SRIOV, the guest driver should not do stop rlc. The host handles programing RLC.
On SRIOV, the stop rlc will be hang (RLC related registers are blocked by policy) when the RLCG interface is not enabled.
Signed-off-by Gavin Wan <[email protected]>
Quoted 20 lines
Change-Id: Iac31332e2c958aae9506759de1d3a311b5c84942> ---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +1
-2@@ -1517,7 +1517,7 @@ static int smu_disable_dpms(struct smu_context *smu) }if (adev->ip_versions[GC_HWIP ][0 ] >=IP_VERSION (9 ,4 ,2 ) && - adev->gfx.rlc.funcs->stop) + !amdgpu_sriov_vf (adev) && adev->gfx.rlc.funcs->stop) adev->gfx.rlc.funcs->stop (adev);return ret; --2.34.1
Liu, Shaoyun
Acked-by Alex Deucher[AMD Official Use Only - General]
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Wednesday, November 9, 2022 2:07 PM
To: Wan, Gavin <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] drm/amdgpu: Ignore stop rlc on SRIOV environment.
Quoted 8 lines · Gavin Wan
For SRIOV, the guest driver should not do stop rlc. The host handles programing RLC.
On SRIOV, the stop rlc will be hang (RLC related registers are blocked by policy) when the RLCG interface is not enabled.
Signed-off-by Gavin Wan <[email protected]>
Quoted 21 lines
Change-Id: Iac31332e2c958aae9506759de1d3a311b5c84942> ---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +1
-2@@ -1517,7 +1517,7 @@ static int smu_disable_dpms(struct smu_context *smu) }if (adev->ip_versions[GC_HWIP ][0 ] >=IP_VERSION (9 ,4 ,2 ) && - adev->gfx.rlc.funcs->stop) + !amdgpu_sriov_vf (adev) && adev->gfx.rlc.funcs->stop) adev->gfx.rlc.funcs->stop (adev);return ret; --2.34.1
[AMD Official Use Only - General]
Best Regards,
Kevin
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Gavin Wan
Sent: Thursday, November 10, 2022 2:24 AM
To: [email protected]
Cc: Wan, Gavin <[email protected]>
Subject: [PATCH] drm/amdgpu: Ignore stop rlc on SRIOV environment.
For SRIOV, the guest driver should not do stop rlc. The host handles programing RLC.
On SRIOV, the stop rlc will be hang (RLC related registers are blocked by policy) when the RLCG interface is not enabled.
--- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +1 -1
@@ -1517,7 +1517,7 @@ static int smu_disable_dpms(struct smu_context *smu) }if (adev->ip_versions[GC_HWIP ][0 ] >=IP_VERSION (9 ,4 ,2 ) && - adev->gfx.rlc.funcs->stop) + !amdgpu_sriov_vf (adev) && adev->gfx.rlc.funcs->stop) adev->gfx.rlc.funcs->stop (adev);return ret;
--
2.34.1