ceph: Fix NULL vs IS_ERR checking in ceph_getattr
PATCH 1/1 ceph: Fix NULL vs IS_ERR checking in ceph_getattr
The ceph_lookup_inode() function return error pointers on error instead of NULL.
Use IS_ERR() to check the return value to fix this.
--- fs/ceph/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ceph/inode.c +1 -1
@@ -2492,7 +2492,7 @@ int ceph_getattr(struct user_namespace *mnt_userns, const struct path *path,struct inode *parent; parent =ceph_lookup_inode (sb,ceph_ino (inode)); -if (!parent) +if (IS_ERR (parent))return PTR_ERR (parent); pci =ceph_inode (parent);
Signature · 1 line
2.37.3.671.ge2130fe6da78.dirty
Hi Miaoqian,
Thanks for your patch. This has already been fixed by Dan Carpenter weeks ago and already in the ceph-client's testing branch, please see [1]:
[1] https://github.com/ceph/ceph-client/commit/ffc4d66a34bb5bd76d0a3f83bebf500d96a8e37c
BRs
- Xiubo
Quoted 23 lines · Miaoqian Lin
The
ceph_lookup_inode()function return error pointers on error instead of NULL.
UseIS_ERR()to check the return value to fix this.Fixes aa87052dd965 ("ceph: fix incorrectly showing the .snap size for stat")Signed-off-by Miaoqian Lin <[email protected]>--- fs/ceph/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/ceph/inode.c +1
-1@@ -2492,7 +2492,7 @@ int ceph_getattr(struct user_namespace *mnt_userns, const struct path *path,struct inode *parent; parent =ceph_lookup_inode (sb,ceph_ino (inode)); -if (!parent) +if (IS_ERR (parent))return PTR_ERR (parent); pci =ceph_inode (parent);
Ilya Dryomov
maintainerQuoted 8 lines · Xiubo Li
Hi Miaoqian,
Thanks for your patch. This has already been fixed by Dan Carpenter weeks ago and already in the ceph-client's testing branch, please see [1]:
[1]
https://github.com/ceph/ceph-client/commit/ffc4d66a34bb5bd76d0a3f83bebf500d96a8e37c
It's also present in linux-next:
Thanks,
Ilya