maple_tree: should get pivots boundary by type
Subsystems (3)
RFC PATCH 1/1 maple_tree: should get pivots boundary by type
If my understanding is correct, we should get pivots boundary by type.
---
* kernel build looks good
--- lib/maple_tree.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
lib/maple_tree.c +3 -2
@@ -669,12 +669,13 @@ static inline unsigned long mte_pivot(const struct maple_enode *mn, unsigned char piv) {struct maple_node *node =mte_to_node (mn); +enum maple_type type =mte_node_type (mn); -if (piv >= mt_pivots[piv]) { +if (piv >= mt_pivots[type]) {WARN_ON (1 );return 0 ; } -switch (mte_node_type (mn)) { +switch (type) {case maple_arange_64:return node->ma64.pivot[piv];case maple_range_64:
Signature · 1 line
2.33.1
Quoted 2 lines · Wei Yang
If my understanding is correct, we should get pivots boundary by type.
Thank you, yes - you are correct. This is a bug, and should have:
Please fix your commit message and add the fixes line and resend.
Quoted 32 lines
Signed-off-by Wei Yang <[email protected]>CC Liam R. Howlett <[email protected]>---
* kernel build looks good--- lib/maple_tree.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)lib/maple_tree.c +3
-2@@ -669,12 +669,13 @@ static inline unsigned long mte_pivot(const struct maple_enode *mn, unsigned char piv) {struct maple_node *node =mte_to_node (mn); +enum maple_type type =mte_node_type (mn); -if (piv >= mt_pivots[piv]) { +if (piv >= mt_pivots[type]) {WARN_ON (1 );return 0 ; } -switch (mte_node_type (mn)) { +switch (type) {case maple_arange_64:return node->ma64.pivot[piv];case maple_range_64:Signature · 1 line
2.33.1
Quoted 5 lines · Liam Howlett
Quoted 2 lines · Wei Yang
If my understanding is correct, we should get pivots boundary by type.
Thank you, yes - you are correct. This is a bug, and should have:
Thanks. I am curious why this doesn't trigger a problem yet?
From code, it seems we may access the out of boundary array.
Quoted 7 lines
Fixes 54a611b60590 (Maple Tree: add new data structure)Please fix your commit message and add the fixes line and resend.
Reviewed-by Liam R. Howlett <[email protected]>
Signature · 2 lines
Wei Yang Help you, Help me
Quoted 10 lines · Wei Yang
Quoted 5 lines · Liam Howlett
Quoted 2 lines · Wei Yang
If my understanding is correct, we should get pivots boundary by type.
Thank you, yes - you are correct. This is a bug, and should have:
Thanks. I am curious why this doesn't trigger a problem yet?
From code, it seems we may access the out of boundary array.
yes, it would likely access the array out of bounds. This code is not used by the mm code right now.
Quoted 12 lines
Quoted 8 lines
Fixes 54a611b60590 (Maple Tree: add new data structure)Please fix your commit message and add the fixes line and resend.
Reviewed-by Liam R. Howlett <[email protected]>Signature · 2 lines
Wei Yang Help you, Help me