Coverity: vgxy61_detect(): Control flow issues

Hello!

This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221110 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits:

Thu Oct 27 14:37:38 2022 +0300

    153e4ad44d60 ("media: i2c: Add driver for ST VGXY61 camera sensor")

Coverity reported the following:

*** CID 1527257: Control flow issues (NO_EFFECT) drivers/media/i2c/st-vgxy61.c:1679 in vgxy61_detect()

1673     	struct i2c_client *client = sensor->i2c_client;
1674     	u16 id = 0;
1675     	int ret;
1676     	u8 st;

1677
1678 id = vgxy61_read_reg(sensor, VGXY61_REG_MODEL_ID);
vvv CID 1527257: Control flow issues (NO_EFFECT)
vvv This less-than-zero comparison of an unsigned value is never true. "id < 0".

1679     	if (id < 0)
1680     		return id;
1681     	if (id != VG5661_MODEL_ID && id != VG5761_MODEL_ID) {
1682     		dev_warn(&client->dev, "Unsupported sensor id %x\n", id);
1683     		return -ENODEV;
1684     	}

If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first):

Addresses-Coverity-ID: 1527257 ("Control flow issues")

Thanks for your attention!

Coverity-bot

Hello,

Thank you for your report.

This issue, and all other reported control flow issues, are fixed in the following patch: 'media: i2c: st-vgxy61: Fix smatch warnings'.
https://lore.kernel.org/linux-media/[email protected]/

Regards,

Benjamin