net/ice: fix ice_interrupt_handler panic when stop
PATCH 1/1 net/ice: fix ice_interrupt_handler panic when stop
rte_intr_callback_unregister may fail when irq cb is in handling, use sync version to make sure unregister successfully.
--- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ice/ice_ethdev.c +2 -2
@@ -2596,8 +2596,8 @@ ice_dev_close(struct rte_eth_dev *dev)rte_intr_disable (intr_handle);/* unregister callback func from eal lib */ -rte_intr_callback_unregister (intr_handle, - ice_interrupt_handler, dev); +rte_intr_callback_unregister_sync (intr_handle, + ice_interrupt_handler, dev);return ret; }
Signature · 1 line
2.34.1
PATCH v2 1/1 net/ice: fix ice_interrupt_handler panic when stop
rte_intr_callback_unregister may fail when irq cb is in handling, use sync version to make sure unregister successfully.
--- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ice/ice_ethdev.c +2 -2
@@ -2596,8 +2596,8 @@ ice_dev_close(struct rte_eth_dev *dev)rte_intr_disable (intr_handle);/* unregister callback func from eal lib */ -rte_intr_callback_unregister (intr_handle, - ice_interrupt_handler, dev); +rte_intr_callback_unregister_sync (intr_handle, + ice_interrupt_handler, dev);return ret; }
Signature · 1 line
2.34.1
PATCH v3 1/1 net/ice: fix ice_interrupt_handler panic when stop
In reply to Du, Frankrte_intr_callback_unregister may fail when irq cb is in handling, use sync version to make sure unregister successfully.
---
v3:
* Move rte_intr_callback_unregister_sync to right after irq disable
--- drivers/net/ice/ice_ethdev.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)
drivers/net/ice/ice_ethdev.c +8 -7
@@ -2555,12 +2555,17 @@ ice_dev_close(struct rte_eth_dev *dev)return 0 ;/* Since stop will make link down, then the link event will be -* triggered, disable the irq firstly to avoid the port_infoe etc -* resources deallocation causing the interrupt service thread -* crash. +* triggered, disable the irq firstly. */ ice_pf_disable_irq0 (hw); +/* Unregister callback func from eal lib, use sync version to +* make sure all active interrupt callbacks is done, then it's +* safe to free all resources. +*/ +rte_intr_callback_unregister_sync (intr_handle, + ice_interrupt_handler, dev); + ret =ice_dev_stop (dev);if (!ad->is_safe_mode)
@@ -2595,10 +2600,6 @@ ice_dev_close(struct rte_eth_dev *dev)/* disable uio intr before callback unregister */ rte_intr_disable (intr_handle); -/* unregister callback func from eal lib */ -rte_intr_callback_unregister (intr_handle, - ice_interrupt_handler, dev); -return ret; }
Signature · 1 line
2.34.1
Quoted 10 lines
-----Original Message-----
From: Du, Frank <[email protected]>
Sent: Monday, November 14, 2022 3:03 PM
To: [email protected]
Subject: [PATCH v3] net/ice: fixice_interrupt_handlerpanic when stop
rte_intr_callback_unregistermay fail when irq cb is in handling, use sync version to make sure unregister successfully.
Added:
Quoted 2 lines
Signed-off-by Du, Frank <[email protected]>
Corrected:
s/Du, Frank/Frank Du
Applied to dpdk-next-net-intel.
Thanks
Qi