mmc: sdhci: Fix the SD tuning issue that the SDHCI_TRANSFER_MODE is cleared incorrectly
PATCH v3 1/1 mmc: sdhci: Fix the SD tuning issue that the SDHCI_TRANSFER_MODE is cleared incorrectly
When cmd->opcode == MMC_SEND_TUNING_BLOCK, the SDHCI_TRANSFER_MODE should also be kept
---
change in V1:
Keeping the SDHCI_TRANSFER_MODE when cmd->opcode == MMC_END_TUNING_BLOCK
change in V2:
add the mmc_op_tuning interface to judge if the opcode is tuning CMD
change in V3:
cancel the redundant code
--- drivers/mmc/host/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci.c +1 -1
@@ -1465,7 +1465,7 @@ static void sdhci_set_transfer_mode(struct sdhci_host *host,if (host->quirks2 &SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD ) {/* must not clear SDHCI_TRANSFER_MODE when tuning */ -if (cmd->opcode !=MMC_SEND_TUNING_BLOCK_HS200 ) +if (!mmc_op_tuning (cmd->opcode))sdhci_writew (host,0x0 ,SDHCI_TRANSFER_MODE ); }else {/* clear Auto CMD settings for no data CMDs */
Signature · 1 line
2.32.0
Quoted 4 lines · Charl Liu
When
cmd->opcode==MMC_SEND_TUNING_BLOCK, theSDHCI_TRANSFER_MODEshould also be keptSigned-off-by Charl Liu <[email protected]>
Quoted 26 lines
---
change in V1:
Keeping theSDHCI_TRANSFER_MODEwhencmd->opcode==MMC_END_TUNING_BLOCKchange in V2:
add themmc_op_tuninginterface to judge if the opcode is tuning CMDchange in V3:
cancel the redundant code--- drivers/mmc/host/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/sdhci.c +1
-1@@ -1465,7 +1465,7 @@ static void sdhci_set_transfer_mode(struct sdhci_host *host,if (host->quirks2 &SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD ) {/* must not clear SDHCI_TRANSFER_MODE when tuning */ -if (cmd->opcode !=MMC_SEND_TUNING_BLOCK_HS200 ) +if (!mmc_op_tuning (cmd->opcode))sdhci_writew (host,0x0 ,SDHCI_TRANSFER_MODE ); }else {/* clear Auto CMD settings for no data CMDs */
Quoted 5 lines · Charl Liu
When
cmd->opcode==MMC_SEND_TUNING_BLOCK, theSDHCI_TRANSFER_MODEshould also be keptSigned-off-by Charl Liu <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 29 lines
---
change in V1:
Keeping theSDHCI_TRANSFER_MODEwhencmd->opcode==MMC_END_TUNING_BLOCKchange in V2:
add themmc_op_tuninginterface to judge if the opcode is tuning CMDchange in V3:
cancel the redundant code--- drivers/mmc/host/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/sdhci.c +1
-2@@ -1465,7 +1465,7 @@ static void sdhci_set_transfer_mode(struct sdhci_host *host,if (host->quirks2 &SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD ) {/* must not clear SDHCI_TRANSFER_MODE when tuning */ -if (cmd->opcode !=MMC_SEND_TUNING_BLOCK_HS200 ) +if (!mmc_op_tuning (cmd->opcode))sdhci_writew (host,0x0 ,SDHCI_TRANSFER_MODE ); }else {/* clear Auto CMD settings for no data CMDs */ --2.32.0