Add vulkan validation and improvements for headless devices
cover Add vulkan validation and improvements for headless devices
This small patchset has a few small fixes and a new recipe for the official Vulkan validation layers from Khronos.
The first patch addresses a bug in the exported cmake packages from spriv-tools to make sure that the library path is correctly set. The second patch enables vulkan-loader for "headless" devices that don't have either X11 nor Wayland. The third patch adds the vulkan-validation for the same version level as the Vulkan headers and other packages.
Jordan Crouse (3):
spirv-tools: Correctly set the prefix in exported cmake packages
vulkan-loader: Allow headless targets to build the loader
vulkan-validation: Add the official Vulkan validation layers
.../spir/spirv-tools_1.3.231.1.bb | 7 ++- .../vulkan/vulkan-loader_1.3.231.1.bb | 2 - .../vulkan/vulkan-validation_1.3.231.1.bb | 46 +++++++++++++++++++ 3 files changed, 51 insertions(+), 4 deletions(-) create mode 100644 meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb
Signature · 1 line
2.37.1
PATCH 1/3 spirv-tools: Correctly set the prefix in exported cmake packages
spirv-tools exports Cmake packages. When they are installed the INTERFACE_LINK_LIBRARIES variable is not correctly updated to use _IMPORT_PREFIX like the other variables. This may have something to do with the path to the sysroot being different than the source path.
The existing recipe recognizes that the sysroot path made it through to the install and tries to get rid of it, but this just ends up with dependent tools looking in vain for /usr/lib/librt.so.
Replace the INTERFACE_LINK_LIBRARIES value in SPIRV-ToolsTarget.cmake with "${IMPORT_PREFIX}/lib".
---
meta/recipes-graphics/spir/spirv-tools_1.3.231.1.bb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
meta/recipes-graphics/spir/spirv-tools_1.3.231.1.bb +5 -2
@@ -10,6 +10,8 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57" SRCREV = "eb0a36633d2acf4de82588504f951ad0f2cecacb" SRC_URI = "git://github.com/KhronosGroup/SPIRV-Tools.git;branch=master;protocol=https" PE = "1" +PR = "r1" + UPSTREAM_CHECK_GITTAGREGEX = "sdk-(?P<pver>\d+(\.\d+)+)" S = "${WORKDIR}/git"
@@ -25,9 +27,10 @@ EXTRA_OECMAKE += "\ " do_install:append:class-target() { - # reproducibility: remove build host path + # Properly set _IMPORT_PREFIX in INTERFACE_LINK_LIBRARIES so that dependent + # tools can find the right library sed -i ${D}${libdir}/cmake/SPIRV-Tools/SPIRV-ToolsTarget.cmake \ - -e 's:${STAGING_DIR_HOST}::g' + -e 's:INTERFACE_LINK_LIBRARIES.*$:INTERFACE_LINK_LIBRARIES "\$\{_IMPORT_PREFIX\}/lib":' } # all the libraries are unversioned, so don't pack it on PN-dev
Signature · 1 line
2.37.1
Re: [OE-core] [PATCH 1/3] spirv-tools: Correctly set the prefix in exported cmake packages
Quoted 24 lines · Jordan Crouse via lists.openembedded.org
spirv-tools exports Cmake packages. When they are installed the
INTERFACE_LINK_LIBRARIESvariable is not correctly updated to use_IMPORT_PREFIXlike the other variables. This may have something to do with the path to the sysroot being different than the source path.The existing recipe recognizes that the sysroot path made it through to the install and tries to get rid of it, but this just ends up with dependent tools looking in vain for
/usr/lib/librt.so.Replace the
INTERFACE_LINK_LIBRARIESvalue in SPIRV-ToolsTarget.cmake with "${IMPORT_PREFIX}/lib".Signed-off-by Jordan Crouse <[email protected]>---
meta/recipes-graphics/spir/spirv-tools_1.3.231.1.bb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)meta/recipes-graphics/spir/spirv-tools_1.3.231.1.bb +0
-0
meta/recipes-graphics/spir/spirv-tools_1.3.231.1.bb LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57" · line 13
Quoted 4 lines
meta/recipes-graphics/spir/spirv-tools_1.3.231.1.bb +1
-0@@ -10,6 +10,8 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57" SRCREV = "eb0a36633d2acf4de82588504f951ad0f2cecacb" SRC_URI = "git://github.com/KhronosGroup/SPIRV-Tools.git;branch=master;protocol=https" PE = "1" +PR = "r1"
We no longer bump the PR manually. So this is not needed.
Quoted 29 lines
meta/recipes-graphics/spir/spirv-tools_1.3.231.1.bb +4
-3+ UPSTREAM_CHECK_GITTAGREGEX = "sdk-(?P<pver>\d+(\.\d+)+)" S = "${WORKDIR}/git"@@ -25,9 +27,10 @@ EXTRA_OECMAKE += "\ " do_install:append:class-target() { - # reproducibility: remove build host path + # Properly set _IMPORT_PREFIX in INTERFACE_LINK_LIBRARIES so that dependent + # tools can find the right library sed -i ${D}${libdir}/cmake/SPIRV-Tools/SPIRV-ToolsTarget.cmake \ - -e 's:${STAGING_DIR_HOST}::g' + -e 's:INTERFACE_LINK_LIBRARIES.*$:INTERFACE_LINK_LIBRARIES "\$\{_IMPORT_PREFIX\}/lib":' } # all the libraries are unversioned, so don't pack it on PN-dev --2.37.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#173108): https://lists.openembedded.org/g/openembedded-core/message/173108
Mute This Topic: https://lists.openembedded.org/mt/94945230/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 1/3] spirv-tools: Correctly set the prefix in exported cmake packages
In reply to Jordan CrouseJordan Crouse via lists.openembedded.org <jorcrous= [email protected]> escreveu no dia quinta, 10/11/2022 à(s) 20:42:
Quoted 45 lines
spirv-tools exports Cmake packages. When they are installed the
INTERFACE_LINK_LIBRARIESvariable is not correctly updated to use_IMPORT_PREFIXlike the other variables. This may have something to do with the path to the sysroot being different than the source path.The existing recipe recognizes that the sysroot path made it through to the install and tries to get rid of it, but this just ends up with dependent tools looking in vain for
/usr/lib/librt.so.Replace the
INTERFACE_LINK_LIBRARIESvalue in SPIRV-ToolsTarget.cmake with "${IMPORT_PREFIX}/lib".Signed-off-by Jordan Crouse <[email protected]>---
meta/recipes-graphics/spir/spirv-tools_1.3.231.1.bb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)meta/recipes-graphics/spir/spirv-tools_1.3.231.1.bb +0
-0@@ -10,6 +10,8 @@ LIC_FILES_CHKSUM ="file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
SRCREV = "eb0a36633d2acf4de82588504f951ad0f2cecacb"SRC_URI= "git://
github.com/KhronosGroup/SPIRV-Tools.git;branch=master;protocol=https"
PE = "1"meta/recipes-graphics/spir/spirv-tools_1.3.231.1.bb +3
-1+PR = "r1" + UPSTREAM_CHECK_GITTAGREGEX = "sdk-(?P<pver>\d+(\.\d+)+)" S = "${WORKDIR}/git"@@ -25,9 +27,10 @@ EXTRA_OECMAKE += "\ " do_install:append:class-target() { - # reproducibility: remove build host path + # Properly set _IMPORT_PREFIX in INTERFACE_LINK_LIBRARIES so thatdependent
meta/recipes-graphics/spir/spirv-tools_1.3.231.1.bb +2
-1+ # tools can find the right library sed -i ${D}${libdir}/cmake/SPIRV-Tools/SPIRV-ToolsTarget.cmake \ - -e 's:${STAGING_DIR_HOST}::g' + -e 's:INTERFACE_LINK_LIBRARIES.*$:INTERFACE_LINK_LIBRARIES
Quoted 2 lines
"\$\{_IMPORT_PREFIX\}/lib":'
As this change don't use any bitbake variable can it be done patching the cmake source file?
Jose
Quoted 18 lines
}
# all the libraries are unversioned, so don't pack it on PN-dev -- 2.37.1-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#173108):
https://lists.openembedded.org/g/openembedded-core/message/173108
Mute This Topic: https://lists.openembedded.org/mt/94945230/5052612
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Best regards, José Quaresma
PATCH 2/3 vulkan-loader: Allow headless targets to build the loader
In reply to Jordan Crousevulkan-loader can build and work on headless targets without display engines so there isn't any need for the ANY_OF_DISTRO_FEATURES restriction.
---
meta/recipes-graphics/vulkan/vulkan-loader_1.3.231.1.bb | 2 -- 1 file changed, 2 deletions(-)
meta/recipes-graphics/vulkan/vulkan-loader_1.3.231.1.bb +0 -2
@@ -17,7 +17,6 @@ S = "${WORKDIR}/git" REQUIRED_DISTRO_FEATURES = "vulkan" inherit cmake features_check pkgconfig -ANY_OF_DISTRO_FEATURES = "x11 wayland" DEPENDS += "vulkan-headers"
@@ -29,7 +28,6 @@ EXTRA_OECMAKE = "\ -DVulkanRegistry_DIR=${RECIPE_SYSROOT}/${datadir} \ " -# must choose x11 or wayland or both PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'wayland x11', d)}" PACKAGECONFIG[x11] = "-DBUILD_WSI_XLIB_SUPPORT=ON -DBUILD_WSI_XCB_SUPPORT=ON, -DBUILD_WSI_XLIB_SUPPORT=OFF -DBUILD_WSI_XCB_SUPPORT=OFF, libxcb libx11 libxrandr"
Signature · 1 line
2.37.1
PATCH 3/3 vulkan-validation: Add the official Vulkan validation layers
In reply to Jordan CrouseAdd a recipe to build the Khronos official Vulkan validation layers that can assist developers in verifying that their applications correctly use the Vulkan APIs.
---
.../vulkan/vulkan-validation_1.3.231.1.bb | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb
meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb new file +46 -0
@@ -0,0 +1,46 @@ +SUMMARY = "Vulkan Validation layers" +DESCRIPTION = "Khronos official Vulkan validation layers to assist developers \ +in verifying that their applications correctly use the Vulkan API" +HOMEPAGE = "https://www.khronos.org/vulkan/" +BUGTRACKER = "https://github.com/KhronosGroup/Vulkan-ValidationLayers" +SECTION = "libs" + +LICENSE = "Apache-2.0" +LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=8df9e8826734226d08cb412babfa599c" +SRC_URI = "git://github.com/KhronosGroup/Vulkan-ValidationLayers.git;branch=sdk-1.3.231;protocol=https" + +SRCREV="f489610de566df6a5c20de1a3e54776e0ad852e1" + +S = "${WORKDIR}/git" + +REQUIRED_DISTRO_FEATURES = "vulkan" + +inherit cmake features_check pkgconfig + +DEPENDS += "vulkan-headers" +DEPENDS += "spirv-headers spirv-tools" +DEPENDS += "vulkan-loader" +DEPENDS += "glslang" + +EXTRA_OECMAKE = "\ + -DBUILD_TESTS=OFF \ + -DPYTHON_EXECUTABLE=${HOSTTOOLS_DIR}/python3 \ + -DASSEMBLER_WORKS=FALSE \ + -DVULKAN_HEADERS_INSTALL_DIR=${STAGING_EXECPREFIXDIR} \ + -DGLSLANG_INSTALL_DIR=${STAGING_DATADIR} \ + -DSPIRV_HEADERS_INSTALL_DIR=${STAGING_EXECPREFIXDIR} \ + -DUSE_ROBIN_HOOD_HASHING=OFF \ + " + +PACKAGECONFIG[x11] = "-DBUILD_WSI_XLIB_SUPPORT=ON -DBUILD_WSI_XCB_SUPPORT=ON, -DBUILD_WSI_XLIB_SUPPORT=OFF -DBUILD_WSI_XCB_SUPPORT=OFF, libxcb libx11 libxrandr" +PACKAGECONFIG[wayland] = "-DBUILD_WSI_WAYLAND_SUPPORT=ON, -DBUILD_WSI_WAYLAND_SUPPORT=OFF, wayland" + +FILES:${PN} += "/usr/share/vulkan/ /usr/lib/" + +INSANE_SKIP:${PN} += " ldflags" +INHIBIT_PACKAGE_STRIP = "1" +INHIBIT_SYSROOT_STRIP = "1" +SOLIBS = ".so" +FILES_SOLIBSDEV = "" + +UPSTREAM_CHECK_GITTAGREGEX = "sdk-(?P<pver>\d+(\.\d+)+)"
Signature · 1 line
2.37.1
Re: [OE-core] [PATCH 3/3] vulkan-validation: Add the official Vulkan validation layers
meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb line 23
Quoted 4 lines · Jordan Crouse via lists.openembedded.org
meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb new file +4
-0+DEPENDS += "vulkan-headers" +DEPENDS += "spirv-headers spirv-tools" +DEPENDS += "vulkan-loader" +DEPENDS += "glslang"
This should be squashed into a single line.
meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb line 33
Quoted 10 lines
meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb new file +10
-0+ +EXTRA_OECMAKE = "\ + -DBUILD_TESTS=OFF \ + -DPYTHON_EXECUTABLE=${HOSTTOOLS_DIR}/python3 \ + -DASSEMBLER_WORKS=FALSE \ + -DVULKAN_HEADERS_INSTALL_DIR=${STAGING_EXECPREFIXDIR} \ + -DGLSLANG_INSTALL_DIR=${STAGING_DATADIR} \ + -DSPIRV_HEADERS_INSTALL_DIR=${STAGING_EXECPREFIXDIR} \ + -DUSE_ROBIN_HOOD_HASHING=OFF \ + "
Some of the choices here would be good to explain in the commit message. What is this 'robin hood hashing' and why do we not want it? :)
meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb line 36
Quoted 3 lines
meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb new file +3
-0+ +PACKAGECONFIG[x11] = "-DBUILD_WSI_XLIB_SUPPORT=ON -DBUILD_WSI_XCB_SUPPORT=ON, -DBUILD_WSI_XLIB_SUPPORT=OFF -DBUILD_WSI_XCB_SUPPORT=OFF, libxcb libx11 libxrandr" +PACKAGECONFIG[wayland] = "-DBUILD_WSI_WAYLAND_SUPPORT=ON, -DBUILD_WSI_WAYLAND_SUPPORT=OFF, wayland"
These should be enabled by default subject to DISTRO_FEATURES.
meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb line 44
Quoted 7 lines
meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb new file +7
-0+FILES:${PN} += "/usr/share/vulkan/ /usr/lib/" + +INSANE_SKIP:${PN} += " ldflags" +INHIBIT_PACKAGE_STRIP = "1" +INHIBIT_SYSROOT_STRIP = "1" +SOLIBS = ".so" +FILES_SOLIBSDEV = ""
All of the above should be removed. If there are error messages due to that, please show them, and we'll figure out how to address them properly.
New recipes also need a meta/conf/distro/inclue/maintainers.inc entry.
Alex
Re: [OE-core] [PATCH 3/3] vulkan-validation: Add the official Vulkan validation layers
Quoted 1 line · Alexander Kanavin
On Thu, 10 Nov 2022 at 21:42, Jordan Crouse via lists.openembedded.org
<snip>
Quoted 11 lines
meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb line 44
Quoted 7 lines
meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb new file +7
-0+FILES:${PN} += "/usr/share/vulkan/ /usr/lib/" + +INSANE_SKIP:${PN} += " ldflags" +INHIBIT_PACKAGE_STRIP = "1" +INHIBIT_SYSROOT_STRIP = "1" +SOLIBS = ".so" +FILES_SOLIBSDEV = ""All of the above should be removed. If there are error messages due to that, please show them, and we'll figure out how to address them properly.
ERROR: vulkan-validation-1.3.231.1-r0 do_package_qa: QA Issue: -dev package vulkan-validation-dev contains non-symlink .so '/usr/lib/libVkLayer_khronos_validation.so' [dev-elf]
I borrowed the QA inhibit from vulkan-loader (since they are built mostly the same) but if there is a different path forward, that would be great.
Jordan
Re: [OE-core] [PATCH 3/3] vulkan-validation: Add the official Vulkan validation layers
Quoted 5 lines · Jordan Crouse
ERROR: vulkan-validation-1.3.231.1-r0
do_package_qa: QA Issue: -dev package vulkan-validation-dev contains non-symlink .so '/usr/lib/libVkLayer_khronos_validation.so' [dev-elf]I borrowed the QA inhibit from vulkan-loader (since they are built mostly the same) but if there is a different path forward, that would be great.
Thanks. I am not seeing QA inhibits or any special handling in the current vulkan-loader:
https://git.yoctoproject.org/poky/tree/meta/recipes-graphics/vulkan/vulkan-loader_1.3.231.1.bb?h=master-next
Can you find out why the /usr/lib/libVkLayer_khronos_validation.so is built unversioned and where in the source tree that decision is made?
We generally require that everything in $libdir is versioned, and .so is a development symlink to versioned originals.
Alex
Re: [OE-core] [PATCH 3/3] vulkan-validation: Add the official Vulkan validation layers
Quoted 10 lines · Alexander Kanavin
Quoted 5 lines · Jordan Crouse
ERROR: vulkan-validation-1.3.231.1-r0
do_package_qa: QA Issue: -dev package vulkan-validation-dev contains non-symlink .so '/usr/lib/libVkLayer_khronos_validation.so' [dev-elf]I borrowed the QA inhibit from vulkan-loader (since they are built mostly the same) but if there is a different path forward, that would be great.
Thanks. I am not seeing QA inhibits or any special handling in the current vulkan-loader:
https://git.yoctoproject.org/poky/tree/meta/recipes-graphics/vulkan/vulkan-loader_1.3.231.1.bb?h=master-next
That was my mistake, I guess I don't clearly remember why these were added in our downstream tree - clearly a poorly executed effort at getting rid of the error.
Quoted 2 lines
Can you find out why the
/usr/lib/libVkLayer_khronos_validation.sois built unversioned and where in the source tree that decision is made?
These libraries (plugins, really) are dynamically loaded by the vulkan-loader at runtime.
I couldn't immediately find an standard online but a cursory glance of the vulkan drivers/layers from other distros use a .so format, for example:
https://packages.debian.org/buster/amd64/mesa-vulkan-drivers/filelist
And from mesa in OE:
https://git.openembedded.org/openembedded-core/tree/meta/recipes-graphics/mesa/mesa.inc#n304
I agree that the existing INSANE_SKIP was the wrong way to go about it - perhaps the better option would be to do this:
FILES:${PN} = "${libdir}/*.so ${datadir}/vulkan"
I think ${PN}-dev would nominally be empty anyway - the two outputs of this package are .so layers and a .manifest file for the loader.
Jordan
Re: [OE-core] [PATCH 3/3] vulkan-validation: Add the official Vulkan validation layers
Quoted 8 lines · Jordan Crouse
I agree that the existing
INSANE_SKIPwas the wrong way to go about it - perhaps the better option would be to do this:FILES:${PN} = "${libdir}/*.so ${datadir}/vulkan"
I think ${PN}-dev would nominally be empty anyway - the two outputs of this package are .so layers and a .manifest file for the loader.
I suppose we can do it that way. You need to send a v2. :)
Alex
Re: [OE-core] [PATCH 3/3] vulkan-validation: Add the official Vulkan validation layers
In reply to Jordan CrouseHello,
Quoted 4 lines · Jordan Crouse via lists.openembedded.org
Add a recipe to build the Khronos official Vulkan validation layers that can assist developers in verifying that their applications correctly use the Vulkan APIs.
This failed on the autobuilders:
NOTE: recipe vulkan-validation-1.3.231.1-r0: task do_compile: Started
ERROR: vulkan-validation-1.3.231.1-r0 do_compile: ExecutionError('/home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/run.do_compile.3939056', 1, None, None)
ERROR: Logfile of failure stored in: /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/log.do_compile.3939056
Log data follows:
| DEBUG: Executing shell function do_compile
| NOTE: VERBOSE=1 cmake --build /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/build --target all --
| ninja: error: '/home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/recipe-sysroot/usr/lib', needed by 'layers/libVkLayer_khronos_validation.so', missing and no known rule to make it
| WARNING: /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/run.do_compile.3939056:153 exit 1 from 'eval ${DESTDIR:+DESTDIR=${DESTDIR} }VERBOSE=1 cmake --build '/home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/build' "$@" -- ${EXTRA_OECMAKE_BUILD}'
| WARNING: Backtrace (BB generated script):
| #1: cmake_runcmake_build, /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/run.do_compile.3939056, line 153
| #2: cmake_do_compile, /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/run.do_compile.3939056, line 147
| #3: do_compile, /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/run.do_compile.3939056, line 142
| #4: main, /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/run.do_compile.3939056, line 166NOTE: recipe vulkan-validation-1.3.231.1-r0: task do_compile: Failed
ERROR: Task (/home/pokybuild/yocto-worker/qemux86-world/build/meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb:do_compile) failed with exit code '1'
https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/6064/steps/11/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/3735/steps/12/logs/stdio
Quoted 72 lines
Signed-off-by Jordan Crouse <[email protected]>---
.../vulkan/vulkan-validation_1.3.231.1.bb | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bbmeta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb new file +46
-0@@ -0,0 +1,46 @@ +SUMMARY = "Vulkan Validation layers" +DESCRIPTION = "Khronos official Vulkan validation layers to assist developers \ +in verifying that their applications correctly use the Vulkan API" +HOMEPAGE = "https://www.khronos.org/vulkan/" +BUGTRACKER = "https://github.com/KhronosGroup/Vulkan-ValidationLayers" +SECTION = "libs" + +LICENSE = "Apache-2.0" +LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=8df9e8826734226d08cb412babfa599c" +SRC_URI = "git://github.com/KhronosGroup/Vulkan-ValidationLayers.git;branch=sdk-1.3.231;protocol=https" + +SRCREV="f489610de566df6a5c20de1a3e54776e0ad852e1" + +S = "${WORKDIR}/git" + +REQUIRED_DISTRO_FEATURES = "vulkan" + +inherit cmake features_check pkgconfig + +DEPENDS += "vulkan-headers" +DEPENDS += "spirv-headers spirv-tools" +DEPENDS += "vulkan-loader" +DEPENDS += "glslang" + +EXTRA_OECMAKE = "\ + -DBUILD_TESTS=OFF \ + -DPYTHON_EXECUTABLE=${HOSTTOOLS_DIR}/python3 \ + -DASSEMBLER_WORKS=FALSE \ + -DVULKAN_HEADERS_INSTALL_DIR=${STAGING_EXECPREFIXDIR} \ + -DGLSLANG_INSTALL_DIR=${STAGING_DATADIR} \ + -DSPIRV_HEADERS_INSTALL_DIR=${STAGING_EXECPREFIXDIR} \ + -DUSE_ROBIN_HOOD_HASHING=OFF \ + " + +PACKAGECONFIG[x11] = "-DBUILD_WSI_XLIB_SUPPORT=ON -DBUILD_WSI_XCB_SUPPORT=ON, -DBUILD_WSI_XLIB_SUPPORT=OFF -DBUILD_WSI_XCB_SUPPORT=OFF, libxcb libx11 libxrandr" +PACKAGECONFIG[wayland] = "-DBUILD_WSI_WAYLAND_SUPPORT=ON, -DBUILD_WSI_WAYLAND_SUPPORT=OFF, wayland" + +FILES:${PN} += "/usr/share/vulkan/ /usr/lib/" + +INSANE_SKIP:${PN} += " ldflags" +INHIBIT_PACKAGE_STRIP = "1" +INHIBIT_SYSROOT_STRIP = "1" +SOLIBS = ".so" +FILES_SOLIBSDEV = "" + +UPSTREAM_CHECK_GITTAGREGEX = "sdk-(?P<pver>\d+(\.\d+)+)"Signature · 11 lines
2.37.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#173105): https://lists.openembedded.org/g/openembedded-core/message/173105 Mute This Topic: https://lists.openembedded.org/mt/94945225/3617179 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [OE-core] [PATCH 3/3] vulkan-validation: Add the official Vulkan validation layers
Quoted 24 lines · Alexandre Belloni
Hello,
Quoted 4 lines · Jordan Crouse via lists.openembedded.org
Add a recipe to build the Khronos official Vulkan validation layers that can assist developers in verifying that their applications correctly use the Vulkan APIs.
This failed on the autobuilders:
NOTE: recipe vulkan-validation-1.3.231.1-r0: task
do_compile: Started
ERROR: vulkan-validation-1.3.231.1-r0do_compile: ExecutionError('/home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/run.do_compile.3939056', 1, None, None)
ERROR: Logfile of failure stored in:/home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/log.do_compile.3939056
Log data follows:| DEBUG: Executing shell function do_compile | NOTE: VERBOSE=1 cmake --build /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/build --target all -- | ninja: error: '/home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/recipe-sysroot/usr/lib', needed by 'layers/libVkLayer_khronos_validation.so', missing and no known rule to make it | WARNING: /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/run.do_compile.3939056:153 exit 1 from 'eval ${DESTDIR:+DESTDIR=${DESTDIR} }VERBOSE=1 cmake --build '/home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/build' "$@" -- ${EXTRA_OECMAKE_BUILD}' | WARNING: Backtrace (BB generated script): | #1: cmake_runcmake_build, /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/run.do_compile.3939056, line 153 | #2: cmake_do_compile, /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/run.do_compile.3939056, line 147 | #3: do_compile, /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/run.do_compile.3939056, line 142 | #4: main, /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/vulkan-validation/1.3.231.1-r0/temp/run.do_compile.3939056, line 166
Quoted 6 lines
NOTE: recipe vulkan-validation-1.3.231.1-r0: task
do_compile: Failed
ERROR: Task (/home/pokybuild/yocto-worker/qemux86-world/build/meta/recipes-graphics/vulkan/vulkan-validation_1.3.231.1.bb:do_compile) failed with exit code '1'https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/6064/steps/11/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/3735/steps/12/logs/stdio
Thanks, I'll see if I can figure out what happened here.
Jordan
Re: [PATCH 3/3] vulkan-validation: Add the official Vulkan validation layers
Hello,
Is there any status on this? I'd definitely benefit from this.
Re: [OE-core] [PATCH 3/3] vulkan-validation: Add the official Vulkan validation layers
Given that this was in November last year, I think the best course of action is for you to take the proposed patch and fix it into a state that can be merged.
Alex
Quoted 12 lines · Vincent Davis Jr
Hello,
Is there any status on this? I'd definitely benefit from this.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#182122): https://lists.openembedded.org/g/openembedded-core/message/182122
Mute This Topic: https://lists.openembedded.org/mt/94945225/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 3/3] vulkan-validation: Add the official Vulkan validation layers
Quoted 7 lines · Alexander Kanavin
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
Given that this was in November last year, I think the best course of action is for you to take the proposed patch and fix it into a state that can be merged.
I couldn't figure out why it kept failing the verification. I need to pick it back up but I got distracted by other things. If you manage to figure it out, please merge on with my blessing.
Jordan
Re: [OE-core] [PATCH 3/3] vulkan-validation: Add the official Vulkan validation layers
I didn't actually use the recipe in any way, nor have plans to do so :) My involvement is limited to bring it in sync with the rest of vulkan items and do code reviews, but primary maintenance is on you.
Alex
Quoted 15 lines · Jordan Crouse
Quoted 7 lines · Alexander Kanavin
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
Given that this was in November last year, I think the best course of action is for you to take the proposed patch and fix it into a state that can be merged.
I couldn't figure out why it kept failing the verification. I need to pick it back up but I got distracted by other things. If you manage to figure it out, please merge on with my blessing.
Jordan
Re: [PATCH 3/3] vulkan-validation: Add the official Vulkan validation layers
In reply to Jordan CrouseHey Jordan,
Yeah, the issue turned out to be a property set in SPIRV-ToolsTarget.cmake. Commit bellow should explain Although ${base_libdir} should of been ${baselib}.
https://lists.openembedded.org/g/openembedded-core/message/182445
Also, renamed recipe to vulkan-validation-layers. Let me know if you have issues everything looks good in my setup.
https://lists.openembedded.org/g/openembedded-core/message/182446