Skip to contentSkip to conversation

HID: hid-sensor-custom: Allow more than one hinge angle sensor

PATCH Applied Yauhen Kharuzhy 4 participants 6 messages Nov 5, 2022 – Nov 14, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: hid-sensor-custom: Allow more than one hinge angle sensor

Some devices has two sets of accelerometers and the sensor hub exports two hinge angle 'sensors' based on accelerometer values. To allow more than one sensor of the same type, use PLATFORM_DEVID_AUTO instead of PLATFORM_DEVID_NONE when registering platform device for it.

Checked on the Lenovo Yoga Book YB1-X91L tablet.

---
 drivers/hid/hid-sensor-custom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-sensor-custom.c +1 -1
index 32c2306e240d6..a6fc89ee1287c 100644
@@ -862,7 +862,7 @@ hid_sensor_register_platform_device(struct platform_device *pdev,
 		return ERR_PTR(-ENOMEM);
 
 	custom_pdev = platform_device_register_data(pdev->dev.parent, dev_name,
-						    PLATFORM_DEVID_NONE, hsdev,
+						    PLATFORM_DEVID_AUTO, hsdev,
 						    sizeof(*hsdev));
 	kfree(dev_name);
 	return custom_pdev;
Signature · 1 line
2.38.1
maintainer
#1 lore raw
Quoted 8 lines · On Sun, 6 Nov 2022 00:34:22 +0200 Yauhen Kharuzhy <[email protected]> wrote:

Some devices has two sets of accelerometers and the sensor hub exports two hinge angle 'sensors' based on accelerometer values. To allow more than one sensor of the same type, use PLATFORM_DEVID_AUTO instead of PLATFORM_DEVID_NONE when registering platform device for it.

Checked on the Lenovo Yoga Book YB1-X91L tablet.

Purely for curiosity sake, but where are the two sets of sensors? Doesn't look like it has two hinges at first glance!

Jonathan

Quoted 17 lines
---
 drivers/hid/hid-sensor-custom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-sensor-custom.c +1 -1
index 32c2306e240d6..a6fc89ee1287c 100644
@@ -862,7 +862,7 @@ hid_sensor_register_platform_device(struct platform_device *pdev,
 		return ERR_PTR(-ENOMEM);
 
 	custom_pdev = platform_device_register_data(pdev->dev.parent, dev_name,
-						    PLATFORM_DEVID_NONE, hsdev,
+						    PLATFORM_DEVID_AUTO, hsdev,
 						    sizeof(*hsdev));
 	kfree(dev_name);
 	return custom_pdev;
#2 lore raw
Quoted 8 lines · Jonathan Cameron
Quoted 5 lines · On Sun, 6 Nov 2022 00:34:22 +0200 Yauhen Kharuzhy <[email protected]> wrote:

Some devices has two sets of accelerometers and the sensor hub exports two hinge angle 'sensors' based on accelerometer values. To allow more than one sensor of the same type, use PLATFORM_DEVID_AUTO instead of PLATFORM_DEVID_NONE when registering platform device for it.

Quoted 6 lines
Quoted 3 lines

Checked on the Lenovo Yoga Book YB1-X91L tablet.

Purely for curiosity sake, but where are the two sets of sensors? Doesn't look like it has two hinges at first glance!

It sounds crazy, yes :)

The Lenovo Yoga Book YB1-X91L looks to be strange device in many ways.

There are two accelerometers at display side and two at keyboard side (for detecting the rotation movement as I understand). For
some reasons ISH exposed two virtual hinge angle sensors (I guess that one for each pair of accelerometers):

...

[    6.230627] Registering platform device 'HID-SENSOR-INT-020b.35.auto'. Parent at 001F:8087:0AC2.0005
[    6.230658] device: 'HID-SENSOR-INT-020b.35.auto': device_add
[    6.230705] bus: 'platform': add device HID-SENSOR-INT-020b.35.auto
[    6.230737] PM: Adding info for platform:HID-SENSOR-INT-020b.35.auto
...
[    6.249248] Registering platform device 'HID-SENSOR-INT-020b.36.auto'. Parent at 001F:8087:8AC2.0006
[    6.249266] device: 'HID-SENSOR-INT-020b.36.auto': device_add
[    6.249295] bus: 'platform': add device HID-SENSOR-INT-020b.36.auto
[    6.249394] PM: Adding info for platform:HID-SENSOR-INT-020b.36.auto

This is senseless but it is what it is. Moreover, this 'sensor' is always returns 360 degrees angle, although display and keyboard 'absolute' angles are reported correctly.

In any way, this patch is generic and will be useful for other custom HID sensors if they will be added in the future.

Quoted 21 lines

Jonathan

Quoted 17 lines
---
 drivers/hid/hid-sensor-custom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-sensor-custom.c +1 -1
index 32c2306e240d6..a6fc89ee1287c 100644
@@ -862,7 +862,7 @@ hid_sensor_register_platform_device(struct platform_device *pdev,
 		return ERR_PTR(-ENOMEM);
 
 	custom_pdev = platform_device_register_data(pdev->dev.parent, dev_name,
-						    PLATFORM_DEVID_NONE, hsdev,
+						    PLATFORM_DEVID_AUTO, hsdev,
 						    sizeof(*hsdev));
 	kfree(dev_name);
 	return custom_pdev;
Signature · 1 line
Yauhen Kharuzhy
maintainer Reviewed-by
#3 lore raw
Quoted 36 lines · On Sun, 6 Nov 2022 21:58:04 +0200 Yauhen Kharuzhy <[email protected]> wrote:
Quoted 8 lines · Jonathan Cameron
Quoted 5 lines · On Sun, 6 Nov 2022 00:34:22 +0200 Yauhen Kharuzhy <[email protected]> wrote:

Some devices has two sets of accelerometers and the sensor hub exports two hinge angle 'sensors' based on accelerometer values. To allow more than one sensor of the same type, use PLATFORM_DEVID_AUTO instead of PLATFORM_DEVID_NONE when registering platform device for it.

Quoted 6 lines
Quoted 3 lines

Checked on the Lenovo Yoga Book YB1-X91L tablet.

Purely for curiosity sake, but where are the two sets of sensors? Doesn't look like it has two hinges at first glance!

It sounds crazy, yes :)

The Lenovo Yoga Book YB1-X91L looks to be strange device in many ways.

There are two accelerometers at display side and two at keyboard side (for detecting the rotation movement as I understand). For
some reasons ISH exposed two virtual hinge angle sensors (I guess that one for each pair of accelerometers):

...

[    6.230627] Registering platform device 'HID-SENSOR-INT-020b.35.auto'. Parent at 001F:8087:0AC2.0005
[    6.230658] device: 'HID-SENSOR-INT-020b.35.auto': device_add
[    6.230705] bus: 'platform': add device HID-SENSOR-INT-020b.35.auto
[    6.230737] PM: Adding info for platform:HID-SENSOR-INT-020b.35.auto
...
[    6.249248] Registering platform device 'HID-SENSOR-INT-020b.36.auto'. Parent at 001F:8087:8AC2.0006
[    6.249266] device: 'HID-SENSOR-INT-020b.36.auto': device_add
[    6.249295] bus: 'platform': add device HID-SENSOR-INT-020b.36.auto
[    6.249394] PM: Adding info for platform:HID-SENSOR-INT-020b.36.auto
Quoted 6 lines

This is senseless but it is what it is. Moreover, this 'sensor' is always returns 360 degrees angle, although display and keyboard 'absolute' angles are reported correctly.

In any way, this patch is generic and will be useful for other custom HID sensors if they will be added in the future.

Thanks for the explanation.

Far as I'm concerned patch seems sensible.

Quoted 23 lines
Quoted 22 lines

Jonathan

Quoted 17 lines
---
 drivers/hid/hid-sensor-custom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-sensor-custom.c +1 -1
index 32c2306e240d6..a6fc89ee1287c 100644
@@ -862,7 +862,7 @@ hid_sensor_register_platform_device(struct platform_device *pdev,
 		return ERR_PTR(-ENOMEM);
 
 	custom_pdev = platform_device_register_data(pdev->dev.parent, dev_name,
-						    PLATFORM_DEVID_NONE, hsdev,
+						    PLATFORM_DEVID_AUTO, hsdev,
 						    sizeof(*hsdev));
 	kfree(dev_name);
 	return custom_pdev;  
maintainer Acked-by on v1 1/1
#4 lore raw
In reply to Yauhen Kharuzhy
Quoted 10 lines · Yauhen Kharuzhy

Some devices has two sets of accelerometers and the sensor hub exports
two hinge angle 'sensors' based on accelerometer values. To allow more
than one sensor of the same type, use PLATFORM_DEVID_AUTO instead of PLATFORM_DEVID_NONE when registering platform device for it.

Checked on the Lenovo Yoga Book YB1-X91L tablet.

Quoted 22 lines

---
 drivers/hid/hid-sensor-custom.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid- renamed from drivers/hid/hid-sensor-custom.c +0 -0

sensor-custom.c
index 32c2306e240d6..a6fc89ee1287c 100644

drivers/hid/hid-sensor-custom.c +0 -0
@@ -862,7 +862,7 @@ hid_sensor_register_platform_device(struct
 platform_device *pdev,
                 return ERR_PTR(-ENOMEM);


        custom_pdev = platform_device_register_data(pdev->dev.parent, dev_name,
-
PLATFORM_DEVID_NONE, hsdev,
+
PLATFORM_DEVID_AUTO, hsdev,
                                                    sizeof(*hsdev)); kfree(dev_name);
        return custom_pdev;

maintainer Applied
#5 lore raw
In reply to Yauhen Kharuzhy
Quoted 17 lines · Yauhen Kharuzhy

Some devices has two sets of accelerometers and the sensor hub exports two hinge angle 'sensors' based on accelerometer values. To allow more than one sensor of the same type, use PLATFORM_DEVID_AUTO instead of PLATFORM_DEVID_NONE when registering platform device for it.

Checked on the Lenovo Yoga Book YB1-X91L tablet.

---
 drivers/hid/hid-sensor-custom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-sensor-custom.c +0 -0
index 32c2306e240d6..a6fc89ee1287c 100644

drivers/hid/hid-sensor-custom.c hid_sensor_register_platform_device(struct platform_device *pdev, · line 868

Quoted 8 lines
drivers/hid/hid-sensor-custom.c +1 -1
@@ -862,7 +862,7 @@ hid_sensor_register_platform_device(struct platform_device *pdev,
 		return ERR_PTR(-ENOMEM);
 
 	custom_pdev = platform_device_register_data(pdev->dev.parent, dev_name,
-						    PLATFORM_DEVID_NONE, hsdev,
+						    PLATFORM_DEVID_AUTO, hsdev,
 						    sizeof(*hsdev));
 	kfree(dev_name);
 	return custom_pdev;

Applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs