Skip to contentSkip to conversation

: iio: light: rpr0521: add missing Kconfig dependencies

PATCH Superseded Paul Gazzillo 3 participants 8 messages Nov 10, 2022 – Nov 14, 2022 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : iio: light: rpr0521: add missing Kconfig dependencies

Steps to reproduce (v6.1-rc2, x86_64):

1. make defconfig menuconfig
2. Enable the driver:

    -> Device Drivers
      -> Industrial I/O support (IIO [=y])
        -> Light sensors
          -> ROHM RPR0521 ALS and proximity sensor driver

3. make drivers/iio/light/rpr0521.o

Causes "implicit declaration of function" errors, e.g.,

CC drivers/iio/light/rpr0521.o
drivers/iio/light/rpr0521.c: In function 'rpr0521_drdy_irq_thread':
drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function

           'iio_trigger_poll_chained' [-Werror=implicit-function-declaration]
    434 |   iio_trigger_poll_chained(data->drdy_trigger0);
        |   ^~~~~~~~~~~~~~~~~~~~~~~~

(This bug was found with the help of a tool, krepair, that generates configuration files for commits: https://github.com/paulgazz/kmax)

The following patch ensures that the code controlled by IIO_BUFFER and IIO_TRIGGERED_BUFFER is available:

---
 drivers/iio/light/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/light/Kconfig +2 -0
index 7cf6e8490123..0d4447df7200 100644
@@ -293,6 +293,8 @@ config RPR0521
 	tristate "ROHM RPR0521 ALS and proximity sensor driver"
 	depends on I2C
 	select REGMAP_I2C
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say Y here if you want to build support for ROHM's RPR0521
 	  ambient light and proximity sensor device.
Signature · 1 line
2.25.1
#1 lore raw
Quoted 8 lines · Paul Gazzillo

Steps to reproduce (v6.1-rc2, x86_64):

1. make defconfig menuconfig
2. Enable the driver:

    -> Device Drivers
      -> Industrial I/O support (IIO [=y])
        -> Light sensors
          -> ROHM RPR0521 ALS and proximity sensor driver
Quoted 6 lines

3. make drivers/iio/light/rpr0521.o

Causes "implicit declaration of function" errors, e.g.,

CC drivers/iio/light/rpr0521.o
drivers/iio/light/rpr0521.c: In function 'rpr0521_drdy_irq_thread':

These two lines can be removed.

Quoted 7 lines

drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function

           'iio_trigger_poll_chained' [-Werror=implicit-function-declaration]
    434 |   iio_trigger_poll_chained(data->drdy_trigger0);
        |   ^~~~~~~~~~~~~~~~~~~~~~~~

(This bug was found with the help of a tool, krepair, that generates configuration files for commits: https://github.com/paulgazz/kmax)

I'm not sure we need this in the commit message. Do we have a tag for the static analyzers?

Quoted 4 lines

The following patch ensures that the code controlled by IIO_BUFFER and IIO_TRIGGERED_BUFFER is available:

Without SoB this may not be anyhow proceeded. Please, read Submitting Patches documentation and try again.

(Btw, Reported-by above contradicts the commit message that refers to the tool,
and not human)

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 6 lines · Andy Shevchenko
Quoted 2 lines · Paul Gazzillo

CC drivers/iio/light/rpr0521.o
drivers/iio/light/rpr0521.c: In function 'rpr0521_drdy_irq_thread':

These two lines can be removed.

Will do.

Quoted 5 lines
Quoted 2 lines

(This bug was found with the help of a tool, krepair, that generates configuration files for commits: https://github.com/paulgazz/kmax)

I'm not sure we need this in the commit message. Do we have a tag for the static analyzers?

I'll also remove this.

Quoted 10 lines
Quoted 4 lines

The following patch ensures that the code controlled by IIO_BUFFER and IIO_TRIGGERED_BUFFER is available:

Without SoB this may not be anyhow proceeded. Please, read Submitting Patches documentation and try again.

(Btw, Reported-by above contradicts the commit message that refers to the tool,
and not human)

Apologies, I was confused about whether I or the maintainer fills that out. Will submit a new version with SoB.

Thanks!
Paul

Quoted 4 lines
Signature · 3 lines
-- 
With Best Regards,
Andy Shevchenko
#3 lore raw

PATCH v2 1/1 : iio: light: rpr0521: add missing Kconfig dependencies

In reply to Paul Gazzillo

Fix an implicit declaration of function error for rpr0521 under some configs

When CONFIG_RPR0521 is enabled without CONFIG_IIO_TRIGGERED_BUFFER, the build results in "implicit declaration of function" errors, e.g.,
drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function

           'iio_trigger_poll_chained' [-Werror=implicit-function-declaration]
    434 |   iio_trigger_poll_chained(data->drdy_trigger0);
        |   ^~~~~~~~~~~~~~~~~~~~~~~~

This fix adds select dependencies to RPR0521's configuration declaration.

---
V1 -> V2: Cleaned up commit message per reviewer comments and added link
to bug report.

 drivers/iio/light/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/light/Kconfig +2 -0
index 7cf6e8490123..0d4447df7200 100644
@@ -293,6 +293,8 @@ config RPR0521
 	tristate "ROHM RPR0521 ALS and proximity sensor driver"
 	depends on I2C
 	select REGMAP_I2C
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say Y here if you want to build support for ROHM's RPR0521
 	  ambient light and proximity sensor device.
Signature · 1 line
2.25.1
Reviewed-by on v2 1/1
#4 lore raw
Quoted 5 lines · Paul Gazzillo

Fix an implicit declaration of function error for rpr0521 under some configs

When CONFIG_RPR0521 is enabled without CONFIG_IIO_TRIGGERED_BUFFER, the build results in "implicit declaration of function" errors, e.g.,
drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function

Quoted 8 lines
           'iio_trigger_poll_chained' [-Werror=implicit-function-declaration]
    434 |   iio_trigger_poll_chained(data->drdy_trigger0);
        |   ^~~~~~~~~~~~~~~~~~~~~~~~

This fix adds select dependencies to RPR0521's configuration declaration.

No need to create a bugzilla report on such tiny issues that do actually not affect the working configurations.

FWIW,

Quoted 22 lines

---
V1 -> V2: Cleaned up commit message per reviewer comments and added link
to bug report.

 drivers/iio/light/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/light/Kconfig +2 -0
index 7cf6e8490123..0d4447df7200 100644
@@ -293,6 +293,8 @@ config RPR0521
 	tristate "ROHM RPR0521 ALS and proximity sensor driver"
 	depends on I2C
 	select REGMAP_I2C
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say Y here if you want to build support for ROHM's RPR0521
 	  ambient light and proximity sensor device.
Signature · 1 line
2.25.1
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw
Quoted 10 lines · Andy Shevchenko
Quoted 9 lines · Paul Gazzillo

Fix an implicit declaration of function error for rpr0521 under some configs

When CONFIG_RPR0521 is enabled without CONFIG_IIO_TRIGGERED_BUFFER, the build results in "implicit declaration of function" errors, e.g.,
drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function

           'iio_trigger_poll_chained' [-Werror=implicit-function-declaration]
    434 |   iio_trigger_poll_chained(data->drdy_trigger0);
        |   ^~~~~~~~~~~~~~~~~~~~~~~~
Quoted 7 lines
Quoted 4 lines

This fix adds select dependencies to RPR0521's configuration declaration.

No need to create a bugzilla report on such tiny issues that do actually not affect the working configurations.

Understood. Thanks for your help!

Quoted 11 lines

FWIW,

Quoted 7 lines

---
V1 -> V2: Cleaned up commit message per reviewer comments and added link
to bug report.

 drivers/iio/light/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
Quoted 19 lines
Quoted 15 lines
drivers/iio/light/Kconfig +2 -0
index 7cf6e8490123..0d4447df7200 100644
@@ -293,6 +293,8 @@ config RPR0521
 	tristate "ROHM RPR0521 ALS and proximity sensor driver"
 	depends on I2C
 	select REGMAP_I2C
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say Y here if you want to build support for ROHM's RPR0521
 	  ambient light and proximity sensor device.
Signature · 1 line
2.25.1
Signature · 2 lines
With Best Regards,
Andy Shevchenko

Best,
Paul

maintainer Applied
#6 lore raw
Quoted 13 lines · On Fri, 11 Nov 2022 10:25:39 -0500 Paul Gazzillo <[email protected]> wrote:
Quoted 12 lines · Andy Shevchenko
Quoted 11 lines · Paul Gazzillo

Fix an implicit declaration of function error for rpr0521 under some configs

When CONFIG_RPR0521 is enabled without CONFIG_IIO_TRIGGERED_BUFFER, the build results in "implicit declaration of function" errors, e.g.,
drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function

           'iio_trigger_poll_chained' [-Werror=implicit-function-declaration]
    434 |   iio_trigger_poll_chained(data->drdy_trigger0);
        |   ^~~~~~~~~~~~~~~~~~~~~~~~

This fix adds select dependencies to RPR0521's configuration declaration.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

No need to create a bugzilla report on such tiny issues that do actually not affect the working configurations.

Understood. Thanks for your help!

I wonder why it has taken so long for this build issue to get reported?

Ah well. This is missing a fixes tag. I added

Fixes e12ffd241c00 ("iio: light: rpr0521 triggered buffer")

Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

Quoted 34 lines
Quoted 12 lines

FWIW,

Quoted 7 lines

---
V1 -> V2: Cleaned up commit message per reviewer comments and added link
to bug report.

 drivers/iio/light/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
Quoted 19 lines
Quoted 15 lines
drivers/iio/light/Kconfig +2 -0
index 7cf6e8490123..0d4447df7200 100644
@@ -293,6 +293,8 @@ config RPR0521
 	tristate "ROHM RPR0521 ALS and proximity sensor driver"
 	depends on I2C
 	select REGMAP_I2C
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say Y here if you want to build support for ROHM's RPR0521
 	  ambient light and proximity sensor device.
Signature · 1 line
2.25.1  
Signature · 2 lines
With Best Regards,
Andy Shevchenko  

Best,
Paul

#7 lore raw
Quoted 19 lines · Jonathan Cameron
Quoted 16 lines · On Fri, 11 Nov 2022 10:25:39 -0500 Paul Gazzillo <[email protected]> wrote:
Quoted 15 lines · Andy Shevchenko
Quoted 13 lines · Paul Gazzillo

Fix an implicit declaration of function error for rpr0521 under some configs

When CONFIG_RPR0521 is enabled without CONFIG_IIO_TRIGGERED_BUFFER, the build results in "implicit declaration of function" errors, e.g.,
drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function

           'iio_trigger_poll_chained' [-Werror=implicit-function-declaration]
    434 |   iio_trigger_poll_chained(data->drdy_trigger0);
        |   ^~~~~~~~~~~~~~~~~~~~~~~~

This fix adds select dependencies to RPR0521's configuration declaration.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

No need to create a bugzilla report on such tiny issues that do actually not affect the working configurations.

Understood. Thanks for your help!

I wonder why it has taken so long for this build issue to get reported?

There seem to be lots of combinations of configuration options that don't get tested or even built (understandably, given the enormous number of options), leaving Kconfig with an incomplete picture of dependencies. There's just too many to test, though if users are only using some predefined .config files (or testers are using only allyesconfig) they may not encounter these corner cases that slip through Kconfig (and maybe these cases aren't really very high impact). Our team's been researching how to better test across configurations; one of our tools for finding unmet Kconfig dependency bugs (kismet) is now being run by Intel's kernel test robot, but we're also working on how to improve run-time testing as well, and I ran across a configuration that triggered this build error. In case you're interested, here's our current tooling:
https://github.com/paulgazz/kmax
Let me know if you have any related painpoints that this work might help with. I work in academia with funding that encourages open-sourcing the results, so it's great to have real-world problems that can provide a tangible benefit.

Quoted 2 lines

Ah well. This is missing a fixes tag. I added

Fixes e12ffd241c00 ("iio: light: rpr0521 triggered buffer")

Thank you!

Quoted 43 lines

Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

Quoted 34 lines
Quoted 12 lines

FWIW,

Quoted 7 lines

---
V1 -> V2: Cleaned up commit message per reviewer comments and added link
to bug report.

 drivers/iio/light/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
Quoted 19 lines
Quoted 15 lines
drivers/iio/light/Kconfig +2 -0
index 7cf6e8490123..0d4447df7200 100644
@@ -293,6 +293,8 @@ config RPR0521
 	tristate "ROHM RPR0521 ALS and proximity sensor driver"
 	depends on I2C
 	select REGMAP_I2C
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say Y here if you want to build support for ROHM's RPR0521
 	  ambient light and proximity sensor device.
Signature · 1 line
2.25.1  
Signature · 2 lines
With Best Regards,
Andy Shevchenko  

Best,
Paul